styling and file support overhaul #884

2019-01-26T08:11:35+01:00

jessopb commented

2019-01-26 08:11:35 +01:00

(Migrated from github.com)

Does (1) AssetPreviews of #586 (still open)
Does #880 SVG (duplicate issue) (will be closed)
Does #752 and #417 MD markdown in content and descriptions (will be closed)
Solves #627 - video frame size, caused by specifying a minimum height for the player. (will be closed)
Lays groundwork for #587 (markdown for instance pages)
Lays groundwork for the rest of #572 - got SVGs, what about other adobe files?
Lays groundwork for #133 PDFs - system to load documents
Does much of #870 css cleanup, creating variables

Does (1) AssetPreviews of #586 (still open) Does #880 SVG (duplicate issue) (will be closed) Does #752 and #417 MD markdown in content and descriptions (will be closed) Solves #627 - video frame size, caused by specifying a minimum height for the player. (will be closed) Lays groundwork for #587 (markdown for instance pages) Lays groundwork for the rest of #572 - got SVGs, what about other adobe files? Lays groundwork for #133 PDFs - system to load documents Does much of #870 css cleanup, creating variables

jessopb (Migrated from github.com) reviewed 2019-01-26 20:50:17 +01:00

client/src/components/FileViewer/index.jsx

					
				@ -0,0 +27,4 @@

				        return true;

				      })

				      .catch(e => { console.log('fetch aborted on unmount ', e) });

				  }

jessopb (Migrated from github.com) commented

2019-01-26 20:50:16 +01:00

The signal /abortController piece prevents memory leak from not resolving a fetch promise on unmount. Currently the way I catch the error throws a console log in the browser. Maybe there's a better way.

skhameneh commented

2019-01-28 03:48:26 +01:00

(Migrated from github.com)

You forgot to assign this @jessopb, is this ready for review?

jessopb commented

2019-01-28 04:18:21 +01:00

(Migrated from github.com)

Please review. It does not complete all of the bullet points I laid out, in #586, for example, There is no good generalized display for unsupported content that puts the right foot forward.

skhameneh (Migrated from github.com) approved these changes 2019-01-28 21:07:52 +01:00

Sign in to join this conversation.

No reviewers

skhameneh

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#884