Slack messaging #169

2017-09-15T01:07:28+02:00

bones7242 commented

2017-09-15 01:07:28 +02:00

(Migrated from github.com)

added winston-slack-webhook npm package and configured to send spee.ch logs to slack.

error logs are being sent to #slack-errors
info logs are being sent to #slack-logs
both are configurable in the /config/production.json file

added `winston-slack-webhook` npm package and configured to send spee.ch logs to slack. - error logs are being sent to #slack-errors - info logs are being sent to #slack-logs both are configurable in the `/config/production.json` file

kauffj commented

2017-09-16 00:14:03 +02:00

(Migrated from github.com)

Is this WIP or actually needs review?

bones7242 commented

2017-09-16 00:20:20 +02:00

(Migrated from github.com)

@kauffj review if you have any input on it. It's not central to key spee.ch functionality, but necessary for monitoring status.

kauffj (Migrated from github.com) reviewed

2017-09-16 00:20:42 +02:00

kauffj (Migrated from github.com) left a comment

Notes.

Also: how user-friendly is this setup if someone doesn't want to use Slack? Is this all disabled by default and out of the way if someone forks this project?

Notes. Also: how user-friendly is this setup if someone doesn't want to use Slack? Is this all disabled by default and out of the way if someone forks this project?

helpers/errorHandlers.js

					
				@ -4,0 +4,4 @@

				function useObjectPropertiesIfNoKeys (err) {

				  if (Object.keys(err).length === 0) {

				    let newErrorObject = {};

				    Object.getOwnPropertyNames(err).forEach((key) => {

When is there a non-enumerable property being passed that this is required?

package.json

					
				@ -42,2 +42,3 @@

				    "winston": "^2.3.1"

				    "winston": "^2.3.1",

				    "winston-slack-webhook": "billbitt/winston-slack-webhook"

				  },

should this be billbitt?

bones7242 (Migrated from github.com) reviewed

2017-09-21 21:10:37 +02:00

helpers/errorHandlers.js

					
				@ -4,0 +4,4 @@

				function useObjectPropertiesIfNoKeys (err) {

				  if (Object.keys(err).length === 0) {

				    let newErrorObject = {};

				    Object.getOwnPropertyNames(err).forEach((key) => {

for errors created by node (e.g. new Error('error message')) the stack and message are non-enumerable

for errors created by node (e.g. `new Error('error message')`) the stack and message are non-enumerable

bones7242 (Migrated from github.com) reviewed

2017-09-21 21:11:27 +02:00

package.json

					
				@ -42,2 +42,3 @@

				    "winston": "^2.3.1"

				    "winston": "^2.3.1",

				    "winston-slack-webhook": "billbitt/winston-slack-webhook"

				  },

I made my own fork to fix an issue with the package, and submitted a PR to the main package. The PR was accepted, so will update this to point to main package in next update.

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

LBRYCommunity/spee.ch!169

Rows
Columns