LBRYCommunity/spee.ch
1
0
Fork 0
Code Issues 95 Pull requests 2 Projects Releases 4 Packages Wiki Activity

Sequelize queries #234

Merged
bones7242 merged 10 commits from sequelize-queries into master 2017-11-03 16:35:42 +01:00
Conversation 4 Commits 10 Files changed 10 +322 -266
bones7242 commented 2017-11-01 04:46:12 +01:00 (Migrated from github.com)
Copy link
  • updated models to paramterize sql queries
- updated models to paramterize sql queries
kauffj (Migrated from github.com) reviewed 2017-11-03 18:47:07 +01:00
kauffj (Migrated from github.com) left a comment
Copy link

Oops, I typed all these up a few days ago and never hit submit on the review.

Oops, I typed all these up a few days ago and never hit submit on the review.
models/certificate.js
@ -1,4 +1,31 @@
module.exports = (sequelize, { STRING, BOOLEAN, INTEGER, TEXT, ARRAY, DECIMAL, DOUBLE }) => {
const logger = require('winston');
kauffj (Migrated from github.com) commented 2017-11-01 14:33:06 +01:00
Copy link

Would it make sense for this to be Channel rather than Certificate?

Would it make sense for this to be `Channel` rather than `Certificate`?
models/certificate.js
@ -2,0 +2,4 @@
const NO_CHANNEL = 'NO_CHANNEL';
function sortResult (result, longId) {
let claimIndex;
kauffj (Migrated from github.com) commented 2017-11-01 14:29:47 +01:00
Copy link

This function is called sortResult but it appears to return a short Id.

This function is called `sortResult` but it appears to return a short Id.
models/claim.js
@ -2,0 +2,4 @@
const NO_CLAIM = 'NO_CLAIM';
function sortResult (result, longId) {
let claimIndex;
kauffj (Migrated from github.com) commented 2017-11-01 14:31:42 +01:00
Copy link

This function seems to contain code that could be shared with the other sortResult.

(This function has same naming problem as well.)

This function seems to contain code that could be shared with the other `sortResult`. (This function has same naming problem as well.)
routes/api-routes.js
@ -147,7 +147,8 @@ module.exports = (app) => {
// route to get a short claim id from long claim Id
app.get('/api/shortClaimId/:longId/:name', ({ originalUrl, ip, params }, res) => {
kauffj (Migrated from github.com) commented 2017-11-01 14:34:49 +01:00
Copy link

I'm guessing this code isn't actually missing a colon or it wouldn't work, but what's the difference here?

I'm guessing this code isn't actually missing a colon or it wouldn't work, but what's the difference here?
bones7242 (Migrated from github.com) reviewed 2017-11-04 00:43:11 +01:00
models/certificate.js
@ -1,4 +1,31 @@
module.exports = (sequelize, { STRING, BOOLEAN, INTEGER, TEXT, ARRAY, DECIMAL, DOUBLE }) => {
const logger = require('winston');
bones7242 (Migrated from github.com) commented 2017-11-04 00:43:10 +01:00
Copy link

I think Certificate is accurate because it is actually storing the certificate claims from the blockchain. We have a Channel table for the Channels that are created on spee.ch. It parallels how we have a Claim table for all the stream claims in the blockchain (i guess this table should be Streams to be fully parallel) and a File table for all the files held locally by spee.ch.

I think Certificate is accurate because it is actually storing the certificate claims from the blockchain. We have a Channel table for the Channels that are created on spee.ch. It parallels how we have a Claim table for all the stream claims in the blockchain (i guess this table should be Streams to be fully parallel) and a File table for all the files held locally by spee.ch.
bones7242 (Migrated from github.com) reviewed 2017-11-04 01:06:47 +01:00
routes/api-routes.js
@ -147,7 +147,8 @@ module.exports = (app) => {
// route to get a short claim id from long claim Id
app.get('/api/shortClaimId/:longId/:name', ({ originalUrl, ip, params }, res) => {
bones7242 (Migrated from github.com) commented 2017-11-04 01:06:47 +01:00
Copy link

the line break was accidental; difference was just adding Claim because getShortClaimId... is now a method of Claim

the line break was accidental; difference was just adding Claim because getShortClaimId... is now a method of Claim
kauffj (Migrated from github.com) reviewed 2017-11-06 17:58:11 +01:00
models/certificate.js
@ -1,4 +1,31 @@
module.exports = (sequelize, { STRING, BOOLEAN, INTEGER, TEXT, ARRAY, DECIMAL, DOUBLE }) => {
const logger = require('winston');
kauffj (Migrated from github.com) commented 2017-11-06 17:58:11 +01:00
Copy link

@billbitt got it

@billbitt got it
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
Osprey

Spee.ch special project

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: error handling

   
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Osprey
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
resilience
Tom's Wishlist
type: bug
type: discussion
type: error handling
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#234
No description provided.
Delete branch "sequelize-queries"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?