vertically align channel contents and reverse order #476

Merged

bones7242 merged 2 commits from 433-vertical-align into master

2018-06-14 22:08:03 +02:00

bones7242 commented

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) requested changes 2018-06-14 21:03:56 +02:00

neb-b (Migrated from github.com) left a comment

Two extra console logs.

I would squash your commits too. No need to have several "{remove/add} console logs" commits

Two extra console logs. I would squash your commits too. No need to have several "{remove/add} console logs" commits

neb-b (Migrated from github.com) commented

Not needed.

neb-b (Migrated from github.com) commented

Same here

bones7242 (Migrated from github.com) reviewed 2018-06-14 21:23:11 +02:00

bones7242 (Migrated from github.com) commented

my concern was I didn't want the function to return early silently. I replaced the above console logs with errors.

neb-b commented

(Migrated from github.com)

Cool. Just squash your commits and it's good to go.

neb-b (Migrated from github.com) approved these changes 2018-06-14 21:29:54 +02:00

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#476

No description provided.