rename proto to avoid namespace conflicts when importing v1+v2 #24
No reviewers
Labels
No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/types#24
Loading…
Reference in a new issue
No description provided.
Delete branch "minor_changes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
feel free to pick another name, we just cant have two "claim.proto" as it conflicts
whats the actual problem. is it the filename or the class names?
just the file name (it picks the file name as the proto name on generated code; We dont use it but protobuf complains when you import two with the same name)
can we change v1 instead of v2? or does v1 need to stay as it is?
do we need to change
pb
->pb3
?changed v1 file name and package. Yes, the package conflicts too because the class names are the same.
v1 claim.proto is now legacy_claim.proto and package is legacy_pb instead of pb
Pull request closed