rename proto to avoid namespace conflicts when importing v1+v2 #24

Closed

shyba wants to merge 3 commits from minor_changes into master

shyba commented

2019-03-01 21:07:38 +01:00

(Migrated from github.com)

feel free to pick another name, we just cant have two "claim.proto" as it conflicts

lyoshenka (Migrated from github.com) reviewed 2019-03-01 21:07:38 +01:00

lyoshenka commented

2019-03-01 21:43:01 +01:00

(Migrated from github.com)

whats the actual problem. is it the filename or the class names?

shyba commented

2019-03-01 22:36:14 +01:00

(Migrated from github.com)

just the file name (it picks the file name as the proto name on generated code; We dont use it but protobuf complains when you import two with the same name)

lyoshenka commented

2019-03-02 19:41:05 +01:00

(Migrated from github.com)

can we change v1 instead of v2? or does v1 need to stay as it is?

do we need to change pb -> pb3?

can we change v1 instead of v2? or does v1 need to stay as it is? do we need to change `pb` -> `pb3`?

shyba commented

2019-03-03 00:16:22 +01:00

(Migrated from github.com)

changed v1 file name and package. Yes, the package conflicts too because the class names are the same.
v1 claim.proto is now legacy_claim.proto and package is legacy_pb instead of pb

changed v1 file name and package. Yes, the package conflicts too because the class names are the same. v1 claim.proto is now legacy_claim.proto and package is legacy_pb instead of pb

Pull request closed

Please reopen this pull request to perform a merge.

No reviewers

lyoshenka

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/types#24

No description provided.