Add wallet.json #48
No reviewers
Labels
No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/types#48
Loading…
Reference in a new issue
No description provided.
Delete branch "wallet.json"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
One question would be what directory it should go in.
@ -0,0 +101,4 @@
"description": "Timestamped application-level preferences. Values can be objects or of a primitive type.",
"$comment": "enable-sync is seen in example wallet. encrypt-on-disk is seen in example wallet. they both have a boolean `value` field. Do we want them explicitly defined here? local and shared seem to have at least a similar structure (type, value [yes, again], version), value being the free-form part. Should we define those here? Or can there be any key under preferences, and `value` be literally be anything in any form?",
"type": "object",
"additionalProperties": {
We have
shared
andlocal
but I think as far as the sdk cares it's any key.@ -0,0 +25,4 @@
"address_generator": {
"description": "Higher level manager of either singular or deterministically generated addresses",
"type": "object",
"oneOf": [
We can actually enforce that
name=determinstic-chain
comes withchange
andreceiving
, andsingle-address
does not.this looks good. you're right that its not clear where this code goes. the whole repo is focused on protobufs. the readme describes how to compile them, and so on.
we're in the process of restructuring our repos a bit, so there's a chance your PR (or even this whole repo) will move elsewhere. i'll merge this for now and move it to a toplevel
jsonschema
dirCool, just keep in mind that my PR in lbry-sdk depends on the location of the file:
https://github.com/lbryio/lbry-sdk/pull/3572/files#diff-c8a3e8308e908f1b3ec4c3fdf457d082ccc2c21f4c4863b8888c60b296e0a1c8R5
Oh never mind, you already moved it. I'll update the PR now then.