Add wallet.json #48

2022-02-16T00:41:42+01:00

orblivion commented

2022-02-16 00:41:42 +01:00

(Migrated from github.com)

One question would be what directory it should go in.

orblivion (Migrated from github.com) reviewed 2022-02-16 01:45:32 +01:00

v2/json/wallet.json

					
				@ -0,0 +101,4 @@

				      "description": "Timestamped application-level preferences. Values can be objects or of a primitive type.",

				      "$comment": "enable-sync is seen in example wallet. encrypt-on-disk is seen in example wallet. they both have a boolean `value` field. Do we want them explicitly defined here? local and shared seem to have at least a similar structure (type, value [yes, again], version), value being the free-form part. Should we define those here? Or can there be any key under preferences, and `value` be literally be anything in any form?",

				      "type": "object",

				      "additionalProperties": {

orblivion (Migrated from github.com) commented

2022-02-16 01:45:32 +01:00

We have shared and local but I think as far as the sdk cares it's any key.

We have `shared` and `local` but I think as far as the sdk cares it's any key.

orblivion (Migrated from github.com) reviewed 2022-02-16 01:46:58 +01:00

v2/json/wallet.json

					
				@ -0,0 +25,4 @@

				          "address_generator": {

				            "description": "Higher level manager of either singular or deterministically generated addresses",

				            "type": "object",

				            "oneOf": [

orblivion (Migrated from github.com) commented

2022-02-16 01:46:57 +01:00

We can actually enforce that name=determinstic-chain comes with change and receiving, and single-address does not.

We can actually enforce that `name=determinstic-chain` comes with `change` and `receiving`, and `single-address` does not.

lyoshenka commented

2022-02-24 15:21:00 +01:00

(Migrated from github.com)

this looks good. you're right that its not clear where this code goes. the whole repo is focused on protobufs. the readme describes how to compile them, and so on.

we're in the process of restructuring our repos a bit, so there's a chance your PR (or even this whole repo) will move elsewhere. i'll merge this for now and move it to a toplevel jsonschema dir

this looks good. you're right that its not clear where this code goes. the whole repo is focused on protobufs. the readme describes how to compile them, and so on. we're in the process of restructuring our repos a bit, so there's a chance your PR (or even this whole repo) will move elsewhere. i'll merge this for now and move it to a toplevel `jsonschema` dir

orblivion commented

2022-02-24 23:34:34 +01:00

(Migrated from github.com)

Cool, just keep in mind that my PR in lbry-sdk depends on the location of the file:

https://github.com/lbryio/lbry-sdk/pull/3572/files#diff-c8a3e8308e908f1b3ec4c3fdf457d082ccc2c21f4c4863b8888c60b296e0a1c8R5

Cool, just keep in mind that my PR in lbry-sdk depends on the location of the file: https://github.com/lbryio/lbry-sdk/pull/3572/files#diff-c8a3e8308e908f1b3ec4c3fdf457d082ccc2c21f4c4863b8888c60b296e0a1c8R5

orblivion commented

2022-02-24 23:43:59 +01:00

(Migrated from github.com)

Oh never mind, you already moved it. I'll update the PR now then.

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/types#48