Add hub.proto and update trending fields in search request pb #46

Closed

jackrobison wants to merge 2 commits from add-hub-proto into master

jackrobison commented

2021-09-15 04:58:21 +02:00

(Migrated from github.com)

No description provided.

lyoshenka (Migrated from github.com) reviewed 2021-09-21 19:01:45 +02:00

lyoshenka (Migrated from github.com) left a comment

feels like things like this should be in the hub repo, not here

service Hub {
  rpc Search (SearchRequest) returns (Outputs) {}
}

what does python -m grpc_tools.protoc do?

why did you add option go_package = "github.com/lbryio/types/go/pb"; to each proto file?

feels like things like this should be in the hub repo, not here ``` service Hub { rpc Search (SearchRequest) returns (Outputs) {} } ``` what does `python -m grpc_tools.protoc` do? why did you add `option go_package = "github.com/lbryio/types/go/pb";` to each proto file?

Pull request closed

Please reopen this pull request to perform a merge.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/types#46

No description provided.