LBRYCommunity/types

Fork 0

Add C++ protobuf generated code #5

Merged

qiell merged 2 commits from c++-protobuf-code into master

2018-10-01 19:59:39 +02:00

qiell commented

2018-09-30 22:28:39 +02:00

(Migrated from github.com)

protoc --proto_path=proto --cpp_out=cpp/ proto/certificate.proto proto/claim.proto proto/fee.proto proto/metadata.proto proto/signature.proto proto/source.proto proto/stream.proto

Signed-off-by: Akash Srivastava akash.srivastava@openebs.io

fixes: #4

``` protoc --proto_path=proto --cpp_out=cpp/ proto/certificate.proto proto/claim.proto proto/fee.proto proto/metadata.proto proto/signature.proto proto/source.proto proto/stream.proto ``` Signed-off-by: Akash Srivastava <akash.srivastava@openebs.io> fixes: #4

bvbfan commented

2018-10-01 08:32:16 +02:00

(Migrated from github.com)

Can you update bash script as well, it has check for minimum version.
https://github.com/lbryio/types/blob/master/build.sh#L30

Can you update bash script as well, it has check for minimum version. https://github.com/lbryio/types/blob/master/build.sh#L30

qiell commented

2018-10-01 09:06:24 +02:00

(Migrated from github.com)

Sure @bvbfan , I'll update it :)

qiell commented

2018-10-01 09:12:11 +02:00

(Migrated from github.com)

@bvbfan Updated the bash file.

tzarebczan commented

2018-10-01 17:47:28 +02:00

(Migrated from github.com)

@Akash4927 Thanks for the contribution! Can we send you some LBC in appreciation?

@Akash4927 Thanks for the contribution! Can we send you some [LBC in appreciation](https://lbry.io/faq/tips)?

❤️ 1

qiell commented

2018-10-01 17:53:01 +02:00

(Migrated from github.com)

@tzarebczan That'll be great 😃
Looking forward to contribute more

@tzarebczan That'll be great :smiley: Looking forward to contribute more

lyoshenka commented

2018-10-01 19:51:56 +02:00

(Migrated from github.com)

could you change the dir name from c++ to cpp, add it to line 27 too. using pluses in dir names can cause issues down the road. other than that, looks good to me. thanks!

could you change the dir name from `c++` to `cpp`, add it to line 27 too. using pluses in dir names can cause issues down the road. other than that, looks good to me. thanks!

qiell commented

2018-10-01 19:55:01 +02:00

(Migrated from github.com)

Sure @lyoshenka

qiell commented

2018-10-01 19:59:55 +02:00

(Migrated from github.com)

@lyoshenka Thanks :)

lyoshenka commented

2018-10-01 20:00:34 +02:00

(Migrated from github.com)

thanks @Akash4927. let me know if you're interested in contributing in any other way. i'd be happy to help you find something cool and/or challenging.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/types#5

No description provided.