Commit graph

2581 commits

Author SHA1 Message Date
Wei Lu
7cac39633c Merge pull request #175 from dcousens/cryptoHmac
Consolidation of crypto functions
2014-05-13 09:46:27 +08:00
Wei Lu
1840f99c34 Merge pull request #174 from dcousens/hdbipad
HDWallet BIP32 adherence
2014-05-13 08:46:50 +08:00
Daniel Cousens
276a339d60 crypto: HMACSHA512 into crypto and add tests 2014-05-12 10:18:39 +10:00
Daniel Cousens
f70ccc9215 convert: remove hex functions 2014-05-12 10:17:38 +10:00
Daniel Cousens
614a213d44 Transaction: remove untested hash array support 2014-05-12 10:17:38 +10:00
Daniel Cousens
063643b4a1 HDWallet: show clearer BIP32 adherence for Master key 2014-05-12 09:56:00 +10:00
Daniel Cousens
3ed7d78e59 HDWallet: adhere to BIP32 for CKD 2014-05-10 09:57:16 +10:00
Daniel Cousens
25514d6ac1 HDWallet: remove HmacBytesToBytes 2014-05-10 09:57:16 +10:00
Daniel Cousens
da36003d09 Script: remove sort requirement for multisig 2014-05-09 18:03:41 +10:00
Daniel Cousens
de343b2093 Script: remove Address requirement 2014-05-09 18:03:22 +10:00
Wei Lu
631f7257ef Merge pull request #173 from dcousens/scriptclean
Cleanup of network in Transaction/Script
2014-05-09 15:51:20 +08:00
Daniel Cousens
f18c5e4c1e Script: removes Script.createP2SHMultiSigScriptSig
It is favoured to compose the scriptSig manually using
Script.createP2SHScriptSig and Script.createMultisigScriptSig.

Added a test to verify that createMultisigScriptSig throws when not
enough signatures a provided and the redeemScript is given.
2014-05-09 16:26:35 +10:00
Daniel Cousens
f8e662e495 Script: rename toScriptHash to getHash and add tests 2014-05-09 13:07:06 +10:00
Daniel Cousens
cace8316e4 Script: extract test data to fixture 2014-05-09 12:56:35 +10:00
Daniel Cousens
342c55c864 Address: remove circular dependency fix
This is no longer a problem.
2014-05-09 12:26:38 +10:00
Daniel Cousens
48e15b587a Address: remove redundant comments 2014-05-09 12:25:24 +10:00
Daniel Cousens
708aa03390 Transaction/Script: bitcoin network no longer implied
A Transaction (and its subsequent scripts) do not carry any network
specific information in the Bitcoin protocol.
Therefore they can not (without further context) produce the network
specific constants for the generation of the base58 Addresses.

As TransactionOut.address is used heavily throughout Wallet and other
areas of the library, this could not be entirely removed without a large
number of changes.
For now, TransactionOut.address is only defined in the case of
Tx.addOutput being used directly:

      Transaction.addOutput(address, value)
2014-05-08 10:59:58 +10:00
Daniel Cousens
4207a0df99 Address: use Address.Error instead
This change is necessary for instanceof comparison when attempting to
rethrow.  Callbacks may be a better solution to introduce later.
2014-05-08 10:59:58 +10:00
Daniel Cousens
5e0d38ba54 Address: add Address.*ScriptPubKey and tests
The introduction of these two functions allow for the all the network
related code to be eventually removed from Transaction and Script.

Previously the result for non-standard transactions was undefined
behaviour.  This change mandates that an exception is thrown if a
non-standard transaction is input.
2014-05-08 10:59:58 +10:00
Daniel Cousens
0822def7e0 Script: add standard Script.create*ScriptPubKey
Extracts the two Script types out of Script.createOutputScript, and puts
them both under test.

Also renames Script.createMultiSigOutputScript to adhere to the same
convention.
2014-05-08 10:59:58 +10:00
Daniel Cousens
d0f684844c Script: add toHex, fromHex
Script.fromHex previously existed, but was not under any kind of test.
This commit adds tests (despite being a little circular in nature) to
check that the output is as expected.
2014-05-08 10:59:58 +10:00
Daniel Cousens
57b8afbdab Network: rename Network to Networks
This change removes the most common ambiguities.
As the network module is not representative of a class, the lower case
has been used.
2014-05-08 10:59:58 +10:00
Daniel Cousens
929b8d2b62 Script: more consistent input handling 2014-05-08 10:59:58 +10:00
Daniel Cousens
7ad695e427 Script: fix assertion message grammar 2014-05-08 10:59:58 +10:00
Daniel Cousens
74e53b49a5 Script/Transaction: remove untested functions
These functions are not under test, and are unnecessary bloat due to a
confusing API.

Script.from*(asmStr) were two functions that attempted to parse ASM
codes and produce a script from this.
While useful, an parser can be introduced later under a single function
and under test... removed.

Although Script.extractPublicKeys implementation is likely to be correct,
it is not absolute in that what it returns is even strictly a set of
public keys.
It is a useful function, but can be done in a better way later,
probably checking against the Script templates instead.

Transaction.signWithKeys has some inherent undocumented behaviour, and it is not
clear when you would use it over just Transaction.addOutput and
Transaction.sign individually.  Nor does it mimic anything in the
bitcoind API... removed.
2014-05-08 10:59:58 +10:00
Daniel Cousens
76323a07d0 Transaction: restrict TxIn/TxOut constructor params
To keep this change minimal, both TxIn/TxOut still use the parameter
object for initialization.  TxOut accepts only the types it uses
internally, and not hex or byte arrays for scripts.

The clone is unnecessary as a TransactionOut is never mutated after its
creation.

This resulted in TransactionOut.scriptPubKey no longer being needed,
and was removed.  To access the scriptPubKey as a byte buffer, a user
can simply use:

	TransactionOut.script.toBuffer()

Unfortunately, this leaves TransactionOut in a sorry state of test.
Something that needs to be fixed.
2014-05-08 10:59:58 +10:00
Daniel Cousens
9a7e291d70 Transaction: fix incorrect outIndex type 2014-05-08 08:52:07 +10:00
Wei Lu
bd2a6db260 Merge pull request #172 from dcousens/ext159
Extends #159 to further verify behaviour
2014-05-08 01:01:44 +08:00
Daniel Cousens
63231fb67d Extends test for custom Wallet change addresses 2014-05-06 15:40:40 +10:00
Daniel Cousens
a77846701f Fixes network support for TxOut 2014-05-06 15:40:40 +10:00
Daniel Cousens
4012b82bec Fixes Transaction.addOutput(Address, Number) 2014-05-06 15:40:40 +10:00
Daniel Cousens
695eb64a3a Clarifies Transaction.addOutput param documentation 2014-05-06 15:40:40 +10:00
Daniel Cousens
eba08fa761 Fixes indentation for assertions 2014-05-06 15:40:40 +10:00
Daniel Cousens
d65a3c36e2 Merge pull request #159 from williamcotton/master
fixed issues with testnet and createTx
2014-05-06 08:04:02 +10:00
Wei Lu
e59f824c3a move fixture sync script into fixtures folder
Also fixes require paths & dev dependency
2014-05-05 13:46:00 +08:00
Wei Lu
5deab5188f Merge pull request #170 from dcousens/bufferx
BufferExt and Transaction serialization to use Buffers
2014-05-05 12:40:51 +08:00
Daniel Cousens
baa568697b Transaction.deserialize no longer mutates input 2014-05-05 09:11:37 +10:00
Daniel Cousens
02013beda9 Renames variables to be more verbose 2014-05-05 09:11:37 +10:00
Daniel Cousens
b860daf70b Corrects endianness comments 2014-05-04 17:31:47 +10:00
Daniel Cousens
87048d3b4e Adds performance notes 2014-05-04 17:31:47 +10:00
Daniel Cousens
4716eb29bf Removes redundant convert functions 2014-05-04 17:31:47 +10:00
Daniel Cousens
a8cf2fdd9e Changes internal serialization to use Buffers instead 2014-05-04 17:31:22 +10:00
Daniel Cousens
c8bda6dde6 Adds Buffer extensions 2014-05-04 17:30:59 +10:00
Wei Lu
69f88a7404 add integration test script 2014-05-04 14:25:34 +08:00
Wei Lu
33b73517fe fixes integration test dependency paths 2014-05-04 14:23:40 +08:00
Daniel Cousens
10ee5532c3 Serialize now returns a buffer 2014-05-04 15:37:25 +10:00
Daniel Cousens
d17f85f5a6 Changes fakeTxHash to actual hex 2014-05-04 15:37:25 +10:00
Daniel Cousens
09c6a787d9 Changes sequence number to an actual Number 2014-05-04 15:37:25 +10:00
Wei Lu
752aeae0d3 update integration test descriptions 2014-05-04 13:35:11 +08:00
Wei Lu
2affeda3f4 Restructure integration and coretests
Also update test script to pick up only tests directly under /test
2014-05-04 13:30:11 +08:00