Commit graph

2604 commits

Author SHA1 Message Date
Daniel Cousens
dc69162757 message: remove signing verification
The signature verifications here are unnecessary, as this
is not what is under test.
2014-05-18 17:51:36 +10:00
Daniel Cousens
10fe4474d1 ECKey: remove *Buffer/*Hex functions
An ECKey is a composition of a private key (D), a public key (Q) and its
compression flag.

These functions gave the impression of serialization of this
composition, when really they only serialized `D`.
They have therefore been removed in favour of always using a sane
serialization format (WIF) that matches the needed behaviour.

If a user needs the previous functionality, simply use `privKey.D.*`
instead of `privKey.*`, as BigInteger supports `*Buffer/*Hex` functions
as expected.
2014-05-18 17:50:10 +10:00
Daniel Cousens
bf109f32a9 ECPubKey: improve tests and extract test data to fixtures
The use of fixtures allows for more behavioural driven tests and simpler
addition of more test cases in future.

However, as ECPubKey is just a wrapper around other strenuously tested
modules, the test data is currently limited to testing a subset of the
total wrapper.

This should probably be done better by using mocked out modules instead.
2014-05-18 17:50:10 +10:00
Wei Lu
cf39de4035 Merge pull request #179 from dcousens/txscript
Transaction function naming and ordering
2014-05-18 07:58:20 +08:00
Daniel Cousens
0468c4710c Transaction: rename (de)serialize to [to/from]Buffer 2014-05-17 00:09:13 +10:00
Daniel Cousens
e033a872c9 Transaction: rename hashTransactionForSignature to hashForSignature 2014-05-17 00:09:13 +10:00
Daniel Cousens
55681e7e5d Script: use PubKey objects not prebuilt Buffers 2014-05-17 00:09:13 +10:00
Daniel Cousens
54cc123d31 Address/Script: consistent function ordering 2014-05-17 00:09:13 +10:00
Daniel Cousens
842b075e75 Address: consistent json formatting 2014-05-17 00:09:13 +10:00
Daniel Cousens
39d042d058 syncscript: general cleanup 2014-05-17 00:09:12 +10:00
Daniel Cousens
1e0521f7e5 Merge pull request #178 from bitcoinjs/integration-tests
Integration tests
2014-05-14 08:56:08 +10:00
Wei Lu
8063979d99 fix integration test 2014-05-13 22:03:11 +08:00
Wei Lu
a71685658b add integration build to travis 2014-05-13 22:03:11 +08:00
Daniel Cousens
b99ed46796 opcodes: rename to opcodes 2014-05-13 23:14:07 +10:00
Daniel Cousens
f9782b7c17 opcodes: remove unused reverseMap 2014-05-13 23:12:30 +10:00
Wei Lu
e835a6264d Merge pull request #177 from dcousens/opclean
OPcodes cleanup
2014-05-13 19:53:53 +08:00
Daniel Cousens
554ba250b9 opcode: less redundant indentation 2014-05-13 18:53:30 +10:00
Daniel Cousens
1fe8282eda Script: remove redundant opcode.map access 2014-05-13 18:53:30 +10:00
Wei Lu
9cd34f50d5 Merge pull request #176 from dcousens/rename
Project structure cleanup
2014-05-13 16:14:50 +08:00
Daniel Cousens
6c0eebe94b tests: use filepaths directly
After a long IRC discussion, it was decided that the use of direct
filepaths instead of the module is a more pure form of testing ,
although it may provide less overall coverage than the mixed integration
style imports used previously.

This will need to be remedied by further integration testing in
/test/integration.
2014-05-13 18:05:56 +10:00
Daniel Cousens
e27c97a791 ECPubKey/ECKey: separate to two files 2014-05-13 16:51:06 +10:00
Daniel Cousens
05e0d08098 BufferExt: rename to bufferutils 2014-05-13 16:46:12 +10:00
Daniel Cousens
7a740c2e7b tests: forces consistent import syntax 2014-05-13 16:46:08 +10:00
Wei Lu
7cac39633c Merge pull request #175 from dcousens/cryptoHmac
Consolidation of crypto functions
2014-05-13 09:46:27 +08:00
Wei Lu
1840f99c34 Merge pull request #174 from dcousens/hdbipad
HDWallet BIP32 adherence
2014-05-13 08:46:50 +08:00
Daniel Cousens
276a339d60 crypto: HMACSHA512 into crypto and add tests 2014-05-12 10:18:39 +10:00
Daniel Cousens
f70ccc9215 convert: remove hex functions 2014-05-12 10:17:38 +10:00
Daniel Cousens
614a213d44 Transaction: remove untested hash array support 2014-05-12 10:17:38 +10:00
Daniel Cousens
063643b4a1 HDWallet: show clearer BIP32 adherence for Master key 2014-05-12 09:56:00 +10:00
Daniel Cousens
3ed7d78e59 HDWallet: adhere to BIP32 for CKD 2014-05-10 09:57:16 +10:00
Daniel Cousens
25514d6ac1 HDWallet: remove HmacBytesToBytes 2014-05-10 09:57:16 +10:00
Daniel Cousens
da36003d09 Script: remove sort requirement for multisig 2014-05-09 18:03:41 +10:00
Daniel Cousens
de343b2093 Script: remove Address requirement 2014-05-09 18:03:22 +10:00
Wei Lu
631f7257ef Merge pull request #173 from dcousens/scriptclean
Cleanup of network in Transaction/Script
2014-05-09 15:51:20 +08:00
Daniel Cousens
f18c5e4c1e Script: removes Script.createP2SHMultiSigScriptSig
It is favoured to compose the scriptSig manually using
Script.createP2SHScriptSig and Script.createMultisigScriptSig.

Added a test to verify that createMultisigScriptSig throws when not
enough signatures a provided and the redeemScript is given.
2014-05-09 16:26:35 +10:00
Daniel Cousens
f8e662e495 Script: rename toScriptHash to getHash and add tests 2014-05-09 13:07:06 +10:00
Daniel Cousens
cace8316e4 Script: extract test data to fixture 2014-05-09 12:56:35 +10:00
Daniel Cousens
342c55c864 Address: remove circular dependency fix
This is no longer a problem.
2014-05-09 12:26:38 +10:00
Daniel Cousens
48e15b587a Address: remove redundant comments 2014-05-09 12:25:24 +10:00
Daniel Cousens
708aa03390 Transaction/Script: bitcoin network no longer implied
A Transaction (and its subsequent scripts) do not carry any network
specific information in the Bitcoin protocol.
Therefore they can not (without further context) produce the network
specific constants for the generation of the base58 Addresses.

As TransactionOut.address is used heavily throughout Wallet and other
areas of the library, this could not be entirely removed without a large
number of changes.
For now, TransactionOut.address is only defined in the case of
Tx.addOutput being used directly:

      Transaction.addOutput(address, value)
2014-05-08 10:59:58 +10:00
Daniel Cousens
4207a0df99 Address: use Address.Error instead
This change is necessary for instanceof comparison when attempting to
rethrow.  Callbacks may be a better solution to introduce later.
2014-05-08 10:59:58 +10:00
Daniel Cousens
5e0d38ba54 Address: add Address.*ScriptPubKey and tests
The introduction of these two functions allow for the all the network
related code to be eventually removed from Transaction and Script.

Previously the result for non-standard transactions was undefined
behaviour.  This change mandates that an exception is thrown if a
non-standard transaction is input.
2014-05-08 10:59:58 +10:00
Daniel Cousens
0822def7e0 Script: add standard Script.create*ScriptPubKey
Extracts the two Script types out of Script.createOutputScript, and puts
them both under test.

Also renames Script.createMultiSigOutputScript to adhere to the same
convention.
2014-05-08 10:59:58 +10:00
Daniel Cousens
d0f684844c Script: add toHex, fromHex
Script.fromHex previously existed, but was not under any kind of test.
This commit adds tests (despite being a little circular in nature) to
check that the output is as expected.
2014-05-08 10:59:58 +10:00
Daniel Cousens
57b8afbdab Network: rename Network to Networks
This change removes the most common ambiguities.
As the network module is not representative of a class, the lower case
has been used.
2014-05-08 10:59:58 +10:00
Daniel Cousens
929b8d2b62 Script: more consistent input handling 2014-05-08 10:59:58 +10:00
Daniel Cousens
7ad695e427 Script: fix assertion message grammar 2014-05-08 10:59:58 +10:00
Daniel Cousens
74e53b49a5 Script/Transaction: remove untested functions
These functions are not under test, and are unnecessary bloat due to a
confusing API.

Script.from*(asmStr) were two functions that attempted to parse ASM
codes and produce a script from this.
While useful, an parser can be introduced later under a single function
and under test... removed.

Although Script.extractPublicKeys implementation is likely to be correct,
it is not absolute in that what it returns is even strictly a set of
public keys.
It is a useful function, but can be done in a better way later,
probably checking against the Script templates instead.

Transaction.signWithKeys has some inherent undocumented behaviour, and it is not
clear when you would use it over just Transaction.addOutput and
Transaction.sign individually.  Nor does it mimic anything in the
bitcoind API... removed.
2014-05-08 10:59:58 +10:00
Daniel Cousens
76323a07d0 Transaction: restrict TxIn/TxOut constructor params
To keep this change minimal, both TxIn/TxOut still use the parameter
object for initialization.  TxOut accepts only the types it uses
internally, and not hex or byte arrays for scripts.

The clone is unnecessary as a TransactionOut is never mutated after its
creation.

This resulted in TransactionOut.scriptPubKey no longer being needed,
and was removed.  To access the scriptPubKey as a byte buffer, a user
can simply use:

	TransactionOut.script.toBuffer()

Unfortunately, this leaves TransactionOut in a sorry state of test.
Something that needs to be fixed.
2014-05-08 10:59:58 +10:00
Daniel Cousens
9a7e291d70 Transaction: fix incorrect outIndex type 2014-05-08 08:52:07 +10:00