lbcdblocknotify: support multiple stratum server #100

2022-10-18T11:20:53+02:00

peterpan0708 commented

2022-10-18 11:20:53 +02:00

(Migrated from github.com)

support notify to multiple stratum servers

roylee17 (Migrated from github.com) reviewed 2022-10-18 21:08:00 +02:00

rpcclient/examples/lbcdblocknotify/main.go

roylee17 (Migrated from github.com) commented

2022-10-18 21:07:59 +02:00

 *f = strings.Split(value, ",")

``` *f = strings.Split(value, ",") ```

roylee17 (Migrated from github.com) reviewed 2022-10-18 21:08:04 +02:00

rpcclient/examples/lbcdblocknotify/main.go

					
				@ -43,3 +53,1 @@

							log.Fatalf("ERROR: %s not found: %s", cmd, err)

						}

						b.customCmd = *run

							// Start the eventt handler.

roylee17 (Migrated from github.com) commented

2022-10-18 21:08:03 +02:00

flag.Var(&stratumList, "stratum", "Stratum server list server[:port].  -stratum stratum1:3333,stratum2:3333")

``` flag.Var(&stratumList, "stratum", "Stratum server list server[:port]. -stratum stratum1:3333,stratum2:3333") ```

roylee17 commented

2022-10-18 21:13:48 +02:00

(Migrated from github.com)

LGTM.

Ideally, we'd like to fan out with multiple stratum connections(or clients), not multiple bridges.
But the current codebase is not friendly to extend it that way.

So I think we can have this working feature merged now and update it in future iterations.
A minor preference is to update the stratum flag to a list style as shown in those inline comments.

This has been requested by multiple pools. So, thanks a lot for the contribution :-)

LGTM. Ideally, we'd like to fan out with multiple stratum connections(or clients), not multiple bridges. But the current codebase is not friendly to extend it that way. So I think we can have this working feature merged now and update it in future iterations. A minor preference is to update the `stratum` flag to a list style as shown in those inline comments. This has been requested by multiple pools. So, thanks a lot for the contribution :-)

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin peterpan0708/lbcdblocknotify-support-multi-stratum-server:peterpan0708/lbcdblocknotify-support-multi-stratum-server

git checkout peterpan0708/lbcdblocknotify-support-multi-stratum-server

Merge

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff peterpan0708/lbcdblocknotify-support-multi-stratum-server

git checkout master

git merge --ff-only peterpan0708/lbcdblocknotify-support-multi-stratum-server

git checkout peterpan0708/lbcdblocknotify-support-multi-stratum-server

git rebase master

git checkout master

git merge --no-ff peterpan0708/lbcdblocknotify-support-multi-stratum-server

git checkout master

git merge --squash peterpan0708/lbcdblocknotify-support-multi-stratum-server

git checkout master

git merge --ff-only peterpan0708/lbcdblocknotify-support-multi-stratum-server

git checkout master

git merge peterpan0708/lbcdblocknotify-support-multi-stratum-server

git push origin master

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbcd#100