LBRYCommunity/lbry-android
1
0
Fork 0
Code Issues 155 Pull requests 6 Packages Projects Releases 84 Wiki Activity

I extracted dimension values into resource files #1151. #1219

Open
veritaslogix wants to merge 2 commits from veritaslogix/master into master
pull from: veritaslogix/master
merge into: LBRYCommunity:master
Conversation 2 Commits 2 Files changed 77 +1925 -1753
veritaslogix commented 2021-09-27 11:24:38 +02:00 (Migrated from github.com)
Copy link

(https://github.com/lbryio/lbry-android/issues/1151)

Hi there!
Because a lot of dimensions get reused, when I moved the dimensions file I used names like "large_1", "small_1", and "normal_1" for dimension values.

I tried this to cut down on repetitive values in the dimens file.

"small" values range between 0dp and 15dp
"normal" values range between 16dp to 119dp
"large" values are anything over 120dp (the largest is 480dp)

[PS, I submitted an application to LBRY for an android engineer position on September 9, 2021. This PR is part of my application process.]

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: 1151

What is the current behavior?

What is the new behavior?

Other information

(https://github.com/lbryio/lbry-android/issues/1151) Hi there! Because a lot of dimensions get reused, when I moved the dimensions file I used names like "large_1", "small_1", and "normal_1" for dimension values. I tried this to cut down on repetitive values in the dimens file. "small" values range between 0dp and 15dp "normal" values range between 16dp to 119dp "large" values are anything over 120dp (the largest is 480dp) [PS, I submitted an application to LBRY for an android engineer position on September 9, 2021. This PR is part of my application process.] ## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ ] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [x] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: 1151 ## What is the current behavior? ## What is the new behavior? ## Other information <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
kekkyojin commented 2021-09-27 11:53:08 +02:00 (Migrated from github.com)
Copy link

For the next time, I suggest you to use a new branch for yout changes instead of commiting to your master branch

For the next time, I suggest you to use a new branch for yout changes instead of commiting to your master branch
veritaslogix commented 2021-09-28 19:15:37 +02:00 (Migrated from github.com)
Copy link

Okay, thanks!

Okay, thanks!
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin veritaslogix/master:veritaslogix/master
git checkout veritaslogix/master

Merge

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff veritaslogix/master
git checkout master
git merge --ff-only veritaslogix/master
git checkout veritaslogix/master
git rebase master
git checkout master
git merge --no-ff veritaslogix/master
git checkout master
git merge --squash veritaslogix/master
git checkout master
git merge --ff-only veritaslogix/master
git checkout master
git merge veritaslogix/master
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android: closed alpha

   
android: open beta

   
app-parity

   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
creator

   
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
product review

   
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
android: closed alpha
android: open beta
app-parity
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
creator
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
product review
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#1219
No description provided.
Delete branch "veritaslogix/master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?