I extracted dimension values into resource files #1151. #1219

Open

veritaslogix wants to merge 2 commits from veritaslogix/master into master

veritaslogix commented

2021-09-27 11:24:38 +02:00

(Migrated from github.com)

(https://github.com/lbryio/lbry-android/issues/1151)

Hi there!
Because a lot of dimensions get reused, when I moved the dimensions file I used names like "large_1", "small_1", and "normal_1" for dimension values.

I tried this to cut down on repetitive values in the dimens file.

"small" values range between 0dp and 15dp
"normal" values range between 16dp to 119dp
"large" values are anything over 120dp (the largest is 480dp)

[PS, I submitted an application to LBRY for an android engineer position on September 9, 2021. This PR is part of my application process.]

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: 1151

What is the current behavior?

What is the new behavior?

Other information

(https://github.com/lbryio/lbry-android/issues/1151) Hi there! Because a lot of dimensions get reused, when I moved the dimensions file I used names like "large_1", "small_1", and "normal_1" for dimension values. I tried this to cut down on repetitive values in the dimens file. "small" values range between 0dp and 15dp "normal" values range between 16dp to 119dp "large" values are anything over 120dp (the largest is 480dp) [PS, I submitted an application to LBRY for an android engineer position on September 9, 2021. This PR is part of my application process.] ## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ ] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [x] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: 1151 ## What is the current behavior? ## What is the new behavior? ## Other information

kekkyojin commented

2021-09-27 11:53:08 +02:00

(Migrated from github.com)

For the next time, I suggest you to use a new branch for yout changes instead of commiting to your master branch

veritaslogix commented

2021-09-28 19:15:37 +02:00

(Migrated from github.com)

Okay, thanks!

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin veritaslogix/master:veritaslogix/master

git checkout veritaslogix/master

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout master

git merge --no-ff veritaslogix/master

git checkout veritaslogix/master

git rebase master

git checkout master

git merge --ff-only veritaslogix/master

git checkout veritaslogix/master

git rebase master

git checkout master

git merge --no-ff veritaslogix/master

git checkout master

git merge --squash veritaslogix/master