Keep the screen awake when playing videos or file page. #187

Merged

dan1d merged 1 commit from issue-151 into master

2018-07-18 14:23:18 +02:00

dan1d commented

2018-06-20 22:42:51 +02:00

(Migrated from github.com)

Closes #151
Thanks a lot @shockr on discord for the quick tutorial.
This pr Implements a Java module to keep the screen awake.

Theres a bit of dupplication code on the Java module, but thats the only way I managed to work, I''ve refactor the code to just be one function with a Boolean flag and that didn't work for me.
You can active it by using NativeModules.UtilityModule.keepAwakeOn(); and disable it by using NativeModules.UtilityModule.keepAwakeOff();

Closes #151 Thanks a lot @shockr on discord for the quick tutorial. This pr Implements a Java module to keep the screen awake. Theres a bit of dupplication code on the Java module, but thats the only way I managed to work, I''ve refactor the code to just be one function with a Boolean flag and that didn't work for me. You can active it by using `NativeModules.UtilityModule.keepAwakeOn();` and disable it by using `NativeModules.UtilityModule.keepAwakeOff();`

akinwale commented

2018-06-22 01:13:01 +02:00

(Migrated from github.com)

Could you check out the latest master and then merge with your fork so that the Travis build passes on the next commit? Thanks.

dan1d commented

2018-06-23 00:41:57 +02:00

(Migrated from github.com)

Hi @akinwale branch fixed/rebased. There was a commit that didn't belong to this branch.

akinwale (Migrated from github.com) reviewed

2018-06-28 10:34:00 +02:00

akinwale (Migrated from github.com) left a comment

Looks good. One more thing, please update your branch with the latest master so that the Travis build passes.

Thanks.

Looks good. One more thing, please update your branch with the latest master so that the Travis build passes. Thanks.

dan1d commented

2018-07-12 04:17:03 +02:00

(Migrated from github.com)

Branch rebased @akinwale
Is there a problem if the build fails?, because I've added a new module and works locally, could be that the issue if it fails again ?

Branch rebased @akinwale Is there a problem if the build fails?, because I've added a new module and works locally, could be that the issue if it fails again ?

akinwale commented

2018-07-17 18:41:15 +02:00

(Migrated from github.com)

@dan1d Sorry for the late reply. Was off during the past week. There's a file missing in your fork which is causing the builds to fail. I assume you would have to do a fast-forward on your fork to match up with the latest master. See https://help.github.com/articles/syncing-a-fork/

I'll merge your changes into a fixed PR with a successful build.

akinwale commented

2018-07-18 14:23:27 +02:00

(Migrated from github.com)

Merged in https://github.com/lbryio/lbry-android/pull/204.