2018-11-07 23:44:38 +01:00
|
|
|
// @flow
|
2019-07-24 23:02:35 +02:00
|
|
|
import React, { useRef, useState } from 'react';
|
2018-11-07 23:44:38 +01:00
|
|
|
import classnames from 'classnames';
|
|
|
|
import Button from 'component/button';
|
2022-01-29 23:35:47 +01:00
|
|
|
import { useOnResize } from 'effects/use-on-resize';
|
2018-11-07 23:44:38 +01:00
|
|
|
|
2019-07-29 16:49:43 +02:00
|
|
|
const COLLAPSED_HEIGHT = 120;
|
2018-11-07 23:44:38 +01:00
|
|
|
|
|
|
|
type Props = {
|
2019-04-24 16:02:08 +02:00
|
|
|
children: React$Node | Array<React$Node>,
|
Re-design comment threads (#1489)
* Redesign threadline and fetching state
- threadline goes right below channel avatar, mimicking reddits implementation, has a increase effect on hover and is slimmer, creating more space for comments on screen
- fetching state now replaces show/hide button, also mimicking reddit, and now says that it is loading, instead of a blank spinner, and also improves space a bit
* Redesign comment threads
- Allow for infinite comment chains
- Can go back and forth between the pages
- Can go back to all comments or to the first comment in the chain
- Some other improvements, which include:
- add title on non-drawer comment sections (couldn't see amount of comments)
- fix Expandable component (would begin expanded and collapse after the effect runs, which looked bad and shifted the layout, now each comments greater than the set length begins collapsed)
- used constants for consistency
* Fix replying to last thread comment
* Fix buttons condition (only on fetched comment to avoid deleted case)
* Fix auto-scroll
* Bring back instant feedback for Show More replies
* Improve thread back links
- Now going back to all comments links the top-level comment for easier navigation
- Going back to ~ previous ~ now goes back into the chain instead of topmost level
* Clear timeouts due to unrelated issue
* Fix deep thread linked comment case and more scroll improvements
* More minor changes
* Flow
* Fix commentList tile style
* Fix long channel names overflowing on small screens
* More scroll changes
* Fix threadline
* Revert "Fix long channel names overflowing on small screens"
This reverts commit e4d2dc7da5861ed8136a60f3352e41a690cd4d33.
* Fix replies fetch
* Revert "Fix replies fetch"
This reverts commit ec70054675a604a7a5f3764ba07c36bf7b0f49c8.
* Cleanup and make smooth
* Always use linked comment on threads
* Cleanup
* Higlight thread comment
* Fix comment body styles
2022-05-16 12:22:13 +02:00
|
|
|
beginCollapsed?: boolean,
|
2018-11-07 23:44:38 +01:00
|
|
|
};
|
|
|
|
|
2019-07-24 23:02:35 +02:00
|
|
|
export default function Expandable(props: Props) {
|
Re-design comment threads (#1489)
* Redesign threadline and fetching state
- threadline goes right below channel avatar, mimicking reddits implementation, has a increase effect on hover and is slimmer, creating more space for comments on screen
- fetching state now replaces show/hide button, also mimicking reddit, and now says that it is loading, instead of a blank spinner, and also improves space a bit
* Redesign comment threads
- Allow for infinite comment chains
- Can go back and forth between the pages
- Can go back to all comments or to the first comment in the chain
- Some other improvements, which include:
- add title on non-drawer comment sections (couldn't see amount of comments)
- fix Expandable component (would begin expanded and collapse after the effect runs, which looked bad and shifted the layout, now each comments greater than the set length begins collapsed)
- used constants for consistency
* Fix replying to last thread comment
* Fix buttons condition (only on fetched comment to avoid deleted case)
* Fix auto-scroll
* Bring back instant feedback for Show More replies
* Improve thread back links
- Now going back to all comments links the top-level comment for easier navigation
- Going back to ~ previous ~ now goes back into the chain instead of topmost level
* Clear timeouts due to unrelated issue
* Fix deep thread linked comment case and more scroll improvements
* More minor changes
* Flow
* Fix commentList tile style
* Fix long channel names overflowing on small screens
* More scroll changes
* Fix threadline
* Revert "Fix long channel names overflowing on small screens"
This reverts commit e4d2dc7da5861ed8136a60f3352e41a690cd4d33.
* Fix replies fetch
* Revert "Fix replies fetch"
This reverts commit ec70054675a604a7a5f3764ba07c36bf7b0f49c8.
* Cleanup and make smooth
* Always use linked comment on threads
* Cleanup
* Higlight thread comment
* Fix comment body styles
2022-05-16 12:22:13 +02:00
|
|
|
const { children, beginCollapsed } = props;
|
|
|
|
|
2019-07-24 23:02:35 +02:00
|
|
|
const [expanded, setExpanded] = useState(false);
|
2022-01-29 23:35:47 +01:00
|
|
|
const [rect, setRect] = useState();
|
2019-07-24 23:02:35 +02:00
|
|
|
const ref = useRef();
|
2022-01-29 23:35:47 +01:00
|
|
|
|
|
|
|
// Update the rect initially & when the window size changes.
|
|
|
|
useOnResize(() => {
|
|
|
|
if (ref.current) {
|
|
|
|
setRect(ref.current.getBoundingClientRect());
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
// Update the rect when children changes,
|
|
|
|
// not sure if this is needed but a situation could arise when the
|
|
|
|
// component re-renders with a different children prop,
|
|
|
|
// Can enable on a later date if needed.
|
|
|
|
// useLayoutEffect(() => {
|
|
|
|
// console.log('render, useLayoutEffect');
|
|
|
|
// if (ref.current) {
|
|
|
|
// setRect(ref.current.getBoundingClientRect());
|
|
|
|
// }
|
|
|
|
// }, [children]);
|
2018-11-07 23:44:38 +01:00
|
|
|
|
2019-07-24 23:02:35 +02:00
|
|
|
function handleClick() {
|
|
|
|
setExpanded(!expanded);
|
2018-11-07 23:44:38 +01:00
|
|
|
}
|
|
|
|
|
2019-07-24 23:02:35 +02:00
|
|
|
return (
|
|
|
|
<div ref={ref}>
|
Re-design comment threads (#1489)
* Redesign threadline and fetching state
- threadline goes right below channel avatar, mimicking reddits implementation, has a increase effect on hover and is slimmer, creating more space for comments on screen
- fetching state now replaces show/hide button, also mimicking reddit, and now says that it is loading, instead of a blank spinner, and also improves space a bit
* Redesign comment threads
- Allow for infinite comment chains
- Can go back and forth between the pages
- Can go back to all comments or to the first comment in the chain
- Some other improvements, which include:
- add title on non-drawer comment sections (couldn't see amount of comments)
- fix Expandable component (would begin expanded and collapse after the effect runs, which looked bad and shifted the layout, now each comments greater than the set length begins collapsed)
- used constants for consistency
* Fix replying to last thread comment
* Fix buttons condition (only on fetched comment to avoid deleted case)
* Fix auto-scroll
* Bring back instant feedback for Show More replies
* Improve thread back links
- Now going back to all comments links the top-level comment for easier navigation
- Going back to ~ previous ~ now goes back into the chain instead of topmost level
* Clear timeouts due to unrelated issue
* Fix deep thread linked comment case and more scroll improvements
* More minor changes
* Flow
* Fix commentList tile style
* Fix long channel names overflowing on small screens
* More scroll changes
* Fix threadline
* Revert "Fix long channel names overflowing on small screens"
This reverts commit e4d2dc7da5861ed8136a60f3352e41a690cd4d33.
* Fix replies fetch
* Revert "Fix replies fetch"
This reverts commit ec70054675a604a7a5f3764ba07c36bf7b0f49c8.
* Cleanup and make smooth
* Always use linked comment on threads
* Cleanup
* Higlight thread comment
* Fix comment body styles
2022-05-16 12:22:13 +02:00
|
|
|
{(rect && rect.height > COLLAPSED_HEIGHT) || beginCollapsed ? (
|
2019-11-22 22:13:00 +01:00
|
|
|
<div ref={ref}>
|
2019-07-24 23:02:35 +02:00
|
|
|
<div
|
|
|
|
className={classnames({
|
|
|
|
'expandable--open': expanded,
|
|
|
|
'expandable--closed': !expanded,
|
|
|
|
})}
|
|
|
|
>
|
|
|
|
{children}
|
|
|
|
</div>
|
|
|
|
<Button
|
|
|
|
button="link"
|
|
|
|
className="expandable__button"
|
|
|
|
label={expanded ? __('Less') : __('More')}
|
|
|
|
onClick={handleClick}
|
|
|
|
/>
|
2018-11-07 23:44:38 +01:00
|
|
|
</div>
|
2019-07-24 23:02:35 +02:00
|
|
|
) : (
|
|
|
|
<div>{children}</div>
|
|
|
|
)}
|
|
|
|
</div>
|
|
|
|
);
|
2018-11-07 23:44:38 +01:00
|
|
|
}
|