2021-04-23 05:04:11 +02:00
|
|
|
// @flow
|
|
|
|
import * as ACTIONS from 'constants/action_types';
|
2021-10-17 10:36:14 +02:00
|
|
|
import { doClaimSearch } from 'redux/actions/claims';
|
2021-12-16 22:59:13 +01:00
|
|
|
import { LIVESTREAM_LIVE_API, LIVESTREAM_STARTS_SOON_BUFFER } from 'constants/livestream';
|
|
|
|
import moment from 'moment';
|
2021-04-23 05:04:11 +02:00
|
|
|
|
|
|
|
export const doFetchNoSourceClaims = (channelId: string) => async (dispatch: Dispatch, getState: GetState) => {
|
|
|
|
dispatch({
|
|
|
|
type: ACTIONS.FETCH_NO_SOURCE_CLAIMS_STARTED,
|
|
|
|
data: channelId,
|
|
|
|
});
|
2021-04-23 19:11:53 +02:00
|
|
|
try {
|
|
|
|
await dispatch(
|
|
|
|
doClaimSearch({
|
|
|
|
channel_ids: [channelId],
|
|
|
|
has_no_source: true,
|
|
|
|
claim_type: ['stream'],
|
|
|
|
no_totals: true,
|
|
|
|
page_size: 20,
|
|
|
|
page: 1,
|
|
|
|
include_is_my_output: true,
|
|
|
|
})
|
|
|
|
);
|
2021-04-23 05:04:11 +02:00
|
|
|
|
|
|
|
dispatch({
|
|
|
|
type: ACTIONS.FETCH_NO_SOURCE_CLAIMS_COMPLETED,
|
|
|
|
data: channelId,
|
|
|
|
});
|
2021-04-23 19:11:53 +02:00
|
|
|
} catch (error) {
|
2021-04-23 05:04:11 +02:00
|
|
|
dispatch({
|
|
|
|
type: ACTIONS.FETCH_NO_SOURCE_CLAIMS_FAILED,
|
|
|
|
data: channelId,
|
|
|
|
});
|
|
|
|
}
|
|
|
|
};
|
Livestream category improvements (#7115)
* ❌ Remove old method of displaying active livestreams
Completely remove it for now to make the commit deltas clearer.
We'll replace it with the new method at the end.
* Fetch and store active-livestream info in redux
* Tiles can now query active-livestream state from redux instead of getting from parent.
* ⏪ ClaimTilesDiscover: revert and cleanup
## Simplify
- Simplify to just `uris` instead of having multiple arrays (`uris`, `modifiedUris`, `prevUris`)
- The `prevUris` is for CLS prevention. With this removal, the CLS issue is back, but we'll handle it differently later.
- Temporarily disable the view-count fetching. Code is left there so that I don't forget.
## Fix
- `shouldPerformSearch` was never true when `prefixUris` is present. Corrected the logic.
- Aside: prefix and pin is so similar in function. Hm ....
* ClaimTilesDiscover: factor out options
## Change
Move the `option` code outside and passed in as a pre-calculated prop.
## Reason
To skip rendering while waiting for `claim_search`, we need to add `React.memo(areEqual)`. However, the flag that determines if we are fetching `claim_search` (fetchingClaimSearchByQuery[]) depends on the derived options as the key.
Instead of calculating `options` twice, we moved it to the props so both sides can use it.
It also makes the component a bit more readable.
The downside is that the prop-passing might not be clear.
* ClaimTilesDiscover: reduce ~17 renders at startup to just 2.
* ClaimTilesDiscover: fill with placeholder while waiting for claim_search
## Issue
Livestream claims are fetched seperately, so they might already exists. While claim_search is running, the list only consists of livestreams (collapsed).
## Fix
Fill up the space with placeholders to prevent layout shift.
* Add 'useFetchViewCount' to handle fetching from lists
This effect also stashes fetched uris, so that we won't re-fetch the same uris during the same instance (e.g. during infinite scroll).
* ⏪ ClaimListDiscover: revert and cleanup
## Revert
- Removed the 'finalUris' stuff that was meant to "pause" visual changes when fetching. I think it'll be cleaner to use React.memo to achieve that.
## Alterations
- Added `renderUri` to make it clear which array that this component will render.
- Re-do the way we fetch view counts now that 'finalUris' is gone. Not the best method, but at least correct for now.
* ClaimListDiscover: add prefixUris, similar to ClaimTilesDiscover
This will be initially used to append livestreams at the top.
* ✅ Re-enable active livestream tiles using the new method
* doFetchActiveLivestreams: add interval check
- Added a default minimum of 5 minutes between fetches. Clients can bypass this through `forceFetch` if needed.
* doFetchActiveLivestreams: add option check
We'll need to support different 'orderBy', so adding an "options check" when determining if we just made the same fetch.
* WildWest: limit livestream tiles + add ability to show more
Most likely this behavior will change in the future, so we'll leave `ClaimListDiscover` untouched and handle the logic at the page level.
This solution uses 2 `ClaimListDiscover` -- if the reduced livestream list is visible, it handles the header; else the normal list handles the header.
* Use better tile-count on larger screens.
Used the same method as how the homepage does it.
2021-09-24 16:26:21 +02:00
|
|
|
|
|
|
|
const FETCH_ACTIVE_LIVESTREAMS_MIN_INTERVAL_MS = 5 * 60 * 1000;
|
|
|
|
|
2021-12-16 22:59:13 +01:00
|
|
|
const transformLivestreamData = (data: Array<any>): LivestreamInfo => {
|
|
|
|
return data.reduce((acc, curr) => {
|
|
|
|
acc[curr.claimId] = {
|
|
|
|
live: curr.live,
|
|
|
|
viewCount: curr.viewCount,
|
|
|
|
creatorId: curr.claimId,
|
|
|
|
startedStreaming: moment(curr.timestamp),
|
|
|
|
};
|
|
|
|
return acc;
|
|
|
|
}, {});
|
|
|
|
};
|
|
|
|
|
|
|
|
const fetchLiveChannels = async () => {
|
|
|
|
const response = await fetch(LIVESTREAM_LIVE_API);
|
|
|
|
const json = await response.json();
|
|
|
|
if (!json.data) throw new Error();
|
|
|
|
return transformLivestreamData(json.data);
|
|
|
|
};
|
|
|
|
|
|
|
|
const fetchLiveChannel = async (channelId: string) => {
|
|
|
|
const response = await fetch(`${LIVESTREAM_LIVE_API}/${channelId}`);
|
|
|
|
const json = await response.json();
|
|
|
|
if (!(json.data && json.data.live)) throw new Error();
|
|
|
|
return transformLivestreamData([json.data]);
|
|
|
|
};
|
|
|
|
|
|
|
|
const filterUpcomingLiveStreamClaims = (upcomingClaims) => {
|
|
|
|
const startsSoonMoment = moment().startOf('minute').add(LIVESTREAM_STARTS_SOON_BUFFER, 'minutes');
|
|
|
|
const startingSoonClaims = {};
|
|
|
|
Object.keys(upcomingClaims).forEach((key) => {
|
|
|
|
if (moment.unix(upcomingClaims[key].stream.value.release_time).isSameOrBefore(startsSoonMoment)) {
|
|
|
|
startingSoonClaims[key] = upcomingClaims[key];
|
|
|
|
}
|
|
|
|
});
|
|
|
|
return startingSoonClaims;
|
|
|
|
};
|
|
|
|
|
|
|
|
const fetchUpcomingLivestreamClaims = (channelIds: Array<string>) => {
|
2021-12-20 19:25:16 +01:00
|
|
|
return doClaimSearch(
|
|
|
|
{
|
|
|
|
page: 1,
|
|
|
|
page_size: 50,
|
|
|
|
has_no_source: true,
|
|
|
|
channel_ids: channelIds,
|
|
|
|
claim_type: ['stream'],
|
|
|
|
order_by: ['^release_time'],
|
|
|
|
release_time: `>${moment().subtract(5, 'minutes').unix()}`,
|
|
|
|
limit_claims_per_channel: 1,
|
|
|
|
no_totals: true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
useAutoPagination: true,
|
|
|
|
}
|
|
|
|
);
|
2021-12-16 22:59:13 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
const fetchMostRecentLivestreamClaims = (channelIds: Array<string>, orderBy: Array<string> = ['release_time']) => {
|
2021-12-20 19:25:16 +01:00
|
|
|
return doClaimSearch(
|
|
|
|
{
|
|
|
|
page: 1,
|
|
|
|
page_size: 50,
|
|
|
|
has_no_source: true,
|
|
|
|
channel_ids: channelIds,
|
|
|
|
claim_type: ['stream'],
|
|
|
|
order_by: orderBy,
|
|
|
|
release_time: `<${moment().unix()}`,
|
|
|
|
limit_claims_per_channel: 2,
|
|
|
|
no_totals: true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
useAutoPagination: true,
|
|
|
|
}
|
|
|
|
);
|
2021-12-16 22:59:13 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
const distanceFromStreamStart = (claimA: any, claimB: any, channelStartedStreaming) => {
|
|
|
|
return [
|
|
|
|
Math.abs(moment.unix(claimA.stream.value.release_time).diff(channelStartedStreaming, 'minutes')),
|
|
|
|
Math.abs(moment.unix(claimB.stream.value.release_time).diff(channelStartedStreaming, 'minutes')),
|
|
|
|
];
|
|
|
|
};
|
|
|
|
|
|
|
|
const determineLiveClaim = (claims: any, activeLivestreams: any) => {
|
|
|
|
const activeClaims = {};
|
|
|
|
|
|
|
|
Object.values(claims).forEach((claim: any) => {
|
|
|
|
const channelID = claim.stream.signing_channel.claim_id;
|
|
|
|
if (activeClaims[channelID]) {
|
|
|
|
const [distanceA, distanceB] = distanceFromStreamStart(
|
|
|
|
claim,
|
|
|
|
activeClaims[channelID],
|
|
|
|
activeLivestreams[channelID].startedStreaming
|
|
|
|
);
|
|
|
|
|
|
|
|
if (distanceA < distanceB) {
|
|
|
|
activeClaims[channelID] = claim;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
activeClaims[channelID] = claim;
|
|
|
|
}
|
|
|
|
});
|
|
|
|
return activeClaims;
|
|
|
|
};
|
|
|
|
|
|
|
|
const findActiveStreams = async (channelIDs: Array<string>, orderBy: Array<string>, liveChannels: any, dispatch) => {
|
|
|
|
// @Note: This can likely be simplified down to one query, but first we'll need to address the query limit / pagination issue.
|
|
|
|
|
|
|
|
// Find the two most recent claims for the channels that are actively broadcasting a stream.
|
|
|
|
const mostRecentClaims = await dispatch(fetchMostRecentLivestreamClaims(channelIDs, orderBy));
|
|
|
|
|
|
|
|
// Find the first upcoming claim (if one exists) for each channel that's actively broadcasting a stream.
|
|
|
|
const upcomingClaims = await dispatch(fetchUpcomingLivestreamClaims(channelIDs));
|
|
|
|
|
|
|
|
// Filter out any of those claims that aren't scheduled to start within the configured "soon" buffer time (ex. next 5 min).
|
|
|
|
const startingSoonClaims = filterUpcomingLiveStreamClaims(upcomingClaims);
|
|
|
|
|
|
|
|
// Reduce the claim list to one "live" claim per channel, based on how close each claim's
|
|
|
|
// release time is to the time the channels stream started.
|
|
|
|
const allClaims = Object.assign({}, mostRecentClaims, startingSoonClaims);
|
|
|
|
|
|
|
|
return determineLiveClaim(allClaims, liveChannels);
|
|
|
|
};
|
|
|
|
|
|
|
|
export const doFetchActiveLivestream = (channelId: string) => {
|
|
|
|
return async (dispatch: Dispatch) => {
|
|
|
|
try {
|
|
|
|
const liveChannel = await fetchLiveChannel(channelId);
|
|
|
|
const currentlyLiveClaims = await findActiveStreams([channelId], ['release_time'], liveChannel, dispatch);
|
|
|
|
const liveClaim = currentlyLiveClaims[channelId];
|
2021-12-22 17:12:44 +01:00
|
|
|
|
|
|
|
liveChannel[channelId].claimId = liveClaim.stream.claim_id;
|
|
|
|
liveChannel[channelId].claimUri = liveClaim.stream.canonical_url;
|
|
|
|
|
2021-12-16 22:59:13 +01:00
|
|
|
dispatch({
|
|
|
|
type: ACTIONS.FETCH_ACTIVE_LIVESTREAM_COMPLETED,
|
2021-12-22 17:12:44 +01:00
|
|
|
data: {
|
|
|
|
...liveChannel,
|
|
|
|
},
|
2021-12-16 22:59:13 +01:00
|
|
|
});
|
|
|
|
} catch (err) {
|
2021-12-22 17:12:44 +01:00
|
|
|
dispatch({ type: ACTIONS.FETCH_ACTIVE_LIVESTREAM_FAILED, data: { channelId } });
|
2021-12-16 22:59:13 +01:00
|
|
|
}
|
|
|
|
};
|
|
|
|
};
|
|
|
|
|
|
|
|
export const doFetchActiveLivestreams = (orderBy: Array<string> = ['release_time']) => {
|
Livestream category improvements (#7115)
* ❌ Remove old method of displaying active livestreams
Completely remove it for now to make the commit deltas clearer.
We'll replace it with the new method at the end.
* Fetch and store active-livestream info in redux
* Tiles can now query active-livestream state from redux instead of getting from parent.
* ⏪ ClaimTilesDiscover: revert and cleanup
## Simplify
- Simplify to just `uris` instead of having multiple arrays (`uris`, `modifiedUris`, `prevUris`)
- The `prevUris` is for CLS prevention. With this removal, the CLS issue is back, but we'll handle it differently later.
- Temporarily disable the view-count fetching. Code is left there so that I don't forget.
## Fix
- `shouldPerformSearch` was never true when `prefixUris` is present. Corrected the logic.
- Aside: prefix and pin is so similar in function. Hm ....
* ClaimTilesDiscover: factor out options
## Change
Move the `option` code outside and passed in as a pre-calculated prop.
## Reason
To skip rendering while waiting for `claim_search`, we need to add `React.memo(areEqual)`. However, the flag that determines if we are fetching `claim_search` (fetchingClaimSearchByQuery[]) depends on the derived options as the key.
Instead of calculating `options` twice, we moved it to the props so both sides can use it.
It also makes the component a bit more readable.
The downside is that the prop-passing might not be clear.
* ClaimTilesDiscover: reduce ~17 renders at startup to just 2.
* ClaimTilesDiscover: fill with placeholder while waiting for claim_search
## Issue
Livestream claims are fetched seperately, so they might already exists. While claim_search is running, the list only consists of livestreams (collapsed).
## Fix
Fill up the space with placeholders to prevent layout shift.
* Add 'useFetchViewCount' to handle fetching from lists
This effect also stashes fetched uris, so that we won't re-fetch the same uris during the same instance (e.g. during infinite scroll).
* ⏪ ClaimListDiscover: revert and cleanup
## Revert
- Removed the 'finalUris' stuff that was meant to "pause" visual changes when fetching. I think it'll be cleaner to use React.memo to achieve that.
## Alterations
- Added `renderUri` to make it clear which array that this component will render.
- Re-do the way we fetch view counts now that 'finalUris' is gone. Not the best method, but at least correct for now.
* ClaimListDiscover: add prefixUris, similar to ClaimTilesDiscover
This will be initially used to append livestreams at the top.
* ✅ Re-enable active livestream tiles using the new method
* doFetchActiveLivestreams: add interval check
- Added a default minimum of 5 minutes between fetches. Clients can bypass this through `forceFetch` if needed.
* doFetchActiveLivestreams: add option check
We'll need to support different 'orderBy', so adding an "options check" when determining if we just made the same fetch.
* WildWest: limit livestream tiles + add ability to show more
Most likely this behavior will change in the future, so we'll leave `ClaimListDiscover` untouched and handle the logic at the page level.
This solution uses 2 `ClaimListDiscover` -- if the reduced livestream list is visible, it handles the header; else the normal list handles the header.
* Use better tile-count on larger screens.
Used the same method as how the homepage does it.
2021-09-24 16:26:21 +02:00
|
|
|
return async (dispatch: Dispatch, getState: GetState) => {
|
|
|
|
const state = getState();
|
|
|
|
const now = Date.now();
|
|
|
|
const timeDelta = now - state.livestream.activeLivestreamsLastFetchedDate;
|
|
|
|
|
|
|
|
const prevOptions = state.livestream.activeLivestreamsLastFetchedOptions;
|
2021-12-16 22:59:13 +01:00
|
|
|
const nextOptions = { order_by: orderBy };
|
Livestream category improvements (#7115)
* ❌ Remove old method of displaying active livestreams
Completely remove it for now to make the commit deltas clearer.
We'll replace it with the new method at the end.
* Fetch and store active-livestream info in redux
* Tiles can now query active-livestream state from redux instead of getting from parent.
* ⏪ ClaimTilesDiscover: revert and cleanup
## Simplify
- Simplify to just `uris` instead of having multiple arrays (`uris`, `modifiedUris`, `prevUris`)
- The `prevUris` is for CLS prevention. With this removal, the CLS issue is back, but we'll handle it differently later.
- Temporarily disable the view-count fetching. Code is left there so that I don't forget.
## Fix
- `shouldPerformSearch` was never true when `prefixUris` is present. Corrected the logic.
- Aside: prefix and pin is so similar in function. Hm ....
* ClaimTilesDiscover: factor out options
## Change
Move the `option` code outside and passed in as a pre-calculated prop.
## Reason
To skip rendering while waiting for `claim_search`, we need to add `React.memo(areEqual)`. However, the flag that determines if we are fetching `claim_search` (fetchingClaimSearchByQuery[]) depends on the derived options as the key.
Instead of calculating `options` twice, we moved it to the props so both sides can use it.
It also makes the component a bit more readable.
The downside is that the prop-passing might not be clear.
* ClaimTilesDiscover: reduce ~17 renders at startup to just 2.
* ClaimTilesDiscover: fill with placeholder while waiting for claim_search
## Issue
Livestream claims are fetched seperately, so they might already exists. While claim_search is running, the list only consists of livestreams (collapsed).
## Fix
Fill up the space with placeholders to prevent layout shift.
* Add 'useFetchViewCount' to handle fetching from lists
This effect also stashes fetched uris, so that we won't re-fetch the same uris during the same instance (e.g. during infinite scroll).
* ⏪ ClaimListDiscover: revert and cleanup
## Revert
- Removed the 'finalUris' stuff that was meant to "pause" visual changes when fetching. I think it'll be cleaner to use React.memo to achieve that.
## Alterations
- Added `renderUri` to make it clear which array that this component will render.
- Re-do the way we fetch view counts now that 'finalUris' is gone. Not the best method, but at least correct for now.
* ClaimListDiscover: add prefixUris, similar to ClaimTilesDiscover
This will be initially used to append livestreams at the top.
* ✅ Re-enable active livestream tiles using the new method
* doFetchActiveLivestreams: add interval check
- Added a default minimum of 5 minutes between fetches. Clients can bypass this through `forceFetch` if needed.
* doFetchActiveLivestreams: add option check
We'll need to support different 'orderBy', so adding an "options check" when determining if we just made the same fetch.
* WildWest: limit livestream tiles + add ability to show more
Most likely this behavior will change in the future, so we'll leave `ClaimListDiscover` untouched and handle the logic at the page level.
This solution uses 2 `ClaimListDiscover` -- if the reduced livestream list is visible, it handles the header; else the normal list handles the header.
* Use better tile-count on larger screens.
Used the same method as how the homepage does it.
2021-09-24 16:26:21 +02:00
|
|
|
const sameOptions = JSON.stringify(prevOptions) === JSON.stringify(nextOptions);
|
|
|
|
|
2021-12-16 22:59:13 +01:00
|
|
|
if (sameOptions && timeDelta < FETCH_ACTIVE_LIVESTREAMS_MIN_INTERVAL_MS) {
|
Livestream category improvements (#7115)
* ❌ Remove old method of displaying active livestreams
Completely remove it for now to make the commit deltas clearer.
We'll replace it with the new method at the end.
* Fetch and store active-livestream info in redux
* Tiles can now query active-livestream state from redux instead of getting from parent.
* ⏪ ClaimTilesDiscover: revert and cleanup
## Simplify
- Simplify to just `uris` instead of having multiple arrays (`uris`, `modifiedUris`, `prevUris`)
- The `prevUris` is for CLS prevention. With this removal, the CLS issue is back, but we'll handle it differently later.
- Temporarily disable the view-count fetching. Code is left there so that I don't forget.
## Fix
- `shouldPerformSearch` was never true when `prefixUris` is present. Corrected the logic.
- Aside: prefix and pin is so similar in function. Hm ....
* ClaimTilesDiscover: factor out options
## Change
Move the `option` code outside and passed in as a pre-calculated prop.
## Reason
To skip rendering while waiting for `claim_search`, we need to add `React.memo(areEqual)`. However, the flag that determines if we are fetching `claim_search` (fetchingClaimSearchByQuery[]) depends on the derived options as the key.
Instead of calculating `options` twice, we moved it to the props so both sides can use it.
It also makes the component a bit more readable.
The downside is that the prop-passing might not be clear.
* ClaimTilesDiscover: reduce ~17 renders at startup to just 2.
* ClaimTilesDiscover: fill with placeholder while waiting for claim_search
## Issue
Livestream claims are fetched seperately, so they might already exists. While claim_search is running, the list only consists of livestreams (collapsed).
## Fix
Fill up the space with placeholders to prevent layout shift.
* Add 'useFetchViewCount' to handle fetching from lists
This effect also stashes fetched uris, so that we won't re-fetch the same uris during the same instance (e.g. during infinite scroll).
* ⏪ ClaimListDiscover: revert and cleanup
## Revert
- Removed the 'finalUris' stuff that was meant to "pause" visual changes when fetching. I think it'll be cleaner to use React.memo to achieve that.
## Alterations
- Added `renderUri` to make it clear which array that this component will render.
- Re-do the way we fetch view counts now that 'finalUris' is gone. Not the best method, but at least correct for now.
* ClaimListDiscover: add prefixUris, similar to ClaimTilesDiscover
This will be initially used to append livestreams at the top.
* ✅ Re-enable active livestream tiles using the new method
* doFetchActiveLivestreams: add interval check
- Added a default minimum of 5 minutes between fetches. Clients can bypass this through `forceFetch` if needed.
* doFetchActiveLivestreams: add option check
We'll need to support different 'orderBy', so adding an "options check" when determining if we just made the same fetch.
* WildWest: limit livestream tiles + add ability to show more
Most likely this behavior will change in the future, so we'll leave `ClaimListDiscover` untouched and handle the logic at the page level.
This solution uses 2 `ClaimListDiscover` -- if the reduced livestream list is visible, it handles the header; else the normal list handles the header.
* Use better tile-count on larger screens.
Used the same method as how the homepage does it.
2021-09-24 16:26:21 +02:00
|
|
|
dispatch({ type: ACTIONS.FETCH_ACTIVE_LIVESTREAMS_SKIPPED });
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
dispatch({ type: ACTIONS.FETCH_ACTIVE_LIVESTREAMS_STARTED });
|
|
|
|
|
2021-12-16 22:59:13 +01:00
|
|
|
try {
|
|
|
|
const liveChannels = await fetchLiveChannels();
|
|
|
|
const liveChannelIds = Object.keys(liveChannels);
|
|
|
|
|
|
|
|
const currentlyLiveClaims = await findActiveStreams(liveChannelIds, nextOptions.order_by, liveChannels, dispatch);
|
|
|
|
Object.values(currentlyLiveClaims).forEach((claim: any) => {
|
|
|
|
const channelId = claim.stream.signing_channel.claim_id;
|
|
|
|
|
|
|
|
liveChannels[channelId] = {
|
|
|
|
...liveChannels[channelId],
|
|
|
|
claimId: claim.stream.claim_id,
|
|
|
|
claimUri: claim.stream.canonical_url,
|
|
|
|
};
|
Livestream category improvements (#7115)
* ❌ Remove old method of displaying active livestreams
Completely remove it for now to make the commit deltas clearer.
We'll replace it with the new method at the end.
* Fetch and store active-livestream info in redux
* Tiles can now query active-livestream state from redux instead of getting from parent.
* ⏪ ClaimTilesDiscover: revert and cleanup
## Simplify
- Simplify to just `uris` instead of having multiple arrays (`uris`, `modifiedUris`, `prevUris`)
- The `prevUris` is for CLS prevention. With this removal, the CLS issue is back, but we'll handle it differently later.
- Temporarily disable the view-count fetching. Code is left there so that I don't forget.
## Fix
- `shouldPerformSearch` was never true when `prefixUris` is present. Corrected the logic.
- Aside: prefix and pin is so similar in function. Hm ....
* ClaimTilesDiscover: factor out options
## Change
Move the `option` code outside and passed in as a pre-calculated prop.
## Reason
To skip rendering while waiting for `claim_search`, we need to add `React.memo(areEqual)`. However, the flag that determines if we are fetching `claim_search` (fetchingClaimSearchByQuery[]) depends on the derived options as the key.
Instead of calculating `options` twice, we moved it to the props so both sides can use it.
It also makes the component a bit more readable.
The downside is that the prop-passing might not be clear.
* ClaimTilesDiscover: reduce ~17 renders at startup to just 2.
* ClaimTilesDiscover: fill with placeholder while waiting for claim_search
## Issue
Livestream claims are fetched seperately, so they might already exists. While claim_search is running, the list only consists of livestreams (collapsed).
## Fix
Fill up the space with placeholders to prevent layout shift.
* Add 'useFetchViewCount' to handle fetching from lists
This effect also stashes fetched uris, so that we won't re-fetch the same uris during the same instance (e.g. during infinite scroll).
* ⏪ ClaimListDiscover: revert and cleanup
## Revert
- Removed the 'finalUris' stuff that was meant to "pause" visual changes when fetching. I think it'll be cleaner to use React.memo to achieve that.
## Alterations
- Added `renderUri` to make it clear which array that this component will render.
- Re-do the way we fetch view counts now that 'finalUris' is gone. Not the best method, but at least correct for now.
* ClaimListDiscover: add prefixUris, similar to ClaimTilesDiscover
This will be initially used to append livestreams at the top.
* ✅ Re-enable active livestream tiles using the new method
* doFetchActiveLivestreams: add interval check
- Added a default minimum of 5 minutes between fetches. Clients can bypass this through `forceFetch` if needed.
* doFetchActiveLivestreams: add option check
We'll need to support different 'orderBy', so adding an "options check" when determining if we just made the same fetch.
* WildWest: limit livestream tiles + add ability to show more
Most likely this behavior will change in the future, so we'll leave `ClaimListDiscover` untouched and handle the logic at the page level.
This solution uses 2 `ClaimListDiscover` -- if the reduced livestream list is visible, it handles the header; else the normal list handles the header.
* Use better tile-count on larger screens.
Used the same method as how the homepage does it.
2021-09-24 16:26:21 +02:00
|
|
|
});
|
2021-12-16 22:59:13 +01:00
|
|
|
|
|
|
|
dispatch({
|
|
|
|
type: ACTIONS.FETCH_ACTIVE_LIVESTREAMS_COMPLETED,
|
|
|
|
data: {
|
|
|
|
activeLivestreams: liveChannels,
|
|
|
|
activeLivestreamsLastFetchedDate: now,
|
|
|
|
activeLivestreamsLastFetchedOptions: nextOptions,
|
|
|
|
},
|
|
|
|
});
|
|
|
|
} catch (err) {
|
|
|
|
dispatch({ type: ACTIONS.FETCH_ACTIVE_LIVESTREAMS_FAILED });
|
|
|
|
}
|
Livestream category improvements (#7115)
* ❌ Remove old method of displaying active livestreams
Completely remove it for now to make the commit deltas clearer.
We'll replace it with the new method at the end.
* Fetch and store active-livestream info in redux
* Tiles can now query active-livestream state from redux instead of getting from parent.
* ⏪ ClaimTilesDiscover: revert and cleanup
## Simplify
- Simplify to just `uris` instead of having multiple arrays (`uris`, `modifiedUris`, `prevUris`)
- The `prevUris` is for CLS prevention. With this removal, the CLS issue is back, but we'll handle it differently later.
- Temporarily disable the view-count fetching. Code is left there so that I don't forget.
## Fix
- `shouldPerformSearch` was never true when `prefixUris` is present. Corrected the logic.
- Aside: prefix and pin is so similar in function. Hm ....
* ClaimTilesDiscover: factor out options
## Change
Move the `option` code outside and passed in as a pre-calculated prop.
## Reason
To skip rendering while waiting for `claim_search`, we need to add `React.memo(areEqual)`. However, the flag that determines if we are fetching `claim_search` (fetchingClaimSearchByQuery[]) depends on the derived options as the key.
Instead of calculating `options` twice, we moved it to the props so both sides can use it.
It also makes the component a bit more readable.
The downside is that the prop-passing might not be clear.
* ClaimTilesDiscover: reduce ~17 renders at startup to just 2.
* ClaimTilesDiscover: fill with placeholder while waiting for claim_search
## Issue
Livestream claims are fetched seperately, so they might already exists. While claim_search is running, the list only consists of livestreams (collapsed).
## Fix
Fill up the space with placeholders to prevent layout shift.
* Add 'useFetchViewCount' to handle fetching from lists
This effect also stashes fetched uris, so that we won't re-fetch the same uris during the same instance (e.g. during infinite scroll).
* ⏪ ClaimListDiscover: revert and cleanup
## Revert
- Removed the 'finalUris' stuff that was meant to "pause" visual changes when fetching. I think it'll be cleaner to use React.memo to achieve that.
## Alterations
- Added `renderUri` to make it clear which array that this component will render.
- Re-do the way we fetch view counts now that 'finalUris' is gone. Not the best method, but at least correct for now.
* ClaimListDiscover: add prefixUris, similar to ClaimTilesDiscover
This will be initially used to append livestreams at the top.
* ✅ Re-enable active livestream tiles using the new method
* doFetchActiveLivestreams: add interval check
- Added a default minimum of 5 minutes between fetches. Clients can bypass this through `forceFetch` if needed.
* doFetchActiveLivestreams: add option check
We'll need to support different 'orderBy', so adding an "options check" when determining if we just made the same fetch.
* WildWest: limit livestream tiles + add ability to show more
Most likely this behavior will change in the future, so we'll leave `ClaimListDiscover` untouched and handle the logic at the page level.
This solution uses 2 `ClaimListDiscover` -- if the reduced livestream list is visible, it handles the header; else the normal list handles the header.
* Use better tile-count on larger screens.
Used the same method as how the homepage does it.
2021-09-24 16:26:21 +02:00
|
|
|
};
|
|
|
|
};
|