LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity
lbry-desktop/.github/PULL_REQUEST_TEMPLATE.md

48 lines
1.4 KiB
Markdown
Raw Normal View History

Add keyword hint | Collapse "PR Checklist" and "PR Type" ## Changes 1. Add hint on adding "Closes", "Fixes", etc. keywords to directly update the Issue state when the PR gets merged 2. Collapse "PR Checklist" and "PR Type". - With the assumption that these 2 items are mainly reminders for contributors, and that reviewers will typically only look at it one time, we collapse these sections to reduce clutter in the PR description.
2021-08-08 09:43:30 +08:00
## Fixes
update github templates
2019-01-19 12:43:49 -05:00
Add keyword hint | Collapse "PR Checklist" and "PR Type" ## Changes 1. Add hint on adding "Closes", "Fixes", etc. keywords to directly update the Issue state when the PR gets merged 2. Collapse "PR Checklist" and "PR Type". - With the assumption that these 2 items are mainly reminders for contributors, and that reviewers will typically only look at it one time, we collapse these sections to reduce clutter in the PR description.
2021-08-08 09:43:30 +08:00
Issue Number:
update github templates
2019-01-19 12:43:49 -05:00
Add keyword hint | Collapse "PR Checklist" and "PR Type" ## Changes 1. Add hint on adding "Closes", "Fixes", etc. keywords to directly update the Issue state when the PR gets merged 2. Collapse "PR Checklist" and "PR Type". - With the assumption that these 2 items are mainly reminders for contributors, and that reviewers will typically only look at it one time, we collapse these sections to reduce clutter in the PR description.
2021-08-08 09:43:30 +08:00
<!-- Tip:
- Add keywords to directly close the Issue when the PR is merged.
- Skip the keyword if the Issue contains multiple items.
- https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->
Add GitHub pull request template (#2069)
2018-10-30 05:37:26 +02:00
Add keyword hint | Collapse "PR Checklist" and "PR Type" ## Changes 1. Add hint on adding "Closes", "Fixes", etc. keywords to directly update the Issue state when the PR gets merged 2. Collapse "PR Checklist" and "PR Type". - With the assumption that these 2 items are mainly reminders for contributors, and that reviewers will typically only look at it one time, we collapse these sections to reduce clutter in the PR description.
2021-08-08 09:43:30 +08:00
## What is the current behavior?
## What is the new behavior?
## Other information
<!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
Add GitHub pull request template (#2069)
2018-10-30 05:37:26 +02:00
Add keyword hint | Collapse "PR Checklist" and "PR Type" ## Changes 1. Add hint on adding "Closes", "Fixes", etc. keywords to directly update the Issue state when the PR gets merged 2. Collapse "PR Checklist" and "PR Type". - With the assumption that these 2 items are mainly reminders for contributors, and that reviewers will typically only look at it one time, we collapse these sections to reduce clutter in the PR description.
2021-08-08 09:43:30 +08:00
## PR Type & Checklist
<details><summary>PR Type...</summary>
Update PULL_REQUEST_TEMPLATE.md
2018-10-30 16:42:54 -04:00
update github templates
2019-01-19 12:43:49 -05:00
What kind of change does this PR introduce?
Update PULL_REQUEST_TEMPLATE.md
2018-10-30 16:42:54 -04:00
- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting)
- [ ] Refactoring (no functional changes)
- [ ] Documentation changes
- [ ] Other - Please describe:
Add keyword hint | Collapse "PR Checklist" and "PR Type" ## Changes 1. Add hint on adding "Closes", "Fixes", etc. keywords to directly update the Issue state when the PR gets merged 2. Collapse "PR Checklist" and "PR Type". - With the assumption that these 2 items are mainly reminders for contributors, and that reviewers will typically only look at it one time, we collapse these sections to reduce clutter in the PR description.
2021-08-08 09:43:30 +08:00
</details>
Update PULL_REQUEST_TEMPLATE.md
2018-10-30 16:42:54 -04:00
Add keyword hint | Collapse "PR Checklist" and "PR Type" ## Changes 1. Add hint on adding "Closes", "Fixes", etc. keywords to directly update the Issue state when the PR gets merged 2. Collapse "PR Checklist" and "PR Type". - With the assumption that these 2 items are mainly reminders for contributors, and that reviewers will typically only look at it one time, we collapse these sections to reduce clutter in the PR description.
2021-08-08 09:43:30 +08:00
<!---------------------------------------------------------------------------->
Update PULL_REQUEST_TEMPLATE.md
2018-10-30 16:42:54 -04:00
Add keyword hint | Collapse "PR Checklist" and "PR Type" ## Changes 1. Add hint on adding "Closes", "Fixes", etc. keywords to directly update the Issue state when the PR gets merged 2. Collapse "PR Checklist" and "PR Type". - With the assumption that these 2 items are mainly reminders for contributors, and that reviewers will typically only look at it one time, we collapse these sections to reduce clutter in the PR description.
2021-08-08 09:43:30 +08:00
<details><summary>PR Checklist...</summary>
Update PULL_REQUEST_TEMPLATE.md
2018-10-30 16:42:54 -04:00
Add keyword hint | Collapse "PR Checklist" and "PR Type" ## Changes 1. Add hint on adding "Closes", "Fixes", etc. keywords to directly update the Issue state when the PR gets merged 2. Collapse "PR Checklist" and "PR Type". - With the assumption that these 2 items are mainly reminders for contributors, and that reviewers will typically only look at it one time, we collapse these sections to reduce clutter in the PR description.
2021-08-08 09:43:30 +08:00
<!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" -->
Update PULL_REQUEST_TEMPLATE.md
2018-10-30 16:42:54 -04:00
Add keyword hint | Collapse "PR Checklist" and "PR Type" ## Changes 1. Add hint on adding "Closes", "Fixes", etc. keywords to directly update the Issue state when the PR gets merged 2. Collapse "PR Checklist" and "PR Type". - With the assumption that these 2 items are mainly reminders for contributors, and that reviewers will typically only look at it one time, we collapse these sections to reduce clutter in the PR description.
2021-08-08 09:43:30 +08:00
Please check all that apply to this PR using "x":
Update PULL_REQUEST_TEMPLATE.md
2018-10-30 16:42:54 -04:00
Add keyword hint | Collapse "PR Checklist" and "PR Type" ## Changes 1. Add hint on adding "Closes", "Fixes", etc. keywords to directly update the Issue state when the PR gets merged 2. Collapse "PR Checklist" and "PR Type". - With the assumption that these 2 items are mainly reminders for contributors, and that reviewers will typically only look at it one time, we collapse these sections to reduce clutter in the PR description.
2021-08-08 09:43:30 +08:00
- [ ] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
- [ ] I added a line describing my change to CHANGELOG.md
- [ ] I have checked that this PR does not introduce a breaking change
- [ ] This PR introduces breaking changes and I have provided a detailed explanation below
</details>
Reference in a new issue Copy permalink