LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity
lbry-desktop/ui/constants/pageTitles.js

62 lines
2.1 KiB
JavaScript
Raw Normal View History

Add page titles (affects browser Tab, History, etc.) ## Issue - While changing the "Back" behavior in the Settings Page PR, it was a pain to troubleshoot when the entire history list is listed as "odysee.com". - If you have multiple tabs open, it's hard to know which is which for non-claim and non-channel pages. ## Approach Initially, I thought of overriding the document's title through the `<Page>` component, since the titles are usually defined there. However, given that the router is already doing the overriding, I think it's best to do the same thing all in one place. Downside: it might get missed when a new page is added. ## Unknown - Not sure if are rules for titles. There seems to be a mix of sites -- some have specific titles per page, most just use the site title for each page. - I think the `return` statement in the `useEffect` is unnecessary, since it'll just be setting to the same value now during the cleanup stage. (??)
2021-08-25 16:26:53 +02:00
// Customer-facing title for a page.
//
// Primarily used for the browser tab and history title.
Fix page titles for SiteLinks Part of `7166 improve search metadata`, where page titles are important clues for Google to generate Site-Links.
2021-09-30 08:36:27 +02:00
// Ensure new strings are added to 'app-string.json' for localization.
Add page titles (affects browser Tab, History, etc.) ## Issue - While changing the "Back" behavior in the Settings Page PR, it was a pain to troubleshoot when the entire history list is listed as "odysee.com". - If you have multiple tabs open, it's hard to know which is which for non-claim and non-channel pages. ## Approach Initially, I thought of overriding the document's title through the `<Page>` component, since the titles are usually defined there. However, given that the router is already doing the overriding, I think it's best to do the same thing all in one place. Downside: it might get missed when a new page is added. ## Unknown - Not sure if are rules for titles. There seems to be a mix of sites -- some have specific titles per page, most just use the site title for each page. - I think the `return` statement in the `useEffect` is unnecessary, since it'll just be setting to the same value now during the cleanup stage. (??)
2021-08-25 16:26:53 +02:00
import * as PAGES from 'constants/pages';
export const PAGE_TITLE = {
// --- Categories ---
[PAGES.BIG_HITS]: 'Big Hits',
[PAGES.DISCOVER]: 'Wild West',
// [PAGES.ENLIGHTENMENT] = 'Enlightenment',
Fix page titles for SiteLinks Part of `7166 improve search metadata`, where page titles are important clues for Google to generate Site-Links.
2021-09-30 08:36:27 +02:00
[PAGES.FINANCE]: 'Finance 2.0',
Add page titles (affects browser Tab, History, etc.) ## Issue - While changing the "Back" behavior in the Settings Page PR, it was a pain to troubleshoot when the entire history list is listed as "odysee.com". - If you have multiple tabs open, it's hard to know which is which for non-claim and non-channel pages. ## Approach Initially, I thought of overriding the document's title through the `<Page>` component, since the titles are usually defined there. However, given that the router is already doing the overriding, I think it's best to do the same thing all in one place. Downside: it might get missed when a new page is added. ## Unknown - Not sure if are rules for titles. There seems to be a mix of sites -- some have specific titles per page, most just use the site title for each page. - I think the `return` statement in the `useEffect` is unnecessary, since it'll just be setting to the same value now during the cleanup stage. (??)
2021-08-25 16:26:53 +02:00
[PAGES.GAMING]: 'Gaming',
[PAGES.GENERAL]: 'Cheese',
[PAGES.LAB]: 'Lab',
[PAGES.MOVIES]: 'Movies',
[PAGES.MUSIC]: 'Music',
[PAGES.NEWS]: 'News & Politics',
Fix page titles for SiteLinks Part of `7166 improve search metadata`, where page titles are important clues for Google to generate Site-Links.
2021-09-30 08:36:27 +02:00
// [PAGES.RABBIT_HOLE]: 'The Rabbit Hole';
[PAGES.TECH]: 'Tech',
[PAGES.UNIVERSE]: 'The Universe',
Add page titles (affects browser Tab, History, etc.) ## Issue - While changing the "Back" behavior in the Settings Page PR, it was a pain to troubleshoot when the entire history list is listed as "odysee.com". - If you have multiple tabs open, it's hard to know which is which for non-claim and non-channel pages. ## Approach Initially, I thought of overriding the document's title through the `<Page>` component, since the titles are usually defined there. However, given that the router is already doing the overriding, I think it's best to do the same thing all in one place. Downside: it might get missed when a new page is added. ## Unknown - Not sure if are rules for titles. There seems to be a mix of sites -- some have specific titles per page, most just use the site title for each page. - I think the `return` statement in the `useEffect` is unnecessary, since it'll just be setting to the same value now during the cleanup stage. (??)
2021-08-25 16:26:53 +02:00
[PAGES.WILD_WEST]: 'Wild West',
// --- Everything else in alphabetical order ---
[PAGES.BUY]: 'Buy or Swap',
[PAGES.CHANNELS]: 'Your channels',
[PAGES.CHANNELS_FOLLOWING]: 'Following',
[PAGES.CHANNELS_FOLLOWING_DISCOVER]: 'Discover Channels',
[PAGES.CHANNEL_NEW]: 'Create a channel',
[PAGES.CHECKOUT]: 'Checkout',
[PAGES.CODE_2257]: '2257',
[PAGES.CREATOR_DASHBOARD]: 'Creator Analytics',
[PAGES.HELP]: 'Help',
[PAGES.INVITE]: 'Invite',
[PAGES.LISTS]: 'Lists',
[PAGES.NOTIFICATIONS]: 'Notifications',
[PAGES.RECEIVE]: 'Your address',
[PAGES.REPORT]: 'Report an issue or request a feature',
[PAGES.REPORT_CONTENT]: 'Report content',
[PAGES.REPOST_NEW]: 'Repost',
[PAGES.REWARDS]: 'Rewards',
[PAGES.REWARDS_VERIFY]: 'Verify to earn Credits',
[PAGES.SEARCH]: 'Search',
[PAGES.SEND]: 'Send Credits',
[PAGES.SETTINGS]: 'Settings',
[PAGES.SETTINGS_BLOCKED_MUTED]: 'Block and muted channels',
[PAGES.SETTINGS_CREATOR]: 'Creator settings',
[PAGES.SETTINGS_NOTIFICATIONS]: 'Manage notifications',
Fix page titles for SiteLinks Part of `7166 improve search metadata`, where page titles are important clues for Google to generate Site-Links.
2021-09-30 08:36:27 +02:00
[PAGES.SETTINGS_STRIPE_ACCOUNT]: 'Bank Accounts',
[PAGES.SETTINGS_STRIPE_CARD]: 'Payment Methods',
Add page titles (affects browser Tab, History, etc.) ## Issue - While changing the "Back" behavior in the Settings Page PR, it was a pain to troubleshoot when the entire history list is listed as "odysee.com". - If you have multiple tabs open, it's hard to know which is which for non-claim and non-channel pages. ## Approach Initially, I thought of overriding the document's title through the `<Page>` component, since the titles are usually defined there. However, given that the router is already doing the overriding, I think it's best to do the same thing all in one place. Downside: it might get missed when a new page is added. ## Unknown - Not sure if are rules for titles. There seems to be a mix of sites -- some have specific titles per page, most just use the site title for each page. - I think the `return` statement in the `useEffect` is unnecessary, since it'll just be setting to the same value now during the cleanup stage. (??)
2021-08-25 16:26:53 +02:00
[PAGES.SETTINGS_UPDATE_PWD]: 'Update password',
List own comments (#7171) * Add option to pass in url-search params. Impetus: allow linked comment ID and setting the discussion tab when clicking on the `ClaimPreview`. * comment.list: fix typos and renamed variables - Switch from 'author' to 'creator' to disambiguate between comment author and content author. For comment author, we'll use 'commenter' from now on. - Corrected 'commenterClaimId' to 'creatorClaimId' (just a typo, no functional change). * doCommentReset: change param from uri to claimId This reduces one lookup as clients will always have the claimID ready, but might not have the full URI. It was using URI previously just to match the other APIs. * Add doCommentListOwn -- command to fetch own comments Since the redux slice is set up based on content or channel ID (for Channel Discussion page), re-use the channel ID for the case of "own comments". We always clear each ID when fetching page-0, so no worries of conflict when actually browsing the Channel Discussion page. * Comment: add option to hide the actions section * Implement own-comments page * Use new param to remove sort-pins-first. comment.List currently always pushes pins to the top to support pagination. This new param removes this behavior.
2021-10-01 14:10:27 +02:00
[PAGES.SETTINGS_OWN_COMMENTS]: 'Your comments',
Add page titles (affects browser Tab, History, etc.) ## Issue - While changing the "Back" behavior in the Settings Page PR, it was a pain to troubleshoot when the entire history list is listed as "odysee.com". - If you have multiple tabs open, it's hard to know which is which for non-claim and non-channel pages. ## Approach Initially, I thought of overriding the document's title through the `<Page>` component, since the titles are usually defined there. However, given that the router is already doing the overriding, I think it's best to do the same thing all in one place. Downside: it might get missed when a new page is added. ## Unknown - Not sure if are rules for titles. There seems to be a mix of sites -- some have specific titles per page, most just use the site title for each page. - I think the `return` statement in the `useEffect` is unnecessary, since it'll just be setting to the same value now during the cleanup stage. (??)
2021-08-25 16:26:53 +02:00
[PAGES.TAGS_FOLLOWING]: 'Tags',
[PAGES.TAGS_FOLLOWING_MANAGE]: 'Manage tags',
[PAGES.UPLOAD]: 'Upload',
[PAGES.UPLOADS]: 'Your uploads',
[PAGES.WALLET]: 'Wallet',
[PAGES.WELCOME]: 'Welcome',
Fix page titles for SiteLinks Part of `7166 improve search metadata`, where page titles are important clues for Google to generate Site-Links.
2021-09-30 08:36:27 +02:00
[PAGES.YOUTUBE_SYNC]: 'YouTube Sync',
Add page titles (affects browser Tab, History, etc.) ## Issue - While changing the "Back" behavior in the Settings Page PR, it was a pain to troubleshoot when the entire history list is listed as "odysee.com". - If you have multiple tabs open, it's hard to know which is which for non-claim and non-channel pages. ## Approach Initially, I thought of overriding the document's title through the `<Page>` component, since the titles are usually defined there. However, given that the router is already doing the overriding, I think it's best to do the same thing all in one place. Downside: it might get missed when a new page is added. ## Unknown - Not sure if are rules for titles. There seems to be a mix of sites -- some have specific titles per page, most just use the site title for each page. - I think the `return` statement in the `useEffect` is unnecessary, since it'll just be setting to the same value now during the cleanup stage. (??)
2021-08-25 16:26:53 +02:00
};
Reference in a new issue Copy permalink