2019-05-07 04:35:04 +02:00
|
|
|
// @flow
|
2020-06-30 07:51:15 +02:00
|
|
|
import React from 'react';
|
2019-05-11 21:06:22 +02:00
|
|
|
import { parseURI } from 'lbry-redux';
|
|
|
|
import classnames from 'classnames';
|
|
|
|
import Gerbil from './gerbil.png';
|
2020-05-28 19:07:04 +02:00
|
|
|
import FreezeframeWrapper from 'component/fileThumbnail/FreezeframeWrapper';
|
2021-02-16 22:09:20 +01:00
|
|
|
import ChannelStakedIndicator from 'component/channelStakedIndicator';
|
2021-05-17 21:51:21 +02:00
|
|
|
import { getThumbnailCdnUrl } from 'util/thumbnail';
|
ChannelThumbnail improvements
- [x] (6332) The IntersectionObserver method of lazy-loading loads cached images visibly late on slower devices. Previously, it was also showing the "broken image" icon briefly, which we mended by placing a dummy transparent image as the initial src.
- Reverted that ugly transparent image fix.
- Use the browser's built-in `loading="lazy"` instead. Sorry, Safari.
- [x] Size-optimization did not take "device pixel ratio" into account.
- When resizing an image through the CDN, we can't just take the dimensions of the tag in pixels directly -- we need to take zooming into account, otherwise the image ends up blurry.
- Previously, we quickly disabled optimization for the channel avatar in the Channel Page because of this. Now that we know the root-cause, the change was reverted and we now go through the CDN with appropriate sizes. This also improves our Web Vital scores.
- [x] Size-optimization wasn't really implemented for all ChannelThumbnail instances.
- The CDN-optimized size was hardcoded to the largest instance, so small images like sidebar thumbnails are still loading images that are unnecessarily larger.
- There's a little-bit of hardcoding of values from CSS here, but I think it's a ok compromise (not something we change often). It also doesn't need to be exact -- the "device pixel ratio" calculate will ensure it's slightly larger than what we need.
- [x] Set `width` and `height` of `<img>` to improve CLS.
- Addresses Ligthhouse complaints, although technically the shifting was addressed at the `ClaimPreviewTile` level (sub-container dimensions are well defined).
- Notes: the values don't need to be the final CSS-adjusted sizes. It just needs to be in the right aspect ratio to help the browser pre-allocate space to avoid shifts.
- [x] Add option to disable lazy-load Channel Thumbnails
- The guidelines mentioned that items that are already in the viewport should not enable `loading="lazy"`.
- We have a few areas where it doesn't make sense to lazy-load (e.g. thumbnail in Header, channel selector dropdown, publish preview, etc.).
2021-07-05 07:20:40 +02:00
|
|
|
|
|
|
|
const FONT_PX = 16.0;
|
|
|
|
const IMG_XSMALL_REM = 2.1;
|
|
|
|
const IMG_SMALL_REM = 3.0;
|
|
|
|
const IMG_NORMAL_REM = 10.0;
|
2019-05-07 04:35:04 +02:00
|
|
|
|
|
|
|
type Props = {
|
|
|
|
thumbnail: ?string,
|
2019-10-23 09:03:45 +02:00
|
|
|
uri: ?string,
|
2019-06-11 20:10:58 +02:00
|
|
|
className?: string,
|
2019-06-28 19:00:29 +02:00
|
|
|
thumbnailPreview: ?string,
|
2019-08-02 02:56:25 +02:00
|
|
|
obscure?: boolean,
|
2019-12-04 19:07:40 +01:00
|
|
|
small?: boolean,
|
ChannelThumbnail improvements
- [x] (6332) The IntersectionObserver method of lazy-loading loads cached images visibly late on slower devices. Previously, it was also showing the "broken image" icon briefly, which we mended by placing a dummy transparent image as the initial src.
- Reverted that ugly transparent image fix.
- Use the browser's built-in `loading="lazy"` instead. Sorry, Safari.
- [x] Size-optimization did not take "device pixel ratio" into account.
- When resizing an image through the CDN, we can't just take the dimensions of the tag in pixels directly -- we need to take zooming into account, otherwise the image ends up blurry.
- Previously, we quickly disabled optimization for the channel avatar in the Channel Page because of this. Now that we know the root-cause, the change was reverted and we now go through the CDN with appropriate sizes. This also improves our Web Vital scores.
- [x] Size-optimization wasn't really implemented for all ChannelThumbnail instances.
- The CDN-optimized size was hardcoded to the largest instance, so small images like sidebar thumbnails are still loading images that are unnecessarily larger.
- There's a little-bit of hardcoding of values from CSS here, but I think it's a ok compromise (not something we change often). It also doesn't need to be exact -- the "device pixel ratio" calculate will ensure it's slightly larger than what we need.
- [x] Set `width` and `height` of `<img>` to improve CLS.
- Addresses Ligthhouse complaints, although technically the shifting was addressed at the `ClaimPreviewTile` level (sub-container dimensions are well defined).
- Notes: the values don't need to be the final CSS-adjusted sizes. It just needs to be in the right aspect ratio to help the browser pre-allocate space to avoid shifts.
- [x] Add option to disable lazy-load Channel Thumbnails
- The guidelines mentioned that items that are already in the viewport should not enable `loading="lazy"`.
- We have a few areas where it doesn't make sense to lazy-load (e.g. thumbnail in Header, channel selector dropdown, publish preview, etc.).
2021-07-05 07:20:40 +02:00
|
|
|
xsmall?: boolean,
|
2020-05-28 19:07:04 +02:00
|
|
|
allowGifs?: boolean,
|
2020-07-23 16:22:57 +02:00
|
|
|
claim: ?ChannelClaim,
|
2021-02-16 22:09:20 +01:00
|
|
|
doResolveUri: (string) => void,
|
2020-08-24 20:44:41 +02:00
|
|
|
isResolving: boolean,
|
2020-11-19 18:17:47 +01:00
|
|
|
showDelayedMessage?: boolean,
|
ChannelThumbnail improvements
- [x] (6332) The IntersectionObserver method of lazy-loading loads cached images visibly late on slower devices. Previously, it was also showing the "broken image" icon briefly, which we mended by placing a dummy transparent image as the initial src.
- Reverted that ugly transparent image fix.
- Use the browser's built-in `loading="lazy"` instead. Sorry, Safari.
- [x] Size-optimization did not take "device pixel ratio" into account.
- When resizing an image through the CDN, we can't just take the dimensions of the tag in pixels directly -- we need to take zooming into account, otherwise the image ends up blurry.
- Previously, we quickly disabled optimization for the channel avatar in the Channel Page because of this. Now that we know the root-cause, the change was reverted and we now go through the CDN with appropriate sizes. This also improves our Web Vital scores.
- [x] Size-optimization wasn't really implemented for all ChannelThumbnail instances.
- The CDN-optimized size was hardcoded to the largest instance, so small images like sidebar thumbnails are still loading images that are unnecessarily larger.
- There's a little-bit of hardcoding of values from CSS here, but I think it's a ok compromise (not something we change often). It also doesn't need to be exact -- the "device pixel ratio" calculate will ensure it's slightly larger than what we need.
- [x] Set `width` and `height` of `<img>` to improve CLS.
- Addresses Ligthhouse complaints, although technically the shifting was addressed at the `ClaimPreviewTile` level (sub-container dimensions are well defined).
- Notes: the values don't need to be the final CSS-adjusted sizes. It just needs to be in the right aspect ratio to help the browser pre-allocate space to avoid shifts.
- [x] Add option to disable lazy-load Channel Thumbnails
- The guidelines mentioned that items that are already in the viewport should not enable `loading="lazy"`.
- We have a few areas where it doesn't make sense to lazy-load (e.g. thumbnail in Header, channel selector dropdown, publish preview, etc.).
2021-07-05 07:20:40 +02:00
|
|
|
noLazyLoad?: boolean,
|
2021-02-16 22:09:20 +01:00
|
|
|
hideStakedIndicator?: boolean,
|
2019-05-07 04:35:04 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
function ChannelThumbnail(props: Props) {
|
2020-06-08 15:16:56 +02:00
|
|
|
const {
|
|
|
|
thumbnail: rawThumbnail,
|
|
|
|
uri,
|
|
|
|
className,
|
|
|
|
thumbnailPreview: rawThumbnailPreview,
|
|
|
|
obscure,
|
|
|
|
small = false,
|
2021-04-23 21:59:48 +02:00
|
|
|
xsmall = false,
|
2020-06-08 15:16:56 +02:00
|
|
|
allowGifs = false,
|
2020-07-23 16:22:57 +02:00
|
|
|
claim,
|
|
|
|
doResolveUri,
|
2020-08-24 20:44:41 +02:00
|
|
|
isResolving,
|
2020-11-19 18:17:47 +01:00
|
|
|
showDelayedMessage = false,
|
ChannelThumbnail improvements
- [x] (6332) The IntersectionObserver method of lazy-loading loads cached images visibly late on slower devices. Previously, it was also showing the "broken image" icon briefly, which we mended by placing a dummy transparent image as the initial src.
- Reverted that ugly transparent image fix.
- Use the browser's built-in `loading="lazy"` instead. Sorry, Safari.
- [x] Size-optimization did not take "device pixel ratio" into account.
- When resizing an image through the CDN, we can't just take the dimensions of the tag in pixels directly -- we need to take zooming into account, otherwise the image ends up blurry.
- Previously, we quickly disabled optimization for the channel avatar in the Channel Page because of this. Now that we know the root-cause, the change was reverted and we now go through the CDN with appropriate sizes. This also improves our Web Vital scores.
- [x] Size-optimization wasn't really implemented for all ChannelThumbnail instances.
- The CDN-optimized size was hardcoded to the largest instance, so small images like sidebar thumbnails are still loading images that are unnecessarily larger.
- There's a little-bit of hardcoding of values from CSS here, but I think it's a ok compromise (not something we change often). It also doesn't need to be exact -- the "device pixel ratio" calculate will ensure it's slightly larger than what we need.
- [x] Set `width` and `height` of `<img>` to improve CLS.
- Addresses Ligthhouse complaints, although technically the shifting was addressed at the `ClaimPreviewTile` level (sub-container dimensions are well defined).
- Notes: the values don't need to be the final CSS-adjusted sizes. It just needs to be in the right aspect ratio to help the browser pre-allocate space to avoid shifts.
- [x] Add option to disable lazy-load Channel Thumbnails
- The guidelines mentioned that items that are already in the viewport should not enable `loading="lazy"`.
- We have a few areas where it doesn't make sense to lazy-load (e.g. thumbnail in Header, channel selector dropdown, publish preview, etc.).
2021-07-05 07:20:40 +02:00
|
|
|
noLazyLoad,
|
2021-02-16 22:09:20 +01:00
|
|
|
hideStakedIndicator = false,
|
2020-06-08 15:16:56 +02:00
|
|
|
} = props;
|
2020-06-30 07:51:15 +02:00
|
|
|
const [thumbError, setThumbError] = React.useState(false);
|
2020-07-23 16:22:57 +02:00
|
|
|
const shouldResolve = claim === undefined;
|
2020-06-08 15:16:56 +02:00
|
|
|
const thumbnail = rawThumbnail && rawThumbnail.trim().replace(/^http:\/\//i, 'https://');
|
|
|
|
const thumbnailPreview = rawThumbnailPreview && rawThumbnailPreview.trim().replace(/^http:\/\//i, 'https://');
|
2020-05-28 19:07:04 +02:00
|
|
|
const channelThumbnail = thumbnail || thumbnailPreview;
|
2021-05-17 21:51:21 +02:00
|
|
|
const isGif = channelThumbnail && channelThumbnail.endsWith('gif');
|
2019-12-07 16:56:00 +01:00
|
|
|
const showThumb = (!obscure && !!thumbnail) || thumbnailPreview;
|
2021-05-17 21:51:21 +02:00
|
|
|
const thumbnailRef = React.useRef(null);
|
ChannelThumbnail improvements
- [x] (6332) The IntersectionObserver method of lazy-loading loads cached images visibly late on slower devices. Previously, it was also showing the "broken image" icon briefly, which we mended by placing a dummy transparent image as the initial src.
- Reverted that ugly transparent image fix.
- Use the browser's built-in `loading="lazy"` instead. Sorry, Safari.
- [x] Size-optimization did not take "device pixel ratio" into account.
- When resizing an image through the CDN, we can't just take the dimensions of the tag in pixels directly -- we need to take zooming into account, otherwise the image ends up blurry.
- Previously, we quickly disabled optimization for the channel avatar in the Channel Page because of this. Now that we know the root-cause, the change was reverted and we now go through the CDN with appropriate sizes. This also improves our Web Vital scores.
- [x] Size-optimization wasn't really implemented for all ChannelThumbnail instances.
- The CDN-optimized size was hardcoded to the largest instance, so small images like sidebar thumbnails are still loading images that are unnecessarily larger.
- There's a little-bit of hardcoding of values from CSS here, but I think it's a ok compromise (not something we change often). It also doesn't need to be exact -- the "device pixel ratio" calculate will ensure it's slightly larger than what we need.
- [x] Set `width` and `height` of `<img>` to improve CLS.
- Addresses Ligthhouse complaints, although technically the shifting was addressed at the `ClaimPreviewTile` level (sub-container dimensions are well defined).
- Notes: the values don't need to be the final CSS-adjusted sizes. It just needs to be in the right aspect ratio to help the browser pre-allocate space to avoid shifts.
- [x] Add option to disable lazy-load Channel Thumbnails
- The guidelines mentioned that items that are already in the viewport should not enable `loading="lazy"`.
- We have a few areas where it doesn't make sense to lazy-load (e.g. thumbnail in Header, channel selector dropdown, publish preview, etc.).
2021-07-05 07:20:40 +02:00
|
|
|
const thumbnailSize = calcRenderedImgWidth(); // currently always 1:1
|
|
|
|
|
2019-05-14 04:53:04 +02:00
|
|
|
// Generate a random color class based on the first letter of the channel name
|
2019-12-04 19:07:40 +01:00
|
|
|
const { channelName } = parseURI(uri);
|
2019-10-23 09:03:45 +02:00
|
|
|
let initializer;
|
2019-12-04 19:07:40 +01:00
|
|
|
let colorClassName;
|
|
|
|
if (channelName) {
|
2019-10-23 09:03:45 +02:00
|
|
|
initializer = channelName.charCodeAt(0) - 65; // will be between 0 and 57
|
2019-12-04 19:07:40 +01:00
|
|
|
colorClassName = `channel-thumbnail__default--${Math.abs(initializer % 4)}`;
|
2019-10-23 09:03:45 +02:00
|
|
|
} else {
|
2019-12-04 19:07:40 +01:00
|
|
|
colorClassName = `channel-thumbnail__default--4`;
|
2019-10-23 09:03:45 +02:00
|
|
|
}
|
2020-06-30 07:51:15 +02:00
|
|
|
|
ChannelThumbnail improvements
- [x] (6332) The IntersectionObserver method of lazy-loading loads cached images visibly late on slower devices. Previously, it was also showing the "broken image" icon briefly, which we mended by placing a dummy transparent image as the initial src.
- Reverted that ugly transparent image fix.
- Use the browser's built-in `loading="lazy"` instead. Sorry, Safari.
- [x] Size-optimization did not take "device pixel ratio" into account.
- When resizing an image through the CDN, we can't just take the dimensions of the tag in pixels directly -- we need to take zooming into account, otherwise the image ends up blurry.
- Previously, we quickly disabled optimization for the channel avatar in the Channel Page because of this. Now that we know the root-cause, the change was reverted and we now go through the CDN with appropriate sizes. This also improves our Web Vital scores.
- [x] Size-optimization wasn't really implemented for all ChannelThumbnail instances.
- The CDN-optimized size was hardcoded to the largest instance, so small images like sidebar thumbnails are still loading images that are unnecessarily larger.
- There's a little-bit of hardcoding of values from CSS here, but I think it's a ok compromise (not something we change often). It also doesn't need to be exact -- the "device pixel ratio" calculate will ensure it's slightly larger than what we need.
- [x] Set `width` and `height` of `<img>` to improve CLS.
- Addresses Ligthhouse complaints, although technically the shifting was addressed at the `ClaimPreviewTile` level (sub-container dimensions are well defined).
- Notes: the values don't need to be the final CSS-adjusted sizes. It just needs to be in the right aspect ratio to help the browser pre-allocate space to avoid shifts.
- [x] Add option to disable lazy-load Channel Thumbnails
- The guidelines mentioned that items that are already in the viewport should not enable `loading="lazy"`.
- We have a few areas where it doesn't make sense to lazy-load (e.g. thumbnail in Header, channel selector dropdown, publish preview, etc.).
2021-07-05 07:20:40 +02:00
|
|
|
function calcRenderedImgWidth() {
|
|
|
|
let rem;
|
|
|
|
if (xsmall) {
|
|
|
|
rem = IMG_XSMALL_REM;
|
|
|
|
} else if (small) {
|
|
|
|
rem = IMG_SMALL_REM;
|
|
|
|
} else {
|
|
|
|
rem = IMG_NORMAL_REM;
|
|
|
|
}
|
|
|
|
|
|
|
|
const devicePixelRatio = window.devicePixelRatio || 1.0;
|
|
|
|
return Math.ceil(rem * devicePixelRatio * FONT_PX);
|
|
|
|
}
|
|
|
|
|
2020-07-23 16:22:57 +02:00
|
|
|
React.useEffect(() => {
|
|
|
|
if (shouldResolve && uri) {
|
|
|
|
doResolveUri(uri);
|
|
|
|
}
|
|
|
|
}, [doResolveUri, shouldResolve, uri]);
|
|
|
|
|
2021-05-17 21:51:21 +02:00
|
|
|
if (isGif && !allowGifs) {
|
2021-02-16 22:09:20 +01:00
|
|
|
return (
|
|
|
|
<FreezeframeWrapper src={channelThumbnail} className={classnames('channel-thumbnail', className)}>
|
|
|
|
{!hideStakedIndicator && <ChannelStakedIndicator uri={uri} claim={claim} />}
|
|
|
|
</FreezeframeWrapper>
|
|
|
|
);
|
2020-06-30 07:51:15 +02:00
|
|
|
}
|
|
|
|
|
2021-05-17 21:51:21 +02:00
|
|
|
let url = channelThumbnail;
|
|
|
|
// @if TARGET='web'
|
|
|
|
// Pass image urls through a compression proxy, except for GIFs.
|
ChannelThumbnail improvements
- [x] (6332) The IntersectionObserver method of lazy-loading loads cached images visibly late on slower devices. Previously, it was also showing the "broken image" icon briefly, which we mended by placing a dummy transparent image as the initial src.
- Reverted that ugly transparent image fix.
- Use the browser's built-in `loading="lazy"` instead. Sorry, Safari.
- [x] Size-optimization did not take "device pixel ratio" into account.
- When resizing an image through the CDN, we can't just take the dimensions of the tag in pixels directly -- we need to take zooming into account, otherwise the image ends up blurry.
- Previously, we quickly disabled optimization for the channel avatar in the Channel Page because of this. Now that we know the root-cause, the change was reverted and we now go through the CDN with appropriate sizes. This also improves our Web Vital scores.
- [x] Size-optimization wasn't really implemented for all ChannelThumbnail instances.
- The CDN-optimized size was hardcoded to the largest instance, so small images like sidebar thumbnails are still loading images that are unnecessarily larger.
- There's a little-bit of hardcoding of values from CSS here, but I think it's a ok compromise (not something we change often). It also doesn't need to be exact -- the "device pixel ratio" calculate will ensure it's slightly larger than what we need.
- [x] Set `width` and `height` of `<img>` to improve CLS.
- Addresses Ligthhouse complaints, although technically the shifting was addressed at the `ClaimPreviewTile` level (sub-container dimensions are well defined).
- Notes: the values don't need to be the final CSS-adjusted sizes. It just needs to be in the right aspect ratio to help the browser pre-allocate space to avoid shifts.
- [x] Add option to disable lazy-load Channel Thumbnails
- The guidelines mentioned that items that are already in the viewport should not enable `loading="lazy"`.
- We have a few areas where it doesn't make sense to lazy-load (e.g. thumbnail in Header, channel selector dropdown, publish preview, etc.).
2021-07-05 07:20:40 +02:00
|
|
|
if (thumbnail && !(isGif && allowGifs)) {
|
|
|
|
url = getThumbnailCdnUrl({ thumbnail, width: thumbnailSize, height: thumbnailSize, quality: 85 });
|
2021-05-17 21:51:21 +02:00
|
|
|
}
|
|
|
|
// @endif
|
|
|
|
|
2019-05-07 04:35:04 +02:00
|
|
|
return (
|
2019-05-11 21:06:22 +02:00
|
|
|
<div
|
2019-06-11 20:10:58 +02:00
|
|
|
className={classnames('channel-thumbnail', className, {
|
2019-08-02 17:11:31 +02:00
|
|
|
[colorClassName]: !showThumb,
|
2019-12-04 19:07:40 +01:00
|
|
|
'channel-thumbnail--small': small,
|
2021-04-23 21:59:48 +02:00
|
|
|
'channel-thumbnail--xsmall': xsmall,
|
2020-08-24 20:44:41 +02:00
|
|
|
'channel-thumbnail--resolving': isResolving,
|
2019-05-11 21:06:22 +02:00
|
|
|
})}
|
|
|
|
>
|
2020-01-30 21:55:45 +01:00
|
|
|
{!showThumb && (
|
|
|
|
<img
|
2021-05-17 21:51:21 +02:00
|
|
|
ref={thumbnailRef}
|
2020-01-30 21:55:45 +01:00
|
|
|
alt={__('Channel profile picture')}
|
|
|
|
className="channel-thumbnail__default"
|
ChannelThumbnail improvements
- [x] (6332) The IntersectionObserver method of lazy-loading loads cached images visibly late on slower devices. Previously, it was also showing the "broken image" icon briefly, which we mended by placing a dummy transparent image as the initial src.
- Reverted that ugly transparent image fix.
- Use the browser's built-in `loading="lazy"` instead. Sorry, Safari.
- [x] Size-optimization did not take "device pixel ratio" into account.
- When resizing an image through the CDN, we can't just take the dimensions of the tag in pixels directly -- we need to take zooming into account, otherwise the image ends up blurry.
- Previously, we quickly disabled optimization for the channel avatar in the Channel Page because of this. Now that we know the root-cause, the change was reverted and we now go through the CDN with appropriate sizes. This also improves our Web Vital scores.
- [x] Size-optimization wasn't really implemented for all ChannelThumbnail instances.
- The CDN-optimized size was hardcoded to the largest instance, so small images like sidebar thumbnails are still loading images that are unnecessarily larger.
- There's a little-bit of hardcoding of values from CSS here, but I think it's a ok compromise (not something we change often). It also doesn't need to be exact -- the "device pixel ratio" calculate will ensure it's slightly larger than what we need.
- [x] Set `width` and `height` of `<img>` to improve CLS.
- Addresses Ligthhouse complaints, although technically the shifting was addressed at the `ClaimPreviewTile` level (sub-container dimensions are well defined).
- Notes: the values don't need to be the final CSS-adjusted sizes. It just needs to be in the right aspect ratio to help the browser pre-allocate space to avoid shifts.
- [x] Add option to disable lazy-load Channel Thumbnails
- The guidelines mentioned that items that are already in the viewport should not enable `loading="lazy"`.
- We have a few areas where it doesn't make sense to lazy-load (e.g. thumbnail in Header, channel selector dropdown, publish preview, etc.).
2021-07-05 07:20:40 +02:00
|
|
|
src={!thumbError && url ? url : Gerbil}
|
|
|
|
width={thumbnailSize}
|
|
|
|
height={thumbnailSize}
|
|
|
|
loading={noLazyLoad ? undefined : 'lazy'}
|
2021-01-28 19:03:32 +01:00
|
|
|
onError={() => setThumbError(true)} // if thumb fails (including due to https replace, show gerbil.
|
2020-01-30 21:55:45 +01:00
|
|
|
/>
|
|
|
|
)}
|
|
|
|
{showThumb && (
|
2020-11-19 18:17:47 +01:00
|
|
|
<>
|
|
|
|
{showDelayedMessage && thumbError ? (
|
|
|
|
<div className="chanel-thumbnail--waiting">{__('This will be visible in a few minutes.')}</div>
|
|
|
|
) : (
|
|
|
|
<img
|
2021-05-17 21:51:21 +02:00
|
|
|
ref={thumbnailRef}
|
2020-11-19 18:17:47 +01:00
|
|
|
alt={__('Channel profile picture')}
|
|
|
|
className="channel-thumbnail__custom"
|
ChannelThumbnail improvements
- [x] (6332) The IntersectionObserver method of lazy-loading loads cached images visibly late on slower devices. Previously, it was also showing the "broken image" icon briefly, which we mended by placing a dummy transparent image as the initial src.
- Reverted that ugly transparent image fix.
- Use the browser's built-in `loading="lazy"` instead. Sorry, Safari.
- [x] Size-optimization did not take "device pixel ratio" into account.
- When resizing an image through the CDN, we can't just take the dimensions of the tag in pixels directly -- we need to take zooming into account, otherwise the image ends up blurry.
- Previously, we quickly disabled optimization for the channel avatar in the Channel Page because of this. Now that we know the root-cause, the change was reverted and we now go through the CDN with appropriate sizes. This also improves our Web Vital scores.
- [x] Size-optimization wasn't really implemented for all ChannelThumbnail instances.
- The CDN-optimized size was hardcoded to the largest instance, so small images like sidebar thumbnails are still loading images that are unnecessarily larger.
- There's a little-bit of hardcoding of values from CSS here, but I think it's a ok compromise (not something we change often). It also doesn't need to be exact -- the "device pixel ratio" calculate will ensure it's slightly larger than what we need.
- [x] Set `width` and `height` of `<img>` to improve CLS.
- Addresses Ligthhouse complaints, although technically the shifting was addressed at the `ClaimPreviewTile` level (sub-container dimensions are well defined).
- Notes: the values don't need to be the final CSS-adjusted sizes. It just needs to be in the right aspect ratio to help the browser pre-allocate space to avoid shifts.
- [x] Add option to disable lazy-load Channel Thumbnails
- The guidelines mentioned that items that are already in the viewport should not enable `loading="lazy"`.
- We have a few areas where it doesn't make sense to lazy-load (e.g. thumbnail in Header, channel selector dropdown, publish preview, etc.).
2021-07-05 07:20:40 +02:00
|
|
|
src={!thumbError && url ? url : Gerbil}
|
|
|
|
width={thumbnailSize}
|
|
|
|
height={thumbnailSize}
|
|
|
|
loading={noLazyLoad ? undefined : 'lazy'}
|
2020-11-19 18:17:47 +01:00
|
|
|
onError={() => setThumbError(true)} // if thumb fails (including due to https replace, show gerbil.
|
|
|
|
/>
|
|
|
|
)}
|
|
|
|
</>
|
2020-01-30 21:55:45 +01:00
|
|
|
)}
|
2021-02-16 22:09:20 +01:00
|
|
|
{!hideStakedIndicator && <ChannelStakedIndicator uri={uri} claim={claim} />}
|
2019-05-07 04:35:04 +02:00
|
|
|
</div>
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
export default ChannelThumbnail;
|