LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Remove hack in Timestamp parser now that 'remark-breaks' has addressed the original problem.

Browse source 
## Issue
Closes 5523: timestamps not interpreted in some cases

## Notes
`remark-breaks` previously kept repeating the same index in the loop, causing some corner-cases to be parsed oddly. I added code to address that.

Later, `remark-breaks` fixed the problem and we recently just bumped up the componnent version. My hack is no longer necesary.
This commit is contained in:
infiinte-persistence 2021-02-16 16:41:48 +08:00 committed by Sean Yesmunt
parent 8e9f6eb905
commit 02792b8f0c
1 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
ui/util/remark-timestamp.js
View file

@ -30,13 +30,6 @@ function findNextTimestamp(value, fromIndex, strictlyFromIndex) {
}
}
if (fromIndex > 0 && fromIndex >= match.index && fromIndex < match.index + match[0].length) {
// Skip previously-rejected word, preventing "62:01" from being tokenized as "2:01", for example.
// This assumes that a non-zero 'fromIndex' means that a previous lookup has failed.
begin = match.index + match[0].length;
continue;
}
// Exclude trailing colons to allow "0:12: Start of section", for example.
const str = match[0].replace(/:+$/, '');
@ -84,7 +77,7 @@ function locateTimestamp(value, fromIndex) {
}
// Generate 'timestamp' markdown node
const createTimestampNode = text => ({
const createTimestampNode = (text) => ({
type: TIMESTAMP_NODE_TYPE,
value: text,
children: [{ type: 'text', value: text }],
@ -145,7 +138,7 @@ const transformer = (node, index, parent) => {
}
};
const transform = tree => {
const transform = (tree) => {
visit(tree, [TIMESTAMP_NODE_TYPE], transformer);
};