Merge pull request #1660 from lbryio/links

External-internal links (UX/UI)
This commit is contained in:
Sean Yesmunt 2018-06-23 00:38:19 -04:00 committed by GitHub
commit 0bbabc5461
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 6 deletions

View file

@ -1,6 +1,7 @@
// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { MODALS, isURIValid } from 'lbry-redux'; import { MODALS, isURIValid } from 'lbry-redux';
import * as icons from 'constants/icons';
import Button from 'component/button'; import Button from 'component/button';
type Props = { type Props = {
@ -32,12 +33,12 @@ class ExternalLink extends React.PureComponent<Props> {
element = ( element = (
<Button <Button
button="link" button="link"
iconRight={icons.EXTERNAL_LINK}
title={title || href} title={title || href}
label={children}
className="btn--external-link" className="btn--external-link"
onClick={() => openModal({ id: MODALS.CONFIRM_EXTERNAL_LINK }, { uri: href })} onClick={() => openModal({ id: MODALS.CONFIRM_EXTERNAL_LINK }, { uri: href })}
> />
{children}
</Button>
); );
} }
@ -47,10 +48,9 @@ class ExternalLink extends React.PureComponent<Props> {
<Button <Button
button="link" button="link"
title={title || href} title={title || href}
label={children}
onClick={() => navigate('/show', { uri: href })} onClick={() => navigate('/show', { uri: href })}
> />
{children}
</Button>
); );
} }

View file

@ -26,3 +26,4 @@ export const HEART = 'Heart';
export const UNLOCK = 'Unlock'; export const UNLOCK = 'Unlock';
export const CHECK_SIMPLE = 'Check'; export const CHECK_SIMPLE = 'Check';
export const GLOBE = 'Globe'; export const GLOBE = 'Globe';
export const EXTERNAL_LINK = 'ExternalLink';