adds twitter player meta

This commit is contained in:
jessop 2020-01-28 13:00:45 -05:00 committed by Sean Yesmunt
parent 980583687f
commit 13ead2f1e7
2 changed files with 26 additions and 8 deletions

View file

@ -1,7 +1,9 @@
{ {
"linters": { "linters": {
"ui/**/*.{js,jsx,scss,json}": ["prettier --write", "git add"], "ui/**/*.{js,jsx,scss,json}": ["prettier --write", "git add"],
"lbrytv/component/*.{js,jsx,scss,json}": ["prettier --write", "git add"], "lbrytv/**/*.{js,jsx,scss,json}": ["prettier --write", "git add"],
"ui/**/*.{js,jsx}": ["eslint", "flow focus-check --color always", "git add"] "ui/**/*.{js,jsx}": ["eslint", "flow focus-check --color always", "git add"],
} "lbrytv/**/*.{js,jsx,scss,json}": ["eslint", "git add"]
},
"ignore": ["node_modules", "dist", "package-lock.json"]
} }

View file

@ -56,7 +56,7 @@ function buildOgMetadata(overrideOptions = {}) {
// //
function buildClaimOgMetadata(uri, claim, overrideOptions = {}) { function buildClaimOgMetadata(uri, claim, overrideOptions = {}) {
// Initial setup for claim based og metadata // Initial setup for claim based og metadata
const { isChannel, claimName } = parseURI(uri); const { claimName } = parseURI(uri);
const claimTitle = escapeHtmlProperty(claim.title ? claim.title : claimName); const claimTitle = escapeHtmlProperty(claim.title ? claim.title : claimName);
const claimDescription = const claimDescription =
claim.description && claim.description.length > 0 claim.description && claim.description.length > 0
@ -64,12 +64,11 @@ function buildClaimOgMetadata(uri, claim, overrideOptions = {}) {
: `Watch ${claimTitle} on LBRY.tv`; : `Watch ${claimTitle} on LBRY.tv`;
const claimLanguage = escapeHtmlProperty(claim.language) || 'en_US'; const claimLanguage = escapeHtmlProperty(claim.language) || 'en_US';
const claimThumbnail = escapeHtmlProperty(claim.thumbnail_url) || `${URL}/og.png`; const claimThumbnail = escapeHtmlProperty(claim.thumbnail_url) || `${URL}/og.png`;
const defaultClaimTitle =
claim.channel && !isChannel ? `${claimTitle} from ${claim.channel} on LBRY.tv` : `${claimTitle} on LBRY.tv`;
// Allow for ovverriding default claim based og metadata // Allow for ovverriding default claim based og metadata
const title = overrideOptions.title || claimTitle; const title = overrideOptions.title || claimTitle;
const description = overrideOptions.description || claimDescription; const description = overrideOptions.description || claimDescription;
const embedPlayer = overrideOptions.embedPlayer;
let head = ''; let head = '';
@ -95,9 +94,12 @@ function buildClaimOgMetadata(uri, claim, overrideOptions = {}) {
head += `<meta property="og:video" content="${videoUrl}" />`; head += `<meta property="og:video" content="${videoUrl}" />`;
head += `<meta property="og:video:secure_url" content="${videoUrl}" />`; head += `<meta property="og:video:secure_url" content="${videoUrl}" />`;
head += `<meta property="og:video:type" content="${claim.source_media_type}" />`; head += `<meta property="og:video:type" content="${claim.source_media_type}" />`;
head += `<meta name="twitter:player" content="${embedPlayer}">`;
if (claim.frame_width && claim.frame_height) { if (claim.frame_width && claim.frame_height) {
head += `<meta property="og:video:width" content="${claim.frame_width}"/>`; head += `<meta property="og:video:width" content="${claim.frame_width}"/>`;
head += `<meta property="og:video:height" content="${claim.frame_height}"/>`; head += `<meta property="og:video:height" content="${claim.frame_height}"/>`;
head += `<meta name="twitter:player:width" content="${claim.frame_width}">`;
head += `<meta name="twitter:player:height" content="${claim.frame_height}">`;
} }
} }
@ -126,6 +128,8 @@ module.exports.getHtml = async function getHtml(ctx) {
} }
const invitePath = `/$/${PAGES.INVITE}/`; const invitePath = `/$/${PAGES.INVITE}/`;
const embedPath = `/$/${PAGES.EMBED}/`;
const embedPlayer = URL + path;
if (path.includes(invitePath)) { if (path.includes(invitePath)) {
const inviteChannel = path.slice(invitePath.length).replace(/:/g, '#'); const inviteChannel = path.slice(invitePath.length).replace(/:/g, '#');
@ -151,6 +155,18 @@ module.exports.getHtml = async function getHtml(ctx) {
} }
} }
if (path.includes(embedPath)) {
const claimUri = path.replace(embedPath, '').replace(/:/g, '#');
const claim = await getClaimFromChainquery(claimUri);
if (claim) {
const ogMetadata = buildClaimOgMetadata(claimUri, claim, { embedPlayer: embedPlayer});
return insertToHead(html, ogMetadata);
}
return insertToHead(html);
}
if (!path.includes('$')) { if (!path.includes('$')) {
const claimUri = path.slice(1).replace(/:/g, '#'); const claimUri = path.slice(1).replace(/:/g, '#');
const claim = await getClaimFromChainquery(claimUri); const claim = await getClaimFromChainquery(claimUri);