LbryVolumeBarClass: add documentation

This commit is contained in:
infinite-persistence 2022-06-07 10:31:12 +08:00
parent b921547386
commit 151749d4c3
No known key found for this signature in database
GPG key ID: B9C3252EDC3D0AA0

View file

@ -11,6 +11,12 @@ const VIDEOJS_VOLUME_PANEL_CLASS = 'VolumePanel';
const VIDEOJS_VOLUME_CONTROL_CLASS = 'VolumeControl'; const VIDEOJS_VOLUME_CONTROL_CLASS = 'VolumeControl';
const VIDEOJS_VOLUME_BAR_CLASS = 'VolumeBar'; const VIDEOJS_VOLUME_BAR_CLASS = 'VolumeBar';
/**
* LbryVolumeBarClass
*
* NOTE_1: https://github.com/lbryio/lbry-desktop/pull/5034 Stop propagation of
* mouse down/up events for it to work in Floating Player.
*/
class LbryVolumeBarClass extends videojs.getComponent(VIDEOJS_VOLUME_BAR_CLASS) { class LbryVolumeBarClass extends videojs.getComponent(VIDEOJS_VOLUME_BAR_CLASS) {
constructor(player, options = {}) { constructor(player, options = {}) {
super(player, options); super(player, options);
@ -34,12 +40,12 @@ class LbryVolumeBarClass extends videojs.getComponent(VIDEOJS_VOLUME_BAR_CLASS)
handleMouseDown(event) { handleMouseDown(event) {
super.handleMouseDown(event); super.handleMouseDown(event);
event.stopPropagation(); event.stopPropagation(); // @see NOTE_1
} }
handleMouseMove(event) { handleMouseMove(event) {
super.handleMouseMove(event); super.handleMouseMove(event);
event.stopPropagation(); event.stopPropagation(); // @see NOTE_1
} }
} }