Undo the channel-clamping and let user figure out from Toast

Several issues with the clamping behavior:
- Problems trying to sync with the activeChannel setting.
- Corner-cases like unable to un-react because the comment and react channel was different; global mods not be able to change channels to do certain actions.

Just let the user know what are the channel(s) that they used to comment previously in the Toast.

ui/component/commentCreate/extra-contents.jsx

@@ -11,11 +11,10 @@ import SelectChannel from 'component/selectChannel';
 type SelectorProps = {
   isReply: boolean,
   isLivestream: boolean,
-  channelIds?: Array<string>, // Specific channel IDs to show. Must be a subset of own channels.
 };
 
 export const FormChannelSelector = (selectorProps: SelectorProps) => {
-  const { isReply, isLivestream, channelIds } = selectorProps;
+  const { isReply, isLivestream } = selectorProps;
 
   return (
     <div className="comment-create__label-wrapper">
@@ -23,7 +22,7 @@ export const FormChannelSelector = (selectorProps: SelectorProps) => {
         {(isReply ? __('Replying as') : isLivestream ? __('Chat as') : __('Comment as')) + ' '}
       </span>
 
-      <SelectChannel tiny channelIds={channelIds} />
+      <SelectChannel tiny />
     </div>
   );
 };

ui/component/commentCreate/index.js

@@ -12,7 +12,7 @@ import { doCommentCreate, doFetchCreatorSettings, doCommentById } from 'redux/ac
 import { doSendTip, doSendCashTip } from 'redux/actions/wallet';
 import { doToast } from 'redux/actions/notifications';
 import { selectActiveChannelClaim } from 'redux/selectors/app';
-import { selectMyCommentedChannelIdsForId, selectSettingsByChannelId } from 'redux/selectors/comments';
+import { selectSettingsByChannelId } from 'redux/selectors/comments';
 import { getChannelIdFromClaim } from 'util/claim';
 import { doOpenModal } from 'redux/actions/app';
 import { selectClientSetting } from 'redux/selectors/settings';
@@ -45,7 +45,6 @@ const select = (state, props) => {
     settingsByChannelId: selectSettingsByChannelId(state),
     supportDisabled: makeSelectTagInClaimOrChannelForUri(uri, DISABLE_SUPPORT_TAG)(state),
     preferredCurrency: selectClientSetting(state, SETTINGS.PREFERRED_CURRENCY),
-    myCommentedChannelIds: selectMyCommentedChannelIdsForId(state, claim?.claim_id),
   };
 };
 

ui/component/commentCreate/view.jsx

@@ -75,7 +75,6 @@ type Props = {
   doSendTip: (params: {}, isSupport: boolean, successCb: (any) => void, errorCb: (any) => void, boolean) => void,
   doOpenModal: (id: string, any) => void,
   preferredCurrency: string,
-  myCommentedChannelIds?: Array<string>,
 };
 
 export function CommentCreate(props: Props) {
@@ -112,7 +111,6 @@ export function CommentCreate(props: Props) {
     setQuickReply,
     doOpenModal,
     preferredCurrency,
-    myCommentedChannelIds,
   } = props;
 
   const isMobile = useIsMobile();
@@ -591,17 +589,7 @@ export function CommentCreate(props: Props) {
             className={isReply ? 'create__reply' : 'create__comment'}
             disabled={isFetchingChannels || disableInput}
             isLivestream={isLivestream}
-            label={
+            label={<FormChannelSelector isReply={Boolean(isReply)} isLivestream={Boolean(isLivestream)} />}
-              <FormChannelSelector
-                isReply={Boolean(isReply)}
-                isLivestream={Boolean(isLivestream)}
-                channelIds={
-                  !claimIsMine && myCommentedChannelIds && myCommentedChannelIds.length > 0
-                    ? myCommentedChannelIds
-                    : undefined
-                }
-              />
-            }
             noticeLabel={
               isMobile && (
                 <HelpText deletedComment={deletedComment} minAmount={minAmount} minSuper={minSuper} minTip={minTip} />

ui/component/selectChannel/view.jsx

@@ -6,7 +6,6 @@ type Props = {
   tiny?: boolean,
   label?: string,
   injected?: ?Array<string>,
-  channelIds?: Array<string>, // Specific channel IDs to show. Must be a subset of own channels.
   // --- Redux ---
   myChannelClaims: ?Array<ChannelClaim>,
   fetchingChannels: boolean,
@@ -17,7 +16,6 @@ type Props = {
 function SelectChannel(props: Props) {
   const {
     fetchingChannels,
-    channelIds,
     myChannelClaims = [],
     label,
     injected = [],
@@ -31,11 +29,6 @@ function SelectChannel(props: Props) {
     setActiveChannel(channelClaimId);
   }
 
-  let mine = myChannelClaims;
-  if (myChannelClaims && channelIds) {
-    mine = myChannelClaims.filter((x) => channelIds.includes(x.claim_id));
-  }
-
   return (
     <>
       <FormField
@@ -51,8 +44,8 @@ function SelectChannel(props: Props) {
           <option>{__('Loading your channels...')}</option>
         ) : (
           <>
-            {mine &&
+            {myChannelClaims &&
-              mine.map(({ name, claim_id: claimId }) => (
+              myChannelClaims.map(({ name, claim_id: claimId }) => (
                 <option key={claimId} value={claimId}>
                   {name}
                 </option>

ui/redux/actions/comments.js

@@ -7,7 +7,7 @@ import Lbry from 'lbry';
 import { resolveApiMessage } from 'util/api-message';
 import { parseURI, buildURI, isURIEqual } from 'util/lbryURI';
 import { devToast, dispatchToast, doFailedSignatureToast } from 'util/toast-wrappers';
-import { selectClaimForUri, selectClaimsByUri, selectMyChannelClaims } from 'redux/selectors/claims';
+import { selectClaimForUri, selectClaimsById, selectClaimsByUri, selectMyChannelClaims } from 'redux/selectors/claims';
 import { doResolveUris, doClaimSearch, doResolveClaimIds } from 'redux/actions/claims';
 import { doToast, doSeeNotifications } from 'redux/actions/notifications';
 import {
@@ -646,7 +646,15 @@ export function doCommentCreate(uri: string, livestream: boolean, params: Commen
 
     if (myCommentedChannelIds && myCommentedChannelIds.length) {
       if (!myCommentedChannelIds.includes(activeChannelClaim.claim_id)) {
-        dispatchToast(dispatch, __('Commenting from multiple channels is not allowed.'));
+        const claimById = selectClaimsById(state);
+        const commentedChannelNames = myCommentedChannelIds.map((id) => claimById[id]?.name);
+
+        dispatchToast(
+          dispatch,
+          __('Commenting from multiple channels is not allowed.'),
+          commentedChannelNames.join(' • '),
+          'long'
+        );
         return;
       }
     }