LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Notifications: skip resolve during boot (#330)

Browse source 
## Issue
- Large resolve count (albeit batched) on bootup.

## Changes
- Skip the call on bootup. The same call will happen when you click the notification bell, so it's not too late to resolve at that time.
- Added `true` to `doResolveUris` to return cached results, otherwise it will keep resolving the same channels every time we enter Notifications Page.
This commit is contained in:
infinite-persistence 2021-11-19 06:46:31 -08:00 committed by GitHub
parent 6a33ed337b
commit 328b60d021
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ui/redux/actions/app.js
View file

@ -545,7 +545,7 @@ export function doSignIn() {
dispatch(doGetAndPopulatePreferences());
dispatch(doNotificationSocketConnect(true));
dispatch(doNotificationList());
dispatch(doNotificationList(null, false));
dispatch(doCheckPendingClaims());
dispatch(doBalanceSubscribe());
dispatch(doFetchChannelListMine());

46
ui/redux/actions/notifications.js
View file

@ -45,7 +45,7 @@ export function doDismissError() {
};
}
export function doNotificationList(types?: Array<string>) {
export function doNotificationList(types?: Array<string>, resolve: boolean = true) {
return async (dispatch: Dispatch, getState: GetState) => {
const state = getState();
const notificationTypes = selectNotificationCategories(state);
@ -72,27 +72,31 @@ export function doNotificationList(types?: Array<string>) {
return Lbryio.call('notification', 'list', params).then((response) => {
const notifications = response || [];
const channelsToResolve = notifications
.filter((notification: WebNotification) => {
if (
(notification.notification_parameters.dynamic &&
notification.notification_parameters.dynamic.comment_author) ||
notification.notification_rule === RULE.NEW_CONTENT
) {
return true;
} else {
return false;
}
})
.map((notification) => {
if (notification.notification_rule === RULE.NEW_CONTENT) {
return notification.notification_parameters.device.target;
} else {
return notification.notification_parameters.dynamic.comment_author;
}
});
dispatch(doResolveUris(channelsToResolve));
if (resolve) {
const channelsToResolve = notifications
.filter((notification: WebNotification) => {
if (
(notification.notification_parameters.dynamic &&
notification.notification_parameters.dynamic.comment_author) ||
notification.notification_rule === RULE.NEW_CONTENT
) {
return true;
} else {
return false;
}
})
.map((notification) => {
if (notification.notification_rule === RULE.NEW_CONTENT) {
return notification.notification_parameters.device.target;
} else {
return notification.notification_parameters.dynamic.comment_author;
}
});
dispatch(doResolveUris(channelsToResolve, true));
}
dispatch({
type: ACTIONS.NOTIFICATION_LIST_COMPLETED,
data: {