Stop fetching reacts if failed for 3 times
Not sure if this will ever occur, but technically possible from the code point of view. Try adding this to see if it stops the spikes in `reaction.list` calls.
This commit is contained in:
parent
9c05239b04
commit
47d39b20d3
1 changed files with 11 additions and 0 deletions
|
@ -76,6 +76,8 @@ function CommentList(props: Props) {
|
||||||
const [page, setPage] = React.useState(0);
|
const [page, setPage] = React.useState(0);
|
||||||
const totalFetchedComments = allCommentIds ? allCommentIds.length : 0;
|
const totalFetchedComments = allCommentIds ? allCommentIds.length : 0;
|
||||||
|
|
||||||
|
const [noReactsOccurrence, setNoReactsOccurrence] = React.useState(0);
|
||||||
|
|
||||||
// Display comments immediately if not fetching reactions
|
// Display comments immediately if not fetching reactions
|
||||||
// If not, wait to show comments until reactions are fetched
|
// If not, wait to show comments until reactions are fetched
|
||||||
const [readyToDisplayComments, setReadyToDisplayComments] = React.useState(
|
const [readyToDisplayComments, setReadyToDisplayComments] = React.useState(
|
||||||
|
@ -129,6 +131,13 @@ function CommentList(props: Props) {
|
||||||
|
|
||||||
if (!othersReactsById || !myReactsByCommentId) {
|
if (!othersReactsById || !myReactsByCommentId) {
|
||||||
idsForReactionFetch = allCommentIds;
|
idsForReactionFetch = allCommentIds;
|
||||||
|
|
||||||
|
if (noReactsOccurrence > 3) {
|
||||||
|
// Still no reactions fetched after 3 attempts. Let's stop for now.
|
||||||
|
return;
|
||||||
|
} else {
|
||||||
|
setNoReactsOccurrence(noReactsOccurrence + 1);
|
||||||
|
}
|
||||||
} else {
|
} else {
|
||||||
idsForReactionFetch = allCommentIds.filter((commentId) => {
|
idsForReactionFetch = allCommentIds.filter((commentId) => {
|
||||||
const key = activeChannelId ? `${commentId}:${activeChannelId}` : commentId;
|
const key = activeChannelId ? `${commentId}:${activeChannelId}` : commentId;
|
||||||
|
@ -154,6 +163,8 @@ function CommentList(props: Props) {
|
||||||
activeChannelId,
|
activeChannelId,
|
||||||
fetchingChannels,
|
fetchingChannels,
|
||||||
isFetchingReacts,
|
isFetchingReacts,
|
||||||
|
noReactsOccurrence,
|
||||||
|
setNoReactsOccurrence,
|
||||||
]);
|
]);
|
||||||
|
|
||||||
// Scroll to linked-comment
|
// Scroll to linked-comment
|
||||||
|
|
Loading…
Add table
Reference in a new issue