LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Recommended: fix "no results found" flashing after search

Browse source 
## Cause
When 'selectRecommendedContentForUri' is filtering results against the blocklist, it relies on claim data which could be unresolved yet. It filters to empty results for this scenario, hence the flashing message.

## Change
Just return raw results when claims are not resolved yet, so that the GUI knows it needs to show the placeholders while resolving. After resolving, it'll go through the blocklist filtering again.
This commit is contained in:
infinite-persistence 2022-03-04 19:44:58 +08:00 committed by Thomas Zarebczan
parent de0bc8cf99
commit 4a5e967628
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ui/redux/selectors/search.js
View file

@ -101,7 +101,9 @@ export const selectRecommendedContentForUri = createCachedSelector(
recommendedContent = searchResult['uris'].filter((searchUri) => { recommendedContent = searchResult['uris'].filter((searchUri) => {
const searchClaim = claimsByUri[searchUri]; const searchClaim = claimsByUri[searchUri];
if (!searchClaim) return; if (!searchClaim) {
return true;
}
const signingChannel = searchClaim && searchClaim.signing_channel; const signingChannel = searchClaim && searchClaim.signing_channel;
const channelUri = signingChannel && signingChannel.canonical_url; const channelUri = signingChannel && signingChannel.canonical_url;