LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Update messaging around bitrates / resolution

Browse source 
Allow for higher bitrates, but still recommend transcode over 8mbps until we have transcode on upload.
This commit is contained in:
Thomas Zarebczan 2022-06-02 14:47:50 -04:00
parent 37d9db9cf2
commit 547781c07c
No known key found for this signature in database
GPG key ID: 767B41E1BB7346F2
2 changed files with 10 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
static/app-strings.json
View file

@ -874,7 +874,7 @@
"Sorry, your request timed out. Modify your options or %again%": "Sorry, your request timed out. Modify your options or %again%", "Sorry, your request timed out. Modify your options or %again%": "Sorry, your request timed out. Modify your options or %again%",
"Sorry, your request timed out. Try refreshing in a bit.": "Sorry, your request timed out. Try refreshing in a bit.", "Sorry, your request timed out. Try refreshing in a bit.": "Sorry, your request timed out. Try refreshing in a bit.",
"Pause at any time to select a thumbnail from your video": "Pause at any time to select a thumbnail from your video", "Pause at any time to select a thumbnail from your video": "Pause at any time to select a thumbnail from your video",
"For video content, use MP4s in H264/AAC format and a friendly bitrate (under 5 Mbps) and resolution (720p) for more reliable streaming. %SITE_NAME% uploads are restricted to %limit% GB.": "For video content, use MP4s in H264/AAC format and a friendly bitrate (under 5 Mbps) and resolution (720p) for more reliable streaming. %SITE_NAME% uploads are restricted to %limit% GB.", "For video content, use MP4s in H264/AAC format and a friendly bitrate (under 8 Mbps) for more reliable streaming. %SITE_NAME% uploads are restricted to %limit% GB.": "For video content, use MP4s in H264/AAC format and a friendly bitrate (under 8 Mbps) for more reliable streaming. %SITE_NAME% uploads are restricted to %limit% GB.",
"Share this channel": "Share this channel", "Share this channel": "Share this channel",
"File preview": "File preview", "File preview": "File preview",
"Go Home": "Go Home", "Go Home": "Go Home",
@ -969,10 +969,9 @@
"We've followed your invitee for you. Check them out!": "We've followed your invitee for you. Check them out!", "We've followed your invitee for you. Check them out!": "We've followed your invitee for you. Check them out!",
"Congrats": "Congrats", "Congrats": "Congrats",
"Transcoding this %size% MB file should take under %processTime% %units%.": "Transcoding this %size% MB file should take under %processTime% %units%.", "Transcoding this %size% MB file should take under %processTime% %units%.": "Transcoding this %size% MB file should take under %processTime% %units%.",
"For video content, use MP4s in H264/AAC format and a friendly bitrate (under 5 Mbps) and resolution (720p) for more reliable streaming.": "For video content, use MP4s in H264/AAC format and a friendly bitrate (under 5 Mbps) and resolution (720p) for more reliable streaming.", "Your video may not be the best format. Use MP4s in H264/AAC format and a friendly bitrate (under 8 Mbps) for more reliable streaming.": "Your video may not be the best format. Use MP4s in H264/AAC format and a friendly bitrate (under 8 Mbps) for more reliable streaming.",
"Your video may not be the best format. Use MP4s in H264/AAC format and a friendly bitrate (under 5 Mbps) and resolution (720p) for more reliable streaming.": "Your video may not be the best format. Use MP4s in H264/AAC format and a friendly bitrate (under 5 Mbps) and resolution (720p) for more reliable streaming.", "Your video has a bitrate over 8 Mbps. We suggest transcoding to provide viewers the best experience.": "Your video has a bitrate over 8 Mbps. We suggest transcoding to provide viewers the best experience.",
"Your video has a bitrate over 5 Mbps. We suggest transcoding to provide viewers the best experience.": "Your video has a bitrate over 5 Mbps. We suggest transcoding to provide viewers the best experience.", "Your video has a bitrate over ~16 Mbps and cannot be processed at this time. We suggest transcoding to provide viewers the best experience.": "Your video has a bitrate over ~16 Mbps and cannot be processed at this time. We suggest transcoding to provide viewers the best experience.",
"Your video has a bitrate over ~12 Mbps and cannot be processed at this time. We suggest transcoding to provide viewers the best experience.": "Your video has a bitrate over ~12 Mbps and cannot be processed at this time. We suggest transcoding to provide viewers the best experience.",
"Bitrate is over the max, please transcode or choose another file.": "Bitrate is over the max, please transcode or choose another file.", "Bitrate is over the max, please transcode or choose another file.": "Bitrate is over the max, please transcode or choose another file.",
"seconds": "seconds", "seconds": "seconds",
"second": "second", "second": "second",

25
ui/component/publishFile/view.jsx
View file

@ -96,8 +96,8 @@ function PublishFile(props: Props) {
inEditMode, inEditMode,
} = props; } = props;
const RECOMMENDED_BITRATE = 6000000; const RECOMMENDED_BITRATE = 8500000;
const MAX_BITRATE = 12000000; const MAX_BITRATE = 16500000;
const TV_PUBLISH_SIZE_LIMIT_BYTES = WEB_PUBLISH_SIZE_LIMIT_GB * 1073741824; const TV_PUBLISH_SIZE_LIMIT_BYTES = WEB_PUBLISH_SIZE_LIMIT_GB * 1073741824;
const TV_PUBLISH_SIZE_LIMIT_GB_STR = String(WEB_PUBLISH_SIZE_LIMIT_GB); const TV_PUBLISH_SIZE_LIMIT_GB_STR = String(WEB_PUBLISH_SIZE_LIMIT_GB);
@ -278,10 +278,10 @@ function PublishFile(props: Props) {
<p className="help--warning"> <p className="help--warning">
{bitRateIsOverMax {bitRateIsOverMax
? __( ? __(
'Your video has a bitrate over ~12 Mbps and cannot be processed at this time. We suggest transcoding to provide viewers the best experience.' 'Your video has a bitrate over ~16 Mbps and cannot be processed at this time. We suggest transcoding to provide viewers the best experience.'
) )
: __( : __(
'Your video has a bitrate over 5 Mbps. We suggest transcoding to provide viewers the best experience.' 'Your video has a bitrate over 8 Mbps. We suggest transcoding to provide viewers the best experience.'
)}{' '} )}{' '}
<Button <Button
button="link" button="link"
@ -296,7 +296,7 @@ function PublishFile(props: Props) {
return ( return (
<p className="help--warning"> <p className="help--warning">
{__( {__(
'Your video may not be the best format. Use MP4s in H264/AAC format and a friendly bitrate (under 5 Mbps) and resolution (720p) for more reliable streaming.' 'Your video may not be the best format. Use MP4s in H264/AAC format and a friendly bitrate (under 8 Mbps) for more reliable streaming.'
)}{' '} )}{' '}
<Button <Button
button="link" button="link"
@ -324,7 +324,7 @@ function PublishFile(props: Props) {
return ( return (
<p className="help"> <p className="help">
{__( {__(
'For video content, use MP4s in H264/AAC format and a friendly bitrate (under 5 Mbps) and resolution (720p) for more reliable streaming. %SITE_NAME% uploads are restricted to %limit% GB.', 'For video content, use MP4s in H264/AAC format and a friendly bitrate (under 8 Mbps) for more reliable streaming. %SITE_NAME% uploads are restricted to %limit% GB.',
{ SITE_NAME, limit: TV_PUBLISH_SIZE_LIMIT_GB_STR } { SITE_NAME, limit: TV_PUBLISH_SIZE_LIMIT_GB_STR }
)}{' '} )}{' '}
<Button <Button
@ -336,19 +336,6 @@ function PublishFile(props: Props) {
); );
} }
// @endif // @endif
// @if TARGET='app'
if (!isStillEditing) {
return (
<p className="help">
{__(
'For video content, use MP4s in H264/AAC format and a friendly bitrate (under 5 Mbps) and resolution (720p) for more reliable streaming.'
)}{' '}
<Button button="link" label={__('Upload Guide')} href="https://odysee.com/@OdyseeHelp:b/uploadguide:1" />
</p>
);
}
// @endif
} }
function parseName(newName) { function parseName(newName) {