LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

OG: fix url for categories

Browse source 
## Issue
Category cards are showing up as "odysee.com" cards in Facebook.

## Change
- `og:url` is supposed to be the canonical URL. It was hardcoded to "odysee.com", so every category was being redirected when the card is being generated.
- Removed `twitter:url`. The documentation says it will fall back to `og:url`, so there is not need to define both if it's the same.
This commit is contained in:
infinite-persistence 2021-10-04 10:24:53 +08:00
parent f7b942fa42
commit 5757eb7036
No known key found for this signature in database
GPG key ID: B9C3252EDC3D0AA0
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
web/src/html.js
View file

@ -74,12 +74,12 @@ function getCategoryMeta(path) {
// Normal metadata with option to override certain values // Normal metadata with option to override certain values
// //
function buildOgMetadata(overrideOptions = {}) { function buildOgMetadata(overrideOptions = {}) {
const { title, description, image } = overrideOptions; const { title, description, image, path } = overrideOptions;
const cleanDescription = removeMd(description || SITE_DESCRIPTION); const cleanDescription = removeMd(description || SITE_DESCRIPTION);
const head = const head =
`<title>${SITE_TITLE}</title>\n` + `<title>${SITE_TITLE}</title>\n` +
`<meta name="description" content="${cleanDescription}" />\n` + `<meta name="description" content="${cleanDescription}" />\n` +
`<meta property="og:url" content="${URL}" />\n` + `<meta property="og:url" content="${path ? `${URL}${path}` : URL}" />\n` +
`<meta property="og:title" content="${title || OG_HOMEPAGE_TITLE || SITE_TITLE}" />\n` + `<meta property="og:title" content="${title || OG_HOMEPAGE_TITLE || SITE_TITLE}" />\n` +
`<meta property="og:site_name" content="${SITE_NAME || SITE_TITLE}"/>\n` + `<meta property="og:site_name" content="${SITE_NAME || SITE_TITLE}"/>\n` +
`<meta property="og:description" content="${cleanDescription}" />\n` + `<meta property="og:description" content="${cleanDescription}" />\n` +
@ -91,7 +91,6 @@ function buildOgMetadata(overrideOptions = {}) {
}" />\n` + }" />\n` +
`<meta name="twitter:description" content="${cleanDescription}" />\n` + `<meta name="twitter:description" content="${cleanDescription}" />\n` +
`<meta name="twitter:image" content="${image || OG_IMAGE_URL || `${URL}/public/v2-og.png`}"/>\n` + `<meta name="twitter:image" content="${image || OG_IMAGE_URL || `${URL}/public/v2-og.png`}"/>\n` +
`<meta name="twitter:url" content="${URL}" />\n` +
'<meta property="fb:app_id" content="1673146449633983" />\n' + '<meta property="fb:app_id" content="1673146449633983" />\n' +
`<link rel="canonical" content="${SITE_CANONICAL_URL || URL}"/>` + `<link rel="canonical" content="${SITE_CANONICAL_URL || URL}"/>` +
`<link rel="search" type="application/opensearchdescription+xml" title="${ `<link rel="search" type="application/opensearchdescription+xml" title="${
@ -348,6 +347,7 @@ async function getHtml(ctx) {
title: categoryMeta.title, title: categoryMeta.title,
description: categoryMeta.description, description: categoryMeta.description,
image: categoryMeta.image, image: categoryMeta.image,
path: requestPath,
}); });
return insertToHead(html, categoryPageMetadata); return insertToHead(html, categoryPageMetadata);
} }