LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Undo the hardcoded ad div id (#1719)

Browse source 
I previously hardcoded both IDs since the script was not looking the right one at one point, but I guess that was unnecessary.

I don't think it causes any problems, because I'm still just loading 1 script (no double video, just 2 divs for them to choose).

Note that we are still using the `filepage` script since the `homepage` one is not working.
This commit is contained in:
infinite-persistence 2022-06-21 17:51:07 +08:00 committed by GitHub
parent 3e0f1c63c9
commit 5888b6b7d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
web/component/ads/view.jsx
View file

@ -14,6 +14,7 @@ const AD_CONFIGS = Object.freeze({
ADNIMATION: {
// url: 'https://tg1.aniview.com/api/adserver/spt?AV_TAGID=6252bb6f28951333ec10a7a6&AV_PUBLISHERID=601d9a7f2e688a79e17c1265',
// tag: 'AV6252bb6f28951333ec10a7a6',
// ^-- supposed to use the above, but not working, so coded to use ADNIMATION_FILEPAGE
url: 'https://tg1.aniview.com/api/adserver/spt?AV_TAGID=62558336037e0f3df07ff0a8&AV_PUBLISHERID=601d9a7f2e688a79e17c1265',
tag: 'AV6252bb6f28951333ec10a7a6',
},
@ -126,9 +127,7 @@ function Ads(props: Props) {
})}
>
<div className="ad__container">
{/* <div id={adConfig.tag} /> */}
<div id="AV6252bb6f28951333ec10a7a6" />
<div id="AV62558336037e0f3df07ff0a8" />
<div id={adConfig.tag} />
</div>
<div
className={classnames('ads__claim-text', {