LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

clean up dupe code + make sure failing analytics doesn't throw subscription error.

Browse source
This commit is contained in:
Dan Peterson 2021-12-29 13:26:28 -06:00 committed by Thomas Zarebczan
parent c22a3048dc
commit 60430b5267
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
web/component/browserNotificationSettings/use-browser-notifications.js
View file

@ -35,19 +35,16 @@ export default () => {
if (!user) return;
setEncounteredError(false);
try {
if (await pushNotifications.subscribe(user.id)) {
const subscribed = await pushNotifications.subscribe(user.id);
if (subscribed) {
setSubscribed(true);
setPushPermission(window.Notification?.permission);
analytics.reportEvent('browser_notification', { [GA_DIMENSIONS.ACTION]: 'subscribed' });
return true;
} else {
setEncounteredError(true);
analytics.reportEvent('browser_notification', { [GA_DIMENSIONS.ACTION]: 'subscribe_failed' });
}
} catch {
setEncounteredError(true);
analytics.reportEvent('browser_notification', { [GA_DIMENSIONS.ACTION]: 'subscribe_failed' });
}
analytics.reportEvent('browser_notification', { [GA_DIMENSIONS.ACTION]: 'subscribed' });
};
const unsubscribe = async () => {