LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Replace recsys beacon with regular network call (#1090)

Browse source 
Ticket: 1080
Reason: unreliable; often blocked.
Additional: add auth-token, per suggestion in FYP PR.
This commit is contained in:
infinite-persistence 2022-03-14 07:27:09 -07:00 committed by GitHub
parent 69a9245324
commit 63f19b278d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
extras/recsys/recsys.js
View file

@ -3,7 +3,9 @@ import { selectUser } from 'redux/selectors/user';
import { makeSelectRecommendedRecsysIdForClaimId } from 'redux/selectors/search'; import { makeSelectRecommendedRecsysIdForClaimId } from 'redux/selectors/search';
import { v4 as Uuidv4 } from 'uuid'; import { v4 as Uuidv4 } from 'uuid';
import { parseURI } from 'util/lbryURI'; import { parseURI } from 'util/lbryURI';
import { getAuthToken } from 'util/saved-passwords';
import * as SETTINGS from 'constants/settings'; import * as SETTINGS from 'constants/settings';
import { X_LBRY_AUTH_TOKEN } from 'constants/token';
import { makeSelectClaimForUri } from 'redux/selectors/claims'; import { makeSelectClaimForUri } from 'redux/selectors/claims';
import { selectPlayingUri, selectPrimaryUri } from 'redux/selectors/content'; import { selectPlayingUri, selectPrimaryUri } from 'redux/selectors/content';
import { selectClientSetting, selectDaemonSettings } from 'redux/selectors/settings'; import { selectClientSetting, selectDaemonSettings } from 'redux/selectors/settings';
@ -136,14 +138,21 @@ const recsys = {
if (recsys.entries[claimId] && shareTelemetry) { if (recsys.entries[claimId] && shareTelemetry) {
const data = JSON.stringify(recsys.entries[claimId]); const data = JSON.stringify(recsys.entries[claimId]);
try {
navigator.sendBeacon(recsysEndpoint, data);
if (!isTentative) { if (!isTentative) {
delete recsys.entries[claimId]; delete recsys.entries[claimId];
} }
} catch (error) {
console.log('no beacon for you', error); return fetch(recsysEndpoint, {
} method: 'POST',
headers: {
[X_LBRY_AUTH_TOKEN]: getAuthToken(),
'Content-Type': 'application/json',
},
body: data,
}).catch((err) => {
console.log('RECSYS: failed to send entry', err);
});
} }
recsys.log('sendRecsysEntry', claimId); recsys.log('sendRecsysEntry', claimId);
}, },