style pass

ui/analytics.js

@@ -26,10 +26,10 @@ if (isProduction) {
 // @endif
 
 type Analytics = {
-  error: string => Promise<any>,
+  error: (string) => Promise<any>,
   sentryError: ({} | string, {}) => Promise<any>,
   pageView: (string, ?string) => void,
-  setUser: Object => void,
+  setUser: (Object) => void,
   toggleInternal: (boolean, ?boolean) => void,
   apiLogView: (string, string, string, ?number, ?() => void) => Promise<any>,
   apiLogPublish: (ChannelClaim | StreamClaim) => void,
@@ -55,9 +55,9 @@ type Analytics = {
   emailVerifiedEvent: () => void,
   rewardEligibleEvent: () => void,
   startupEvent: () => void,
-  purchaseEvent: number => void,
-  readyEvent: number => void,
-  openUrlEvent: string => void,
+  purchaseEvent: (number) => void,
+  readyEvent: (number) => void,
+  openUrlEvent: (string) => void,
 };
 
 type LogPublishParams = {
@@ -75,8 +75,8 @@ if (window.localStorage.getItem(SHARE_INTERNAL) === 'true') internalAnalyticsEna
 // @endif
 
 const analytics: Analytics = {
-  error: message => {
-    return new Promise(resolve => {
+  error: (message) => {
+    return new Promise((resolve) => {
       if (internalAnalyticsEnabled && isProduction) {
         return Lbryio.call('event', 'desktop_error', { error_message: message }).then(() => {
           resolve(true);
@@ -87,9 +87,9 @@ const analytics: Analytics = {
     });
   },
   sentryError: (error, errorInfo) => {
-    return new Promise(resolve => {
+    return new Promise((resolve) => {
       if (internalAnalyticsEnabled && isProduction) {
-        Sentry.withScope(scope => {
+        Sentry.withScope((scope) => {
           scope.setExtras(errorInfo);
           const eventId = Sentry.captureException(error);
           resolve(eventId);
@@ -114,7 +114,7 @@ const analytics: Analytics = {
       MatomoInstance.trackPageView(params);
     }
   },
-  setUser: userId => {
+  setUser: (userId) => {
     if (internalAnalyticsEnabled && userId) {
       window._paq.push(['setUserId', String(userId)]);
       // @if TARGET='app'
@@ -188,19 +188,12 @@ const analytics: Analytics = {
     }
   },
 
-  apiSyncTags: params => {
+  apiSyncTags: (params) => {
     if (internalAnalyticsEnabled && isProduction) {
       Lbryio.call('content_tags', 'sync', params);
     }
   },
 
-  apiSearchFeedback: (query, vote) => {
-    if (isProduction) {
-      // We don't need to worry about analytics enabled here because users manually click on the button to provide feedback
-      Lbryio.call('feedback', 'search', { query, vote });
-    }
-  },
-
   videoFetchDuration: (source, duration) => {
     sendPromMetric('time_to_fetch', duration);
     sendMatomoEvent('Media', 'TimeToFetch', source, duration);
@@ -238,10 +231,10 @@ const analytics: Analytics = {
       });
     }
   },
-  playerLoadedEvent: embedded => {
+  playerLoadedEvent: (embedded) => {
     sendMatomoEvent('Player', 'Loaded', embedded ? 'embedded' : 'onsite');
   },
-  playerStartedEvent: embedded => {
+  playerStartedEvent: (embedded) => {
     sendMatomoEvent('Player', 'Started', embedded ? 'embedded' : 'onsite');
   },
   tagFollowEvent: (tag, following) => {
@@ -316,7 +309,7 @@ analytics.pageView(
 
 // Listen for url changes and report
 // This will include search queries
-history.listen(location => {
+history.listen((location) => {
   const { pathname, search } = location;
 
   const page = `${pathname}${search}`;

ui/component/claimList/view.jsx

@@ -117,6 +117,7 @@ export default function ClaimList(props: Props) {
             <div className={classnames('claim-list__header', { 'section__title--small': type === 'small' })}>
               {header}
               {loading && <Spinner type="small" />}
+              {(headerAltControls || defaultSort) && (
                 <div className="claim-list__alt-controls">
                   {headerAltControls}
                   {defaultSort && (
@@ -132,6 +133,7 @@ export default function ClaimList(props: Props) {
                     </FormField>
                   )}
                 </div>
+              )}
             </div>
           )}
         </React.Fragment>

ui/component/searchOptions/view.jsx

@@ -127,9 +127,9 @@ const SearchOptions = (props: Props) => {
           onClick={() => updateSearchOptions(SEARCH_OPTIONS.CLAIM_TYPE, SEARCH_OPTIONS.INCLUDE_FILES_AND_CHANNELS)}
         />
       </div>
+      {options[SEARCH_OPTIONS.CLAIM_TYPE] === SEARCH_OPTIONS.INCLUDE_FILES && (
         <div className="media-types">
-        {options[SEARCH_OPTIONS.CLAIM_TYPE] === SEARCH_OPTIONS.INCLUDE_FILES &&
-          Object.entries(TYPES_ADVANCED).map((t) => {
+          {Object.entries(TYPES_ADVANCED).map((t) => {
             const option = t[0];
             return (
               <FormField
@@ -145,6 +145,7 @@ const SearchOptions = (props: Props) => {
             );
           })}
         </div>
+      )}
     </>
   );
 

ui/page/search/index.js

@@ -1,5 +1,4 @@
 import { connect } from 'react-redux';
-import { doToast } from 'lbry-redux';
 import { withRouter } from 'react-router';
 import { doSearch } from 'redux/actions/search';
 import {
@@ -11,7 +10,6 @@ import {
 } from 'redux/selectors/search';
 import { selectShowMatureContent } from 'redux/selectors/settings';
 import { selectUserVerifiedEmail } from 'redux/selectors/user';
-import analytics from 'analytics';
 import SearchPage from './view';
 
 const select = (state, props) => {
@@ -41,24 +39,6 @@ const select = (state, props) => {
 
 const perform = (dispatch) => ({
   search: (query, options) => dispatch(doSearch(query, options)),
-  onFeedbackPositive: (query) => {
-    analytics.apiSearchFeedback(query, 1);
-    dispatch(
-      doToast({
-        message: __('Thanks for the feedback! You help make the app better for everyone.'),
-      })
-    );
-  },
-  onFeedbackNegative: (query) => {
-    analytics.apiSearchFeedback(query, 0);
-    dispatch(
-      doToast({
-        message: __(
-          'Thanks for the feedback. Mark has been notified and is currently walking over to his computer to work on this.'
-        ),
-      })
-    );
-  },
 });
 
 export default withRouter(connect(select, perform)(SearchPage));

ui/page/search/view.jsx

@@ -1,17 +1,14 @@
 // @flow
 import { SIMPLE_SITE, SHOW_ADS } from 'config';
-import * as ICONS from 'constants/icons';
 import React, { useEffect } from 'react';
 import { Lbry, parseURI, isNameValid } from 'lbry-redux';
 import ClaimList from 'component/claimList';
 import Page from 'component/page';
 import SearchOptions from 'component/searchOptions';
-import Button from 'component/button';
 import Ads from 'web/component/ads';
 import SearchTopClaim from 'component/searchTopClaim';
 import { formatLbryUrlForWeb } from 'util/url';
 import { useHistory } from 'react-router';
-import ClaimPreview from 'component/claimPreview';
 import { SEARCH_PAGE_SIZE } from 'constants/search';
 
 type AdditionalOptions = {
@@ -26,8 +23,6 @@ type Props = {
   isSearching: boolean,
   location: UrlLocation,
   uris: Array<string>,
-  onFeedbackNegative: (string) => void,
-  onFeedbackPositive: (string) => void,
   showNsfw: boolean,
   isAuthenticated: boolean,
   hasReachedMaxResultsLength: boolean,
@@ -37,8 +32,6 @@ export default function SearchPage(props: Props) {
   const {
     search,
     uris,
-    onFeedbackPositive,
-    onFeedbackNegative,
     location,
     isSearching,
     showNsfw,
@@ -128,25 +121,7 @@ export default function SearchPage(props: Props) {
               injectedItem={
                 SHOW_ADS && IS_WEB ? (SIMPLE_SITE ? false : !isAuthenticated && <Ads small type={'video'} />) : false
               }
-              headerAltControls={
-                <>
-                  <span>{__('Find what you were looking for?')}</span>
-                  <Button
-                    button="alt"
-                    description={__('Yes')}
-                    onClick={() => onFeedbackPositive(urlQuery)}
-                    icon={ICONS.YES}
             />
-                  <Button
-                    button="alt"
-                    description={__('No')}
-                    onClick={() => onFeedbackNegative(urlQuery)}
-                    icon={ICONS.NO}
-                  />
-                </>
-              }
-            />
-            {isSearching && new Array(5).fill(1).map((x, i) => <ClaimPreview key={i} placeholder="loading" />)}
 
             <div className="main--empty help">{__('These search results are provided by LBRY, Inc.')}</div>
           </>

ui/scss/component/_search.scss

@@ -9,21 +9,7 @@
 
 .search__options {
   margin-top: var(--spacing-s);
-  padding-left: var(--spacing-m);
-
-  transition: all 0.3s ease-out;
-
-  // These will be expanded by 'search__options--expanded'.
-  max-height: 0;
-  opacity: 0;
-  visibility: hidden;
-
-  .search__legend {
-    font-weight: var(--font-weight-bold);
-    font-size: var(--font-small);
-    margin-bottom: var(--spacing-s);
-    padding: var(--spacing-xxs);
-  }
+  display: none;
 
   fieldset:not(:first-child) {
     margin-top: var(--spacing-m);
@@ -34,9 +20,16 @@
     table-layout: fixed;
   }
 
+  td {
+    vertical-align: middle;
+  }
+
   td:nth-of-type(1) {
+    width: 25%;
+
+    &:not(:first-of-type) {
       width: 20%;
-    vertical-align: top;
+    }
   }
 
   .claim-type-filter {
@@ -77,12 +70,18 @@
   }
 
   .media-types {
-    margin-top: var(--spacing-s);
+    margin-top: var(--spacing-m);
+    display: flex;
+    flex-direction: column;
 
     label {
       display: flex;
       align-items: center;
     }
+
+    @media (min-width: $breakpoint-small) {
+      flex-direction: row;
+    }
   }
 
   .radio,
@@ -90,16 +89,27 @@
     display: inline-block;
     margin-top: 0;
 
+    &:not(:first-of-type) {
+      margin-top: var(--spacing-s);
+    }
+
+    @media (min-width: $breakpoint-small) {
       &:not(:first-of-type) {
         margin-left: var(--spacing-m);
+        margin-top: 0;
+      }
     }
   }
 }
 
 .search__options--expanded {
-  max-height: 400px; // how to not hardcode this :(
-  opacity: 1;
-  visibility: visible;
+  display: block;
+}
+
+.search__legend {
+  font-weight: var(--font-weight-bold);
+  font-size: var(--font-small);
+  padding: var(--spacing-xxs);
 }
 
 .search__top-link {