AdsBanner: singleton script

Makes it play nice with AdsSticky, both of which uses the same `window.OBR` object.
This commit is contained in:
infinite-persistence 2022-06-15 13:31:49 +08:00 committed by Thomas Zarebczan
parent b9af50dede
commit 6c6aa7a117

View file

@ -1,5 +1,6 @@
// @flow // @flow
import React from 'react'; import React from 'react';
import { useHistory } from 'react-router-dom';
import Button from 'component/button'; import Button from 'component/button';
import I18nMessage from 'component/i18nMessage'; import I18nMessage from 'component/i18nMessage';
import * as PAGES from 'constants/pages'; import * as PAGES from 'constants/pages';
@ -33,7 +34,7 @@ const adsSignInDriver = (
// AdsBanner // AdsBanner
// **************************************************************************** // ****************************************************************************
let gReferenceCounter = 0; let gScript;
type Props = { type Props = {
isAdBlockerFound: ?boolean, isAdBlockerFound: ?boolean,
@ -45,35 +46,32 @@ type Props = {
export default function AdsBanner(props: Props) { export default function AdsBanner(props: Props) {
const { isAdBlockerFound, userHasPremiumPlus, userCountry, currentTheme, doSetAdBlockerFound } = props; const { isAdBlockerFound, userHasPremiumPlus, userCountry, currentTheme, doSetAdBlockerFound } = props;
const { location } = useHistory();
const shouldShowAds = useShouldShowAds(userHasPremiumPlus, userCountry, isAdBlockerFound, doSetAdBlockerFound); const shouldShowAds = useShouldShowAds(userHasPremiumPlus, userCountry, isAdBlockerFound, doSetAdBlockerFound);
const shouldLoadScript = shouldShowAds && !gScript;
const isMobile = useIsMobile(); const isMobile = useIsMobile();
React.useEffect(() => { React.useEffect(() => {
if (shouldShowAds) { // Must check `!gScript` again here since we have multiple instances of the
// component. The first one will load the script.
if (shouldLoadScript && !gScript) {
try { try {
const script = document.createElement('script'); gScript = document.createElement('script');
script.src = AD_SCRIPT_URL; gScript.src = AD_SCRIPT_URL;
script.async = true; gScript.async = true;
script.onload = () => {
++gReferenceCounter;
};
// $FlowFixMe // $FlowFixMe
document.body.appendChild(script); document.body.appendChild(gScript);
return () => {
// $FlowFixMe
document.body.removeChild(script);
if (--gReferenceCounter <= 0) {
// Note: This method has the bad requirement of the parent having to
// mount and dismount all banners in the same cycle.
delete window.OBR;
// TODO: clear styles after the team adds an ID or class for us to query.
}
};
} catch (e) {} } catch (e) {}
} }
}, [shouldShowAds]); }, [shouldLoadScript]);
React.useEffect(() => {
if (window?.OBR?.extern) {
window.OBR.extern.reloadWidget();
window.OBR.extern.refreshWidget();
}
}, [location.pathname]);
if (!shouldShowAds) { if (!shouldShowAds) {
return null; return null;