LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

review fixes

Browse source 
Set disableMaxKeyFee as a local variable. Removed file info from componentdidmount.
This commit is contained in:
Thomas Zarebczan 2019-02-11 19:05:11 -05:00
parent ffb4bf46cc
commit 7546f30f96
4 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/renderer/constants/settings.js
View file

@ -17,5 +17,4 @@ export const AUTOPLAY = 'autoplay';
export const RESULT_COUNT = 'resultCount';
export const OS_NOTIFICATIONS_ENABLED = 'osNotificationsEnabled';
export const AUTO_DOWNLOAD = 'autoDownload';
export const DISABLE_MAX_KEY_FEE = 'disableMaxKeyFee';
export const LOCAL_MAX_KEY_FEE = 'localMaxKeyFee';

3
src/renderer/page/file/view.jsx
View file

@ -58,8 +58,7 @@ class FilePage extends React.Component<Props> {
];
componentDidMount() {
// eslint-disable-next-line no-unused-vars
const { uri, fileInfo, fetchFileInfo, fetchCostInfo, setViewed, isSubscribed } = this.props;
const { uri, fetchFileInfo, fetchCostInfo, setViewed, isSubscribed } = this.props;
if (isSubscribed) {
this.removeFromSubscriptionNotifications();

1
src/renderer/page/settings/index.js
View file

@ -31,7 +31,6 @@ const select = state => ({
walletEncrypted: selectWalletIsEncrypted(state),
osNotificationsEnabled: selectosNotificationsEnabled(state),
autoDownload: makeSelectClientSetting(settings.AUTO_DOWNLOAD)(state),
disableMaxKeyFee: makeSelectClientSetting(settings.DISABLE_MAX_KEY_FEE)(state),
localMaxKeyFee: makeSelectClientSetting(settings.LOCAL_MAX_KEY_FEE)(state),
});

4
src/renderer/page/settings/view.jsx
View file

@ -39,7 +39,6 @@ type Props = {
updateWalletStatus: () => void,
walletEncrypted: boolean,
osNotificationsEnabled: boolean,
disableMaxKeyFee: boolean,
localMaxKeyFee: Price,
};
@ -175,13 +174,14 @@ class SettingsPage extends React.PureComponent<Props, State> {
walletEncrypted,
osNotificationsEnabled,
autoDownload,
disableMaxKeyFee,
localMaxKeyFee,
} = this.props;
const noDaemonSettings = !daemonSettings || Object.keys(daemonSettings).length === 0;
const isDarkModeEnabled = currentTheme === 'dark';
const disableMaxKeyFee = !(daemonSettings && daemonSettings.max_key_fee);
return (
<Page>
{noDaemonSettings ? (