removes redundant logPublish calls

This commit is contained in:
jessop 2019-10-16 17:36:50 -04:00 committed by Sean Yesmunt
parent 30fca67550
commit 7af4a63400
3 changed files with 7 additions and 15 deletions

View file

@ -15,8 +15,7 @@ type Analytics = {
setUser: Object => void,
toggle: (boolean, ?boolean) => void,
apiLogView: (string, string, string, ?number, ?() => void) => Promise<any>,
apiLogPublish: () => void,
apiPublishNew: (ChannelClaim | StreamClaim) => void,
apiLogPublish: (ChannelClaim | StreamClaim) => void,
tagFollowEvent: (string, boolean, string) => void,
emailProvidedEvent: () => void,
emailVerifiedEvent: () => void,
@ -25,7 +24,7 @@ type Analytics = {
readyEvent: number => void,
};
type PublishNewParams = {
type LogPublishParams = {
uri: string,
claim_id: string,
outpoint: string,
@ -88,13 +87,7 @@ const analytics: Analytics = {
Lbryio.call('event', 'search');
}
},
apiLogPublish: () => {
if (analyticsEnabled && isProduction) {
Lbryio.call('event', 'publish');
}
},
apiPublishNew: (claimResult: ChannelClaim | StreamClaim) => {
apiLogPublish: (claimResult: ChannelClaim | StreamClaim) => {
if (analyticsEnabled && isProduction) {
const { permanent_url: uri, claim_id: claimId, txid, nout, signing_channel: signingChannel } = claimResult;
let channelClaimId;
@ -102,11 +95,11 @@ const analytics: Analytics = {
channelClaimId = signingChannel.claim_id;
}
const outpoint = `${txid}:${nout}`;
const params: PublishNewParams = { uri, claim_id: claimId, outpoint };
const params: LogPublishParams = { uri, claim_id: claimId, outpoint };
if (channelClaimId) {
params['channel_claim_id'] = channelClaimId;
}
Lbryio.call('publish', 'new', params);
Lbryio.call('event', 'publish', params);
}
},

View file

@ -125,7 +125,7 @@ class ChannelSection extends React.PureComponent<Props, State> {
creatingChannel: false,
addingChannel: false,
});
analytics.apiPublishNew(channelClaim);
analytics.apiLogPublish(channelClaim);
onChannelChange(channelName);
};

View file

@ -11,10 +11,9 @@ import { doOpenModal } from './app';
export const doPublishDesktop = () => (dispatch: Dispatch, getState: () => {}) => {
const publishSuccess = successResponse => {
const state = getState();
analytics.apiLogPublish();
const myClaims = selectMyClaims(state);
const pendingClaim = successResponse.outputs[0];
analytics.apiPublishNew(pendingClaim);
analytics.apiLogPublish(pendingClaim);
const { permanent_url: url } = pendingClaim;
const actions = [];