Fix partially untranslated text in the Upgrade Modal

## Issue
- "See the" was not encapsulated with the translation macro.
- Split-strings are not translatable for some languages.

## Change
Combine the entire sentence into a single string with variable.
This commit is contained in:
infiinte-persistence 2020-09-01 12:52:07 +08:00 committed by Sean Yesmunt
parent a0df0a0e0a
commit 7edd9f7c92
4 changed files with 30 additions and 5 deletions

View file

@ -24,6 +24,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Fix comment-creation failure if you have recently deleted a channel _community pr!_ ([#4630](https://github.com/lbryio/lbry-desktop/pull/4630))
- Tip Modal: Don't do final submit when the intention is to create New Channel _community pr!_ ([#4629](https://github.com/lbryio/lbry-desktop/pull/4629))
- Fix related + search results loading slowly ([#4657](https://github.com/lbryio/lbry-desktop/pull/4657))
- Fix partially untranslated text in the Upgrade Modal _community pr!_ ([#4722](https://github.com/lbryio/lbry-desktop/pull/4722))
- Fix floating player being paused after dragging _community pr!_ ([#4710](https://github.com/lbryio/lbry-desktop/pull/4710))
## [0.47.1] - [2020-07-23]

View file

@ -212,7 +212,7 @@
"Skip": "Skip",
"An updated version of LBRY is now available.": "An updated version of LBRY is now available.",
"Your version is out of date and may be unreliable or insecure.": "Your version is out of date and may be unreliable or insecure.",
"Want to know what has changed?": "Want to know what has changed?",
"Want to know what has changed? See the %release_notes%.": "Want to know what has changed? See the %release_notes%.",
"release notes": "release notes",
"Read the FAQ": "Read the FAQ",
"Our FAQ answers many common questions.": "Our FAQ answers many common questions.",

View file

@ -5,6 +5,7 @@ import { ipcRenderer } from 'electron';
// @endif
import { Modal } from 'modal/modal';
import Button from 'component/button';
import I18nMessage from 'component/i18nMessage';
type Props = {
closeModal: any => any,
@ -47,8 +48,19 @@ class ModalAutoUpdateDownloaded extends React.PureComponent<Props, State> {
>
<p>{__('A new version of LBRY is ready for you.')}</p>
<p className="help">
{__('Want to know what has changed?')} See the{' '}
<Button button="link" label={__('release notes')} href="https://github.com/lbryio/lbry-desktop/releases" />.
<I18nMessage
tokens={{
release_notes: (
<Button
button="link"
label={__('release notes')}
href="https://github.com/lbryio/lbry-desktop/releases"
/>
),
}}
>
Want to know what has changed? See the %release_notes%.
</I18nMessage>
</p>
</Modal>
);

View file

@ -2,6 +2,7 @@
import React from 'react';
import { Modal } from 'modal/modal';
import Button from 'component/button';
import I18nMessage from 'component/i18nMessage';
type Props = {
downloadUpgrade: () => void,
@ -28,8 +29,19 @@ class ModalUpgrade extends React.PureComponent<Props> {
{__('Your version is out of date and may be unreliable or insecure.')}
</p>
<p className="help">
{__('Want to know what has changed?')} See the{' '}
<Button button="link" label={__('release notes')} href="https://github.com/lbryio/lbry-desktop/releases" />.
<I18nMessage
tokens={{
release_notes: (
<Button
button="link"
label={__('release notes')}
href="https://github.com/lbryio/lbry-desktop/releases"
/>
),
}}
>
Want to know what has changed? See the %release_notes%.
</I18nMessage>
</p>
</Modal>
);