LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Fix double linked-comment if it was also pinned

Browse source 
## Issue
If the linked-comment is also a pinned comment, it was displayed twice.

## Fix
When separating out pinned comments, I forgot that `comment.ByID` was another place where we fetch comments.
This commit is contained in:
infinite-persistence 2021-08-19 17:03:22 +08:00 • committed by infinite-persistence
parent fb03d3a7f9
commit 882c9ca022
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
ui/redux/reducers/comments.js
View file

@ -349,6 +349,7 @@ export default handleActions(
const topLevelCommentsById = Object.assign({}, state.topLevelCommentsById); // was byId {ClaimId -> [commentIds...]}
const topLevelTotalCommentsById = Object.assign({}, state.topLevelTotalCommentsById);
const topLevelTotalPagesById = Object.assign({}, state.topLevelTotalPagesById);
const pinnedCommentsById = Object.assign({}, state.pinnedCommentsById);
const repliesByParentId = Object.assign({}, state.repliesByParentId);
const linkedCommentAncestors = Object.assign({}, state.linkedCommentAncestors);
@ -362,7 +363,11 @@ export default handleActions(
if (comment.parent_id) {
pushToArrayInObject(repliesByParentId, parentId, comment.comment_id);
} else {
pushToArrayInObject(topLevelCommentsById, claimId, comment.comment_id);
if (comment.is_pinned) {
pushToArrayInObject(pinnedCommentsById, claimId, comment.comment_id);
} else {
pushToArrayInObject(topLevelCommentsById, claimId, comment.comment_id);
}
}
};
@ -380,6 +385,7 @@ export default handleActions(
topLevelCommentsById,
topLevelTotalCommentsById,
topLevelTotalPagesById,
pinnedCommentsById,
repliesByParentId,
byId,
commentById,
@ -422,6 +428,7 @@ export default handleActions(
const topLevelCommentsById = Object.assign({}, state.topLevelCommentsById); // was byId {ClaimId -> [commentIds...]}
const topLevelTotalCommentsById = Object.assign({}, state.topLevelTotalCommentsById);
const topLevelTotalPagesById = Object.assign({}, state.topLevelTotalPagesById);
const pinnedCommentsById = Object.assign({}, state.pinnedCommentsById);
const myReacts = Object.assign({}, state.myReactsByCommentId);
const othersReacts = Object.assign({}, state.othersReactsByCommentId);
@ -446,6 +453,7 @@ export default handleActions(
delete topLevelCommentsById[claimId];
delete topLevelTotalCommentsById[claimId];
delete topLevelTotalPagesById[claimId];
delete pinnedCommentsById[claimId];
return {
...state,
@ -454,6 +462,7 @@ export default handleActions(
topLevelCommentsById,
topLevelTotalCommentsById,
topLevelTotalPagesById,
pinnedCommentsById,
myReactsByCommentId: myReacts,
othersReactsByCommentId: othersReacts,
};