LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

show open in app nag less often based on how many times you've closed it

Browse source
This commit is contained in:
Sean Yesmunt 2020-03-30 12:39:06 -04:00
parent 1e2714723f
commit 97b1f27235
1 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
lbrytv/component/openInAppLink/view.jsx
View file

@ -3,10 +3,14 @@ import React from 'react';
import { withRouter } from 'react-router'; import { withRouter } from 'react-router';
import { formatWebUrlIntoLbryUrl } from 'util/url'; import { formatWebUrlIntoLbryUrl } from 'util/url';
import Nag from 'component/common/nag'; import Nag from 'component/common/nag';
import usePersistedState from 'effects/use-persisted-state';
const userAgent = navigator.userAgent.toLowerCase(); const userAgent = navigator.userAgent.toLowerCase();
const isAndroidDevice = userAgent.includes('android'); const isAndroidDevice = userAgent.includes('android');
const isDesktopDevice = typeof window.orientation === 'undefined'; const isDesktopDevice = typeof window.orientation === 'undefined';
const addDaysToMs = (initialNumberInMs: number, daysToAdd: number) => {
return initialNumberInMs + daysToAdd * 1000 * 60 * 60 * 24;
};
type Props = { type Props = {
history: { replace: string => void, push: string => void }, history: { replace: string => void, push: string => void },
@ -23,6 +27,8 @@ function OpenInAppLink(props: Props) {
user, user,
} = props; } = props;
const [showNag, setShowNag] = React.useState(false); const [showNag, setShowNag] = React.useState(false);
const [closeNagClicksCount, setCloseNagClicksCount] = usePersistedState('open-in-app-close-count', 0);
const [closeNagLastDate, setCloseNagLastDate] = usePersistedState('open-in-app-close-date', 0);
const { pathname, search } = location; const { pathname, search } = location;
let params = new URLSearchParams(search); let params = new URLSearchParams(search);
const hasSrcParam = params.get('src'); const hasSrcParam = params.get('src');
@ -47,6 +53,8 @@ function OpenInAppLink(props: Props) {
function handleClose() { function handleClose() {
setShowNag(false); setShowNag(false);
setCloseNagClicksCount(closeNagClicksCount + 1);
setCloseNagLastDate(Date.now());
} }
React.useEffect(() => { React.useEffect(() => {
@ -59,12 +67,18 @@ function OpenInAppLink(props: Props) {
}, [hasSrcParam, search, pathname, replace]); }, [hasSrcParam, search, pathname, replace]);
React.useEffect(() => { React.useEffect(() => {
if ((isAndroidUser && isAndroidDevice) || (isDesktopUser && isDesktopDevice)) { const isOnDeviceToPrompt = (isAndroidUser && isAndroidDevice) || (isDesktopUser && isDesktopDevice);
const dateRightNow = Date.now();
const daysToAddToDate = Math.min(30, Math.pow(2, closeNagClicksCount));
const startDateForAnotherOpenNag = closeNagLastDate + addDaysToMs(closeNagLastDate, daysToAddToDate);
const hasWaitedEnoughTime = dateRightNow > startDateForAnotherOpenNag;
if (isOnDeviceToPrompt && hasWaitedEnoughTime) {
setShowNag(true); setShowNag(true);
} }
// Don't pass showNag into this effect because we only want the initial value // Don't pass showNag into this effect because we only want the initial value
// If the param is removed from the url, the nag should still be shown // If the param is removed from the url, the nag should still be shown
}, [setShowNag, isAndroidUser, isDesktopUser]); }, [setShowNag, isAndroidUser, isDesktopUser, closeNagLastDate, closeNagClicksCount]);
if (!showNag || isWebUserOnly) { if (!showNag || isWebUserOnly) {
return null; return null;