remove old syncSettings usage

ui/component/claimListHeader/index.js

@@ -2,8 +2,7 @@ import { connect } from 'react-redux';
 import { selectFetchingClaimSearch, SETTINGS, selectFollowedTags } from 'lbry-redux';
 import { doToggleTagFollowDesktop } from 'redux/actions/tags';
 import { makeSelectClientSetting } from 'redux/selectors/settings';
-import { doSetClientSetting, doSyncClientSettings } from 'redux/actions/settings';
+import { doSetClientSetting } from 'redux/actions/settings';
-
 import ClaimListDiscover from './view';
 
 const select = state => ({
@@ -15,7 +14,6 @@ const select = state => ({
 const perform = {
   doToggleTagFollowDesktop,
   doSetClientSetting,
-  doSyncClientSettings,
 };
 
 export default connect(select, perform)(ClaimListDiscover);

ui/component/claimListHeader/view.jsx

@@ -29,9 +29,8 @@ type Props = {
   hiddenNsfwMessage?: Node,
   channelIds?: Array<string>,
   tileLayout: boolean,
-  doSetClientSetting: (string, boolean) => void,
+  doSetClientSetting: (string, boolean, ?boolean) => void,
   setPage: number => void,
-  doSyncClientSettings: () => void,
 };
 
 function ClaimListHeader(props: Props) {
@@ -53,7 +52,6 @@ function ClaimListHeader(props: Props) {
     channelIds,
     tileLayout,
     doSetClientSetting,
-    doSyncClientSettings,
     setPage,
   } = props;
   const { action, push, location } = useHistory();
@@ -241,8 +239,7 @@ function ClaimListHeader(props: Props) {
             {tileLayout !== undefined && (
               <Button
                 onClick={() => {
-                  doSetClientSetting(SETTINGS.TILE_LAYOUT, !tileLayout);
+                  doSetClientSetting(SETTINGS.TILE_LAYOUT, !tileLayout, true);
-                  doSyncClientSettings();
                 }}
                 button="alt"
                 className="button-toggle"

ui/component/notification/view.jsx

@@ -122,7 +122,7 @@ export default function Notification(props: Props) {
 
           <div className="notification__extra">
             <div className="notification__time">
-              <DateTime timeAgo date={notification.created_at} />
+              <DateTime timeAgo date={notification.active_at} />
             </div>
             {!is_seen && <Button className="notification__mark-seen" onClick={handleSeeNotification} />}
           </div>

ui/component/userSignUp/index.js

@@ -2,7 +2,7 @@ import REWARD_TYPES from 'rewards';
 import { connect } from 'react-redux';
 import { selectGetSyncIsPending, selectSyncHash } from 'lbryinc';
 import { doClaimRewardType } from 'redux/actions/rewards';
-import { doSyncClientSettings, doSetClientSetting } from 'redux/actions/settings';
+import { doSetClientSetting } from 'redux/actions/settings';
 import { selectClaimedRewards, makeSelectIsRewardClaimPending } from 'redux/selectors/rewards';
 import { doUserFetch } from 'redux/actions/user';
 import {
@@ -61,8 +61,7 @@ const perform = dispatch => ({
         notifyError: false,
       })
     ),
-  syncSettings: () => dispatch(doSyncClientSettings()),
+  setClientSetting: (setting, value, pushToPrefs) => dispatch(doSetClientSetting(setting, value, pushToPrefs)),
-  setClientSetting: (setting, value) => dispatch(doSetClientSetting(setting, value)),
   doToggleInterestedInYoutubeSync: () => dispatch(doToggleInterestedInYoutubeSync()),
 });
 

ui/component/userSignUp/view.jsx

@@ -39,8 +39,7 @@ type Props = {
   hasSynced: boolean,
   syncingWallet: boolean,
   creatingChannel: boolean,
-  syncSettings: () => void,
+  setClientSetting: (string, boolean, ?boolean) => void,
-  setClientSetting: (string, boolean) => void,
   followingAcknowledged: boolean,
   tagsAcknowledged: boolean,
   rewardsAcknowledged: boolean,
@@ -68,7 +67,6 @@ function UserSignUp(props: Props) {
     followingAcknowledged,
     tagsAcknowledged,
     rewardsAcknowledged,
-    syncSettings,
     setClientSetting,
     interestedInYoutubeSync,
     doToggleInterestedInYoutubeSync,
@@ -128,8 +126,7 @@ function UserSignUp(props: Props) {
     canHijackSignInFlowWithSpinner && (isCurrentlyFetchingSomething || isWaitingForSomethingToFinish);
 
   function setSettingAndSync(setting, value) {
-    setClientSetting(setting, value);
+    setClientSetting(setting, value, true);
-    syncSettings();
   }
 
   React.useEffect(() => {

ui/page/settingsAdvanced/view.jsx

@@ -53,7 +53,7 @@ type Props = {
   findingFFmpeg: boolean,
   findFFmpeg: () => void,
   language?: string,
-  syncSettings: () => void,
+  syncEnabled: boolean,
   enterSettings: () => void,
   exitSettings: () => void,
 };
@@ -412,6 +412,7 @@ class SettingsPage extends React.PureComponent<Props, State> {
                     placeholder={__('A Folder containing FFmpeg')}
                     currentPath={ffmpegPath || daemonSettings.ffmpeg_path}
                     onFileChosen={(newDirectory: WebFile) => {
+                      // $FlowFixMe
                       this.onFFmpegFolder(newDirectory.path);
                     }}
                     disabled={Boolean(ffmpegPath)}