LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Pass the title and channel name to Chromecast.

Browse source 
I'm a bit wary of adding props to this component due to the 'dispose' call, but I think 'source' and 'claim' will update together, so it shouldn't be an issue?
This commit is contained in:
infiinte-persistence 2021-01-14 16:01:04 +08:00 • committed by Sean Yesmunt
parent 65ce47a7d1
commit bb828385d0
2 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
ui/component/viewers/videoViewer/internal/videojs.jsx
View file

@ -46,6 +46,7 @@ export type Player = {
type Props = {
source: string,
claim: StreamClaim,
sourceType: string,
poster: ?string,
onPlayerReady: Player => void,
@ -160,13 +161,16 @@ class ChromecastWrapper {
/**
* Actions that need to happen before initializing 'videojs'.
*/
static preInit(videojs, options, title) {
static preInit(videojs, options, claim) {
const additionalOptions = {
// @if TARGET='web'
techOrder: ['chromecast', 'html5'],
chromecast: {
requestTitleFn: function(src) {
return '';
return claim && claim.value && claim.value.title ? claim.value.title : '';
},
requestSubtitleFn: function(src) {
return claim && claim.signing_channel && claim.signing_channel.name ? claim.signing_channel.name : '';
},
},
// @endif
@ -203,7 +207,7 @@ class ChromecastWrapper {
properties for this component should be kept to ONLY those that if changed should REQUIRE an entirely new videojs element
*/
export default React.memo<Props>(function VideoJs(props: Props) {
const { startMuted, source, sourceType, poster, isAudio, onPlayerReady } = props;
const { startMuted, source, claim, sourceType, poster, isAudio, onPlayerReady } = props;
const [reload, setReload] = useState('initial');
let player: ?Player;
@ -383,7 +387,7 @@ export default React.memo<Props>(function VideoJs(props: Props) {
videoJsOptions.sources[0].type = 'application/x-mpegURL';
}
videoJsOptions = ChromecastWrapper.preInit(videojs, videoJsOptions);
videoJsOptions = ChromecastWrapper.preInit(videojs, videoJsOptions, claim);
player = videojs(el, videoJsOptions, () => {
if (player) {

1
ui/component/viewers/videoViewer/view.jsx
View file

@ -220,6 +220,7 @@ function VideoViewer(props: Props) {
{isLoading && <LoadingScreen status={__('Loading')} />}
<VideoJs
source={source}
claim={claim}
isAudio={isAudio}
poster={isAudio || (embedded && !autoplayIfEmbedded) ? thumbnail : null}
sourceType={forcePlayer ? 'video/mp4' : contentType}