Encode automplete search string and don't autocomplete for empty query

This commit is contained in:
ioancole 2020-09-11 01:12:32 +08:00 committed by Sean Yesmunt
parent 055a476d2f
commit bb9bde1c19

View file

@ -45,7 +45,7 @@ export const getSearchSuggestions = (value: string) => (dispatch: Dispatch, getS
return; return;
} }
fetch(`${CONNECTION_STRING}autocomplete?s=${searchValue}`) fetch(`${CONNECTION_STRING}autocomplete?s=${encodeURIComponent(searchValue)}`)
.then(handleFetchResponse) .then(handleFetchResponse)
.then(apiSuggestions => { .then(apiSuggestions => {
dispatch({ dispatch({
@ -72,6 +72,8 @@ export const doUpdateSearchQuery = (query: string, shouldSkipSuggestions: ?boole
data: { query }, data: { query },
}); });
if (!query) return;
// Don't fetch new suggestions if the user just added a space // Don't fetch new suggestions if the user just added a space
if (!query.endsWith(' ') || !shouldSkipSuggestions) { if (!query.endsWith(' ') || !shouldSkipSuggestions) {
throttledSearchSuggestions(dispatch, query); throttledSearchSuggestions(dispatch, query);