LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

review changes

Browse source
This commit is contained in:
jessop 2020-01-23 13:44:55 -05:00 committed by Sean Yesmunt
parent 2261a92fe5
commit c2eaac6729
5 changed files with 12 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.lintstagedrc.json
View file

@ -1,6 +1,7 @@
{ {
"linters": { "linters": {
"ui/**/*.{js,jsx,scss,json}": ["prettier --write", "git add"], "ui/**/*.{js,jsx,scss,json}": ["prettier --write", "git add"],
"lbrytv/component/*.{js,jsx,scss,json}": ["prettier --write", "git add"],
"ui/**/*.{js,jsx}": ["eslint", "flow focus-check --color always", "git add"] "ui/**/*.{js,jsx}": ["eslint", "flow focus-check --color always", "git add"]
} }
} }

16
lbrytv/component/ad/index.jsx → lbrytv/component/ads.jsx
View file

@ -15,19 +15,23 @@ function Extra(props) {
document.body.removeChild(script); document.body.removeChild(script);
// if user navigates too rapidly, <style> tags can build up // if user navigates too rapidly, <style> tags can build up
if (document.body.getElementsByTagName('style').length) { if (document.body.getElementsByTagName('style').length) {
document.body.getElementsByTagName('style')[0].remove(); document.body.getElementsByTagName('style')[0].remove();
} }
}; };
}, []); }, []);
return ( return (
<> <>
<div><p>Ads</p></div> <p>Ads</p>
<div> <div
<div id="rc-widget-0a74cf" data-rc-widget data-widget-host="habitat" data-endpoint="//trends.revcontent.com" data-widget-id="117427" /> id="rc-widget-0a74cf"
</div> data-rc-widget
data-widget-host="habitat"
data-endpoint="//trends.revcontent.com"
data-widget-id="117427"
/>
</> </>
); );
}; }
export default Extra; export default Extra;

2
ui/component/sideNavigation/view.jsx
View file

@ -8,7 +8,7 @@ import Tag from 'component/tag';
import StickyBox from 'react-sticky-box/dist/esnext'; import StickyBox from 'react-sticky-box/dist/esnext';
import Spinner from 'component/spinner'; import Spinner from 'component/spinner';
import usePersistedState from 'effects/use-persisted-state'; import usePersistedState from 'effects/use-persisted-state';
import Ad from 'lbrytv/component/ad'; import Ad from 'lbrytv/component/ads';
const SHOW_CHANNELS = 'SHOW_CHANNELS'; const SHOW_CHANNELS = 'SHOW_CHANNELS';
const SHOW_TAGS = 'SHOW_TAGS'; const SHOW_TAGS = 'SHOW_TAGS';

2
ui/scss/component/_navigation.scss
View file

@ -15,7 +15,6 @@
.navigation--placeholder { .navigation--placeholder {
@extend .navigation; @extend .navigation;
padding: var(--spacing-quarter) 0rem;
border-radius: var(--card-radius); border-radius: var(--card-radius);
position: relative; position: relative;
margin: auto; margin: auto;
@ -23,7 +22,6 @@
p { p {
font-size: var(--font-xsmall); font-size: var(--font-xsmall);
color: var(--color-text-subtitle); color: var(--color-text-subtitle);
padding: var(--spacing-quarter);
} }
} }

1
ui/scss/init/_vars.scss
View file

@ -11,7 +11,6 @@ $breakpoint-small: 900px;
--mac-titlebar-height: 1.5rem; --mac-titlebar-height: 1.5rem;
--mobile: 600px; --mobile: 600px;
--side-nav-width: 170px; --side-nav-width: 170px;
--spacing-quarter: calc(1rem / 4);
--spacing-miniscule: calc(2rem / 5); --spacing-miniscule: calc(2rem / 5);
--spacing-xsmall: calc(2rem / 4); --spacing-xsmall: calc(2rem / 4);
--spacing-small: calc(2rem / 3); --spacing-small: calc(2rem / 3);