LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Fix named capturing groups not supported in most browsers

Browse source
This commit is contained in:
Rafael 2021-12-10 12:12:18 -03:00 committed by Thomas Zarebczan
parent 132d6ba50c
commit c7790693df
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
ui/component/textareaWithSuggestions/view.jsx
View file

@ -15,13 +15,13 @@ import useLighthouse from 'effects/use-lighthouse';
import useThrottle from 'effects/use-throttle'; import useThrottle from 'effects/use-throttle';
const SUGGESTION_REGEX = new RegExp( const SUGGESTION_REGEX = new RegExp(
'(?<Mention>(?:^| |\n)@[^\\s=&#$@%?:;/\\"<>%{}|^~[]*(?::[\\w]+)?)|(?<Emote>(?:^| |\n):[\\w+-]*:?)', '((?:^| |\n)@[^\\s=&#$@%?:;/\\"<>%{}|^~[]*(?::[\\w]+)?)|((?:^| |\n):[\\w+-]*:?)',
'gm' 'gm'
); );
/** Regex Explained step-by-step: /** Regex Explained step-by-step:
* *
* 1) (?<Name>....) = naming a match into a possible group (either Mention or Emote) * 1) ()|() = different capturing groups (either Mention or Emote)
* 2) (?:^| |\n) = only allow for: sentence beginning, space or newline before the match (no words or symbols) * 2) (?:^| |\n) = only allow for: sentence beginning, space or newline before the match (no words or symbols)
* 3) [^\s=&#$@%?:;/\\"<>%{}|^~[]* = anything, except the characters inside * 3) [^\s=&#$@%?:;/\\"<>%{}|^~[]* = anything, except the characters inside
* 4) (?::[\w]+)? = A mention can be matched with a ':' as a claim modifier with words or digits after as ID digits, * 4) (?::[\w]+)? = A mention can be matched with a ':' as a claim modifier with words or digits after as ID digits,
@ -192,11 +192,9 @@ export default function TextareaWithSuggestions(props: Props) {
} }
const exec = SUGGESTION_REGEX.exec(value); const exec = SUGGESTION_REGEX.exec(value);
const groups = exec && exec.groups;
const groupValue = groups && Object.keys(groups).find((group) => groups[group]);
const previousLastIndexes = []; const previousLastIndexes = [];
let isEmote = groupValue && groupValue === 'Emote'; let isEmote = exec && exec[2];
let currentSuggestionIndex = exec && exec.index; let currentSuggestionIndex = exec && exec.index;
let currentLastIndex = exec && SUGGESTION_REGEX.lastIndex; let currentLastIndex = exec && SUGGESTION_REGEX.lastIndex;
let currentSuggestionValue = let currentSuggestionValue =
@ -212,11 +210,9 @@ export default function TextareaWithSuggestions(props: Props) {
const tempRe = new RegExp(SUGGESTION_REGEX); const tempRe = new RegExp(SUGGESTION_REGEX);
const tempExec = tempRe.exec(valueWithoutPrevious); const tempExec = tempRe.exec(valueWithoutPrevious);
const groups = tempExec && tempExec.groups;
const groupValue = groups && Object.keys(groups).find((group) => groups[group]);
if (tempExec) { if (tempExec) {
isEmote = groupValue && groupValue === 'Emote'; isEmote = tempExec && tempExec[2];
currentSuggestionIndex = previousLastIndex + tempExec.index; currentSuggestionIndex = previousLastIndex + tempExec.index;
currentLastIndex = previousLastIndex + tempRe.lastIndex; currentLastIndex = previousLastIndex + tempRe.lastIndex;
previousLastIndexes.push(currentLastIndex); previousLastIndexes.push(currentLastIndex);