Membership-name state updates

- Corrected flow definitions.
- Properly differentiate between "not yet fetched" and "no membership" as "undefined" and "<empty string>", respectively. There are GUI elements that need to know the unfetched case.

flow-typed/user.js

@@ -64,6 +64,7 @@ declare type UserState ={
   youtubeChannelImportErrorMessage: string,
   referrerSetIsPending: boolean,
   referrerSetError: string,
+  odyseeMembershipName: ?string, // undefined: not fetched, '': no membership
   odyseeMembershipsPerClaimIds: ?{ [string]: string },
   locale: ?LocaleInfo,
 };

ui/component/headerMenuButtons/view.jsx

@@ -19,7 +19,7 @@ type HeaderMenuButtonProps = {
   user: ?User,
   handleThemeToggle: (boolean, string) => void,
   doOpenModal: (string, {}) => void,
-  odyseeMembership: string,
+  odyseeMembership: ?string,
 };
 
 export default function HeaderMenuButtons(props: HeaderMenuButtonProps) {

ui/component/sideNavigation/view.jsx

@@ -138,7 +138,7 @@ type Props = {
   user: ?User,
   homepageData: any,
   doClearClaimSearch: () => void,
-  odyseeMembership: string,
+  odyseeMembership: ?string,
   odyseeMembershipByUri: (uri: string) => string,
   doFetchLastActiveSubs: (force?: boolean, count?: number) => void,
 };

ui/page/home/view.jsx

@@ -44,7 +44,7 @@ type Props = {
   adBlockerFound: ?boolean,
   homepageOrder: HomepageOrder,
   doOpenModal: (id: string, ?{}) => void,
-  hasMembership: boolean,
+  hasMembership: ?boolean,
 };
 
 function HomePage(props: Props) {

ui/redux/actions/user.js

@@ -155,7 +155,7 @@ export function doCheckUserOdyseeMemberships(user) {
 
     dispatch({
       type: ACTIONS.ADD_ODYSEE_MEMBERSHIP_DATA,
-      data: { user, odyseeMembershipName: highestMembershipRanking },
+      data: { user, odyseeMembershipName: highestMembershipRanking || '' }, // '' = none; `undefined` = not fetched
     });
   };
 }

ui/redux/reducers/user.js

@@ -30,6 +30,7 @@ const defaultState: UserState = {
   youtubeChannelImportErrorMessage: '',
   referrerSetIsPending: false,
   referrerSetError: '',
+  odyseeMembershipName: undefined,
   odyseeMembershipsPerClaimIds: undefined,
   locale: undefined,
   homepageFetched: false,

ui/redux/selectors/user.js

@@ -106,30 +106,32 @@ export const selectYouTubeImportError = (state) => selectState(state).youtubeCha
 export const selectSetReferrerPending = (state) => selectState(state).referrerSetIsPending;
 export const selectSetReferrerError = (state) => selectState(state).referrerSetError;
 
+// undefined = not fetched
+// '' = no membership
+// '<name>' = membership name
 export const selectOdyseeMembershipName = (state) => selectState(state).odyseeMembershipName;
 
+/**
+ * @param state
+ * @returns {undefined|boolean} 'undefined' if not yet fetched; boolean otherwise.
+ */
 export const selectOdyseeMembershipIsPremiumPlus = (state) => {
-  const odyseeMembershipName = selectState(state).odyseeMembershipName;
+  const name = selectOdyseeMembershipName(state);
-  if (!odyseeMembershipName) return undefined;
+  return name === undefined ? undefined : name === 'Premium+';
-  return selectState(state).odyseeMembershipName === 'Premium+';
 };
 
 /**
- * selectHasOdyseeMembership
- *
  * @param state
- * @returns 'undefined' if not yet fetched; boolean otherwise.
+ * @returns {undefined|boolean} 'undefined' if not yet fetched; boolean otherwise.
  */
 export const selectHasOdyseeMembership = (state) => {
   // @if process.env.NODE_ENV!='production'
   const override = window.localStorage.getItem('hasMembershipOverride');
-  if (override) {
+  if (override) return override === 'true';
-    return override === 'true';
-  }
   // @endif
 
-  const membership = selectOdyseeMembershipName(state);
+  const name = selectOdyseeMembershipName(state);
-  return membership === undefined ? membership : Boolean(membership);
+  return name === undefined ? undefined : Boolean(name);
 };
 
 export const selectYouTubeImportVideosComplete = createSelector(selectState, (state) => {