LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

cleanup plugin code

Browse source
This commit is contained in:
DispatchCommit 2021-02-17 19:32:05 -08:00 committed by Sean Yesmunt
parent 0fff2542b7
commit d5d97fe6e7
3 changed files with 4 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
package.json
View file

@ -206,7 +206,6 @@
"video.js": "^7.10.1", "video.js": "^7.10.1",
"videojs-contrib-quality-levels": "^2.0.9", "videojs-contrib-quality-levels": "^2.0.9",
"videojs-event-tracking": "^1.0.1", "videojs-event-tracking": "^1.0.1",
"videojs-hls-quality-selector": "^1.1.4",
"villain-react": "^1.0.9", "villain-react": "^1.0.9",
"wavesurfer.js": "^2.2.1", "wavesurfer.js": "^2.2.1",
"webpack": "^4.28.4", "webpack": "^4.28.4",

16
ui/component/viewers/videoViewer/internal/plugins/videojs-hls-quality-selector/plugin.js
View file

@ -8,7 +8,6 @@ const defaults = {};
// Cross-compatibility for Video.js 5 and 6. // Cross-compatibility for Video.js 5 and 6.
const registerPlugin = videojs.registerPlugin || videojs.plugin; const registerPlugin = videojs.registerPlugin || videojs.plugin;
// const dom = videojs.dom || videojs;
/** /**
* VideoJS HLS Quality Selector Plugin class. * VideoJS HLS Quality Selector Plugin class.
@ -25,8 +24,9 @@ class HlsQualitySelectorPlugin {
this.player = player; this.player = player;
this.config = options; this.config = options;
// Ensure dependencies are met
if (!this.player.qualityLevels) { if (!this.player.qualityLevels) {
console.warn(`WARNING: Missing video.js quality levels plugin (required)`); console.error(`Error: Missing video.js quality levels plugin (required) - videojs-hls-quality-selector`);
return; return;
} }
@ -42,23 +42,16 @@ class HlsQualitySelectorPlugin {
// Listen for source changes // Listen for source changes
this.player.on('loadedmetadata', (e) => { this.player.on('loadedmetadata', (e) => {
console.log(`Loaded Metadata detected by plugin!`, e);
this.updatePlugin(); this.updatePlugin();
}); });
} }
updatePlugin() { updatePlugin() {
console.log(`Updating Quality Selector...`); // If there is the HLS tech
// If there is quality levels plugin and the HLS tech exists
// then continue.
if (this.getHls()) { if (this.getHls()) {
console.log('Show quality selector');
// Show quality selector // Show quality selector
this._qualityButton.show(); this._qualityButton.show();
} else { } else {
console.log('Hide quality selector');
console.log('Source type does not support multiple qulaity levels...');
// Hide quality selector // Hide quality selector
this._qualityButton.hide(); this._qualityButton.hide();
} }
@ -84,7 +77,6 @@ class HlsQualitySelectorPlugin {
* Adds the quality menu button to the player control bar. * Adds the quality menu button to the player control bar.
*/ */
createQualityButton() { createQualityButton() {
const player = this.player; const player = this.player;
this._qualityButton = new ConcreteButton(player); this._qualityButton = new ConcreteButton(player);
@ -145,7 +137,7 @@ class HlsQualitySelectorPlugin {
}).length) { }).length) {
const levelItem = this.getQualityMenuItem.call(this, { const levelItem = this.getQualityMenuItem.call(this, {
label: levels[i].height + 'p', label: levels[i].height + 'p',
value: levels[i].height value: levels[i].height,
}); });
levelItems.push(levelItem); levelItems.push(levelItem);

1
ui/component/viewers/videoViewer/internal/videojs.jsx
View file

@ -8,7 +8,6 @@ import 'video.js/dist/alt/video-js-cdn.min.css';
import eventTracking from 'videojs-event-tracking'; import eventTracking from 'videojs-event-tracking';
import * as OVERLAY from './overlays'; import * as OVERLAY from './overlays';
import './plugins/videojs-mobile-ui/plugin'; import './plugins/videojs-mobile-ui/plugin';
// import qualitySelector from 'videojs-hls-quality-selector';
import hlsQualitySelector from './plugins/videojs-hls-quality-selector/plugin'; import hlsQualitySelector from './plugins/videojs-hls-quality-selector/plugin';
import qualityLevels from 'videojs-contrib-quality-levels'; import qualityLevels from 'videojs-contrib-quality-levels';
import isUserTyping from 'util/detect-typing'; import isUserTyping from 'util/detect-typing';