LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

define magic numbers as constants

Browse source
This commit is contained in:
DispatchCommit 2021-06-22 07:42:52 -07:00
parent f6176f048d
commit d83856c6cf
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
ui/component/livestreamComments/view.jsx
View file

@ -28,6 +28,8 @@ type Props = {
const VIEW_MODE_CHAT = 'view_chat';
const VIEW_MODE_SUPER_CHAT = 'view_superchat';
const COMMENT_SCROLL_OFFSET = 100;
const COMMENT_SCROLL_TIMEOUT = 25;
export default function LivestreamComments(props: Props) {
const {
@ -84,8 +86,8 @@ export default function LivestreamComments(props: Props) {
function handleScroll() {
if (discussionElement) {
const negativeCommentHeight = commentElement && (-1 * commentElement.offsetHeight);
const isAtRecent = negativeCommentHeight && (discussionElement.scrollTop >= negativeCommentHeight);
const negativeCommentHeight = commentElement && -1 * commentElement.offsetHeight;
const isAtRecent = negativeCommentHeight && discussionElement.scrollTop >= negativeCommentHeight;
setScrollBottom(isAtRecent);
}
@ -98,7 +100,12 @@ export default function LivestreamComments(props: Props) {
// Only update comment scroll if the user hasn't scrolled up to view old comments
// If they have, do nothing
if (!performedInitialScroll) {
setTimeout(() => (discussionElement.scrollTop = discussionElement.scrollHeight - discussionElement.offsetHeight + 100), 20);
setTimeout(
() =>
(discussionElement.scrollTop =
discussionElement.scrollHeight - discussionElement.offsetHeight + COMMENT_SCROLL_OFFSET),
COMMENT_SCROLL_TIMEOUT
);
setPerformedInitialScroll(true);
}
}