LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Assume weekly_watch is claimed when data is insufficient (#1806)

Browse source 
## Issue
If the reward-list fetch is slow, the selector assumes the weekly_watch hasn't been claimed yet, causing an unnecessary claim.

## Change
The selector now tells the caller if there is no data -- up to caller on what to do (in this case, don't claim the reward).

It should be harmless if the claim action was missed, since the user can still manually claim it.
This commit is contained in:
infinite-persistence 2022-07-07 17:16:36 +08:00 committed by GitHub
parent e073e120a1
commit da691f286e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ui/redux/actions/rewards.js
View file

@ -144,7 +144,7 @@ export function doClaimEligiblePurchaseRewards() {
if (unclaimedRewards.find((ur) => ur.reward_type === rewards.TYPE_FIRST_STREAM)) { if (unclaimedRewards.find((ur) => ur.reward_type === rewards.TYPE_FIRST_STREAM)) {
dispatch(doClaimRewardType(rewards.TYPE_FIRST_STREAM)); dispatch(doClaimRewardType(rewards.TYPE_FIRST_STREAM));
} else { } else {
if (!selectWeeklyWatchClaimedThisWeek(state)) { if (selectWeeklyWatchClaimedThisWeek(state) === false) {
dispatch(doClaimRewardType(rewards.TYPE_WEEKLY_WATCH, { failSilently: true })); dispatch(doClaimRewardType(rewards.TYPE_WEEKLY_WATCH, { failSilently: true }));
} }
} }

2
ui/redux/selectors/rewards.js
View file

@ -80,7 +80,7 @@ export const selectWeeklyWatchClaimedThisWeek = createSelector(selectUnclaimedRe
const diffDays = diff / (1000 * 60 * 60 * 24); const diffDays = diff / (1000 * 60 * 60 * 24);
return diffDays < 6.5; return diffDays < 6.5;
} }
return false; return undefined;
}); });
export const selectIsRewardApproved = createSelector(selectUser, (user) => user && user.is_reward_approved); export const selectIsRewardApproved = createSelector(selectUser, (user) => user && user.is_reward_approved);