LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Handle re-reselect warning on null/undefined key

Browse source 
Should be a harmless warning, but cleaning up nonetheless.
This commit is contained in:
infinite-persistence 2021-10-25 12:58:34 +08:00
parent 27f346d8f1
commit dad7264636
No known key found for this signature in database
GPG key ID: B9C3252EDC3D0AA0
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ui/redux/selectors/claims.js
View file

@ -106,7 +106,7 @@ export const selectClaimForUri = createCachedSelector(
} }
} }
} }
)((state, uri, returnRepost = true) => `${uri}:${returnRepost ? '1' : '0'}`); )((state, uri, returnRepost = true) => `${String(uri)}:${returnRepost ? '1' : '0'}`);
export const makeSelectClaimForUri = (uri: string, returnRepost: boolean = true) => export const makeSelectClaimForUri = (uri: string, returnRepost: boolean = true) =>
createSelector(selectClaimIdsByUri, selectClaimsById, (byUri, byId) => { createSelector(selectClaimIdsByUri, selectClaimsById, (byUri, byId) => {
@ -264,7 +264,7 @@ export const makeSelectTotalPagesInChannelSearch = (uri: string) =>
export const selectMetadataForUri = createCachedSelector(selectClaimForUri, (claim, uri) => { export const selectMetadataForUri = createCachedSelector(selectClaimForUri, (claim, uri) => {
const metadata = claim && claim.value; const metadata = claim && claim.value;
return metadata || (claim === undefined ? undefined : null); return metadata || (claim === undefined ? undefined : null);
})((state, uri) => uri); })((state, uri) => String(uri));
export const makeSelectMetadataForUri = (uri: string) => export const makeSelectMetadataForUri = (uri: string) =>
createSelector(makeSelectClaimForUri(uri), (claim) => { createSelector(makeSelectClaimForUri(uri), (claim) => {
@ -297,7 +297,7 @@ export const selectDateForUri = createCachedSelector(
const dateObj = new Date(timestamp); const dateObj = new Date(timestamp);
return dateObj; return dateObj;
} }
)((state, uri) => uri); )((state, uri) => String(uri));
export const makeSelectAmountForUri = (uri: string) => export const makeSelectAmountForUri = (uri: string) =>
createSelector(makeSelectClaimForUri(uri), (claim) => { createSelector(makeSelectClaimForUri(uri), (claim) => {
@ -530,7 +530,7 @@ export const makeSelectMyChannelPermUrlForName = (name: string) =>
export const selectTagsForUri = createCachedSelector(selectMetadataForUri, (metadata: ?GenericMetadata) => { export const selectTagsForUri = createCachedSelector(selectMetadataForUri, (metadata: ?GenericMetadata) => {
return (metadata && metadata.tags) || []; return (metadata && metadata.tags) || [];
})((state, uri) => uri); })((state, uri) => String(uri));
export const makeSelectTagsForUri = (uri: string) => export const makeSelectTagsForUri = (uri: string) =>
createSelector(makeSelectMetadataForUri(uri), (metadata: ?GenericMetadata) => { createSelector(makeSelectMetadataForUri(uri), (metadata: ?GenericMetadata) => {

8
ui/redux/selectors/comments.js
View file

@ -67,7 +67,7 @@ export const selectPinnedCommentsForUri = createCachedSelector(
return pinnedComments; return pinnedComments;
} }
)((state, uri) => uri); )((state, uri) => String(uri));
export const selectModerationBlockList = createSelector( export const selectModerationBlockList = createSelector(
(state) => selectState(state).moderationBlockList, (state) => selectState(state).moderationBlockList,
@ -205,7 +205,7 @@ export const selectCommentsForUri = createCachedSelector(
const comments = byClaimId && byClaimId[claimId]; const comments = byClaimId && byClaimId[claimId];
return filterComments(comments, claimId, filterInputs); return filterComments(comments, claimId, filterInputs);
} }
)((state, uri) => uri); )((state, uri) => String(uri));
export const selectTopLevelCommentsForUri = createCachedSelector( export const selectTopLevelCommentsForUri = createCachedSelector(
(state, uri) => uri, (state, uri) => uri,
@ -219,7 +219,7 @@ export const selectTopLevelCommentsForUri = createCachedSelector(
const filtered = filterComments(comments, claimId, filterInputs); const filtered = filterComments(comments, claimId, filterInputs);
return maxCount > 0 ? filtered.slice(0, maxCount) : filtered; return maxCount > 0 ? filtered.slice(0, maxCount) : filtered;
} }
)((state, uri, maxCount = -1) => `${uri}:${maxCount}`); )((state, uri, maxCount = -1) => `${String(uri)}:${maxCount}`);
export const makeSelectTopLevelTotalCommentsForUri = (uri: string) => export const makeSelectTopLevelTotalCommentsForUri = (uri: string) =>
createSelector(selectState, selectCommentsByUri, (state, byUri) => { createSelector(selectState, selectCommentsByUri, (state, byUri) => {
@ -251,7 +251,7 @@ export const selectRepliesForParentId = createCachedSelector(
return filterComments(comments, undefined, filterInputs); return filterComments(comments, undefined, filterInputs);
} }
)((state, id: string) => id); )((state, id: string) => String(id));
/** /**
* filterComments * filterComments